You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/08/09 16:46:42 UTC
[GitHub] [solr] epugh opened a new pull request, #969: SOLR-16331: add xml suffix to remaining managed schema files
epugh opened a new pull request, #969:
URL: https://github.com/apache/solr/pull/969
https://issues.apache.org/jira/browse/SOLR-16331
# Description
Converting remaining `managed-schema` to `managed-schema.xml`.
# Solution
Please provide a short description of the approach taken to implement your solution.
# Tests
ran tests and manually tested `bin/solr start` commands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on a diff in pull request #969: SOLR-16331: add xml suffix to remaining managed schema files
Posted by GitBox <gi...@apache.org>.
dsmiley commented on code in PR #969:
URL: https://github.com/apache/solr/pull/969#discussion_r941921149
##########
solr/core/src/test-files/solr/configsets/upload/legacy-managed-schema/managed-schema:
##########
@@ -15,6 +15,9 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
+
+<!-- This file should be called managed-schema.xml, but leaving it here to prove
+that we still are backwards compatible with this format. -->
Review Comment:
great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #969: SOLR-16331: add xml suffix to remaining managed schema files
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #969:
URL: https://github.com/apache/solr/pull/969#issuecomment-1209697356
I think this is ready. I left one `managed-schema` example. @dsmiley, I would love a review since you reviewed the related issue. ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh merged pull request #969: SOLR-16331: add xml suffix to remaining managed schema files
Posted by GitBox <gi...@apache.org>.
epugh merged PR #969:
URL: https://github.com/apache/solr/pull/969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org