[jira] [Commented] (THRIFT-2683) c_glib: Seg fault when deserializing a map with typedef'd keys

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197590#comment-14197590 ] 

Hudson commented on THRIFT-2683:
--------------------------------

SUCCESS: Integrated in Thrift #1331 (See [https://builds.apache.org/job/Thrift/1331/])
THRIFT-2683 c_glib: Seg fault when deserializing a map with typedef'd keys (roger: rev 546209c9615632fa76edf1cc9604b5ad8837a97c)
* compiler/cpp/src/generate/t_c_glib_generator.cc


> c_glib: Seg fault when deserializing a map with typedef'd keys
> --------------------------------------------------------------
>
>                 Key: THRIFT-2683
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2683
>             Project: Thrift
>          Issue Type: Bug
>          Components: C glib - Compiler
>    Affects Versions: 0.9.1
>         Environment: Fedora 20 64-bit on x86_64
>            Reporter: Simon South
>            Assignee: Simon South
>            Priority: Minor
>              Labels: c_glib, compiler
>             Fix For: 0.9.2
>
>         Attachments: thrift-2683-c_glib-resolve-typedef-when-deserializing-map.patch
>
>
> In the c_glib implementation, attempting to deserialize a map that uses a typedef'd type for its keys will usually result in a segmentation fault.
> This is because the code in the compiler that generates a variable declaration for a pointer to key values fails to first resolve the typedef to its underlying type. In most cases it will therefore generate incorrect code, effectively allocating a variable on the stack but later using it as though it were a pointer.
> The attached patch fixes this. (No test case is provided, but the integration test implementation I'm about to submit relies on this patch.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)