You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Mike Drob (JIRA)" <ji...@apache.org> on 2018/03/01 09:07:00 UTC

[jira] [Commented] (HBASE-20095) Redesign single instance pool in CleanerChore

    [ https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381697#comment-16381697 ] 

Mike Drob commented on HBASE-20095:
-----------------------------------

bq. Chore's pool doesn't initialized, please call
nit: grammar. doesn't => isn't

Why do we need to move to eager initialization instead of lazy init first time we start a chore? Probably discussion on another JIRA that I missed?
Is this related to findbugs complaining about instance access of static variables?

Maybe better to keep lazy init via instance access and have {{static getPool(Configuration)}} method called from constructor that does the init steps?

> Redesign single instance pool in CleanerChore
> ---------------------------------------------
>
>                 Key: HBASE-20095
>                 URL: https://issues.apache.org/jira/browse/HBASE-20095
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Reid Chan
>            Assignee: Reid Chan
>            Priority: Critical
>         Attachments: HBASE-20095.master.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)