[jira] [Commented] (SLING-3326) Create "All bundles started" Health Check

["Bertrand Delacretaz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13876402#comment-13876402 ] 

Bertrand Delacretaz commented on SLING-3326:
--------------------------------------------

Looks good to me, as discussed on list this should to in the support bundle, with an accompanying sample config in the samples bundle.

I think such health checks should only be active if configured explicitly, not sure how to handle this here. Maybe just require a config, and that can contain an empty "ignored bundles" value if it's just mean to activate the health check. As is, IIUC it would be active as soon as the bundle that provides it is active.

I'd prefer saying "ignored bundles" rather than "excluded bundles".

> Create "All bundles started" Health Check
> -----------------------------------------
>
>                 Key: SLING-3326
>                 URL: https://issues.apache.org/jira/browse/SLING-3326
>             Project: Sling
>          Issue Type: New Feature
>          Components: Health Check
>            Reporter: Georg Henzler
>         Attachments: BundlesStartedCheck.java
>
>
> * Checks if all bundles are started, active by default
> * Allows to exclude certain symbolic ids (e.g. useful if bundles like org.apache.sling.jcr.webdav should be disabled for security reasons)
> * There is a scripted version in the samples package (/org.apache.sling.hc.samples/src/main/resources/SLING-CONTENT/apps/hc/demo/install/org.apache.sling.hc.core.impl.ScriptableHealthCheck-2.json), but it does not allow to exclude bundles. As this is a very common use case, maybe a "hard-coded" java version would be better?



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)