You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/11/09 14:53:01 UTC
[05/47] hbase-site git commit: Published site at
fe2265fa4a1e828b2e68ff8e42639c5942dccb1b.
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/9592fdb5/testdevapidocs/src-html/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.html
index 13b918c..fe1ee7f 100644
--- a/testdevapidocs/src-html/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.html
+++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.html
@@ -139,7 +139,7 @@
<span class="sourceLineNo">131</span> when(rl.getWriteRequestCount()).thenReturn(0L);<a name="line.131"></a>
<span class="sourceLineNo">132</span> when(rl.getMemStoreSize()).thenReturn(Size.ZERO);<a name="line.132"></a>
<span class="sourceLineNo">133</span> when(rl.getStoreFileSize()).thenReturn(Size.ZERO);<a name="line.133"></a>
-<span class="sourceLineNo">134</span> regionLoadMap.put(info.getEncodedNameAsBytes(), rl);<a name="line.134"></a>
+<span class="sourceLineNo">134</span> regionLoadMap.put(info.getRegionName(), rl);<a name="line.134"></a>
<span class="sourceLineNo">135</span> }<a name="line.135"></a>
<span class="sourceLineNo">136</span> when(serverMetrics.getRegionMetrics()).thenReturn(regionLoadMap);<a name="line.136"></a>
<span class="sourceLineNo">137</span> return serverMetrics;<a name="line.137"></a>
@@ -230,273 +230,275 @@
<span class="sourceLineNo">222</span><a name="line.222"></a>
<span class="sourceLineNo">223</span> loadBalancer.setClusterMetrics(clusterStatus);<a name="line.223"></a>
<span class="sourceLineNo">224</span> }<a name="line.224"></a>
-<span class="sourceLineNo">225</span> assertTrue(loadBalancer.loads.get(REGION_KEY) != null);<a name="line.225"></a>
-<span class="sourceLineNo">226</span> assertTrue(loadBalancer.loads.get(REGION_KEY).size() == 15);<a name="line.226"></a>
-<span class="sourceLineNo">227</span><a name="line.227"></a>
-<span class="sourceLineNo">228</span> Queue<BalancerRegionLoad> loads = loadBalancer.loads.get(REGION_KEY);<a name="line.228"></a>
-<span class="sourceLineNo">229</span> int i = 0;<a name="line.229"></a>
-<span class="sourceLineNo">230</span> while(loads.size() > 0) {<a name="line.230"></a>
-<span class="sourceLineNo">231</span> BalancerRegionLoad rl = loads.remove();<a name="line.231"></a>
-<span class="sourceLineNo">232</span> assertEquals(i + (numClusterStatusToAdd - 15), rl.getStorefileSizeMB());<a name="line.232"></a>
-<span class="sourceLineNo">233</span> i ++;<a name="line.233"></a>
-<span class="sourceLineNo">234</span> }<a name="line.234"></a>
-<span class="sourceLineNo">235</span> }<a name="line.235"></a>
-<span class="sourceLineNo">236</span><a name="line.236"></a>
-<span class="sourceLineNo">237</span> @Test<a name="line.237"></a>
-<span class="sourceLineNo">238</span> public void testNeedBalance() {<a name="line.238"></a>
-<span class="sourceLineNo">239</span> float minCost = conf.getFloat("hbase.master.balancer.stochastic.minCostNeedBalance", 0.05f);<a name="line.239"></a>
-<span class="sourceLineNo">240</span> conf.setFloat("hbase.master.balancer.stochastic.minCostNeedBalance", 1.0f);<a name="line.240"></a>
-<span class="sourceLineNo">241</span> loadBalancer.setConf(conf);<a name="line.241"></a>
-<span class="sourceLineNo">242</span> for (int[] mockCluster : clusterStateMocks) {<a name="line.242"></a>
-<span class="sourceLineNo">243</span> Map<ServerName, List<RegionInfo>> servers = mockClusterServers(mockCluster);<a name="line.243"></a>
-<span class="sourceLineNo">244</span> List<RegionPlan> plans = loadBalancer.balanceCluster(servers);<a name="line.244"></a>
-<span class="sourceLineNo">245</span> assertNull(plans);<a name="line.245"></a>
-<span class="sourceLineNo">246</span> }<a name="line.246"></a>
-<span class="sourceLineNo">247</span> // reset config<a name="line.247"></a>
-<span class="sourceLineNo">248</span> conf.setFloat("hbase.master.balancer.stochastic.minCostNeedBalance", minCost);<a name="line.248"></a>
-<span class="sourceLineNo">249</span> loadBalancer.setConf(conf);<a name="line.249"></a>
-<span class="sourceLineNo">250</span> }<a name="line.250"></a>
-<span class="sourceLineNo">251</span><a name="line.251"></a>
-<span class="sourceLineNo">252</span> @Test<a name="line.252"></a>
-<span class="sourceLineNo">253</span> public void testLocalityCost() throws Exception {<a name="line.253"></a>
-<span class="sourceLineNo">254</span> Configuration conf = HBaseConfiguration.create();<a name="line.254"></a>
-<span class="sourceLineNo">255</span> MockNoopMasterServices master = new MockNoopMasterServices();<a name="line.255"></a>
-<span class="sourceLineNo">256</span> StochasticLoadBalancer.CostFunction<a name="line.256"></a>
-<span class="sourceLineNo">257</span> costFunction = new ServerLocalityCostFunction(conf, master);<a name="line.257"></a>
-<span class="sourceLineNo">258</span><a name="line.258"></a>
-<span class="sourceLineNo">259</span> for (int test = 0; test < clusterRegionLocationMocks.length; test++) {<a name="line.259"></a>
-<span class="sourceLineNo">260</span> int[][] clusterRegionLocations = clusterRegionLocationMocks[test];<a name="line.260"></a>
-<span class="sourceLineNo">261</span> MockCluster cluster = new MockCluster(clusterRegionLocations);<a name="line.261"></a>
-<span class="sourceLineNo">262</span> costFunction.init(cluster);<a name="line.262"></a>
-<span class="sourceLineNo">263</span> double cost = costFunction.cost();<a name="line.263"></a>
-<span class="sourceLineNo">264</span> double expected = 1 - expectedLocalities[test];<a name="line.264"></a>
-<span class="sourceLineNo">265</span> assertEquals(expected, cost, 0.001);<a name="line.265"></a>
-<span class="sourceLineNo">266</span> }<a name="line.266"></a>
-<span class="sourceLineNo">267</span> }<a name="line.267"></a>
-<span class="sourceLineNo">268</span><a name="line.268"></a>
-<span class="sourceLineNo">269</span> @Test<a name="line.269"></a>
-<span class="sourceLineNo">270</span> public void testMoveCost() throws Exception {<a name="line.270"></a>
-<span class="sourceLineNo">271</span> Configuration conf = HBaseConfiguration.create();<a name="line.271"></a>
-<span class="sourceLineNo">272</span> StochasticLoadBalancer.CostFunction<a name="line.272"></a>
-<span class="sourceLineNo">273</span> costFunction = new StochasticLoadBalancer.MoveCostFunction(conf);<a name="line.273"></a>
-<span class="sourceLineNo">274</span> for (int[] mockCluster : clusterStateMocks) {<a name="line.274"></a>
-<span class="sourceLineNo">275</span> BaseLoadBalancer.Cluster cluster = mockCluster(mockCluster);<a name="line.275"></a>
-<span class="sourceLineNo">276</span> costFunction.init(cluster);<a name="line.276"></a>
-<span class="sourceLineNo">277</span> double cost = costFunction.cost();<a name="line.277"></a>
-<span class="sourceLineNo">278</span> assertEquals(0.0f, cost, 0.001);<a name="line.278"></a>
-<span class="sourceLineNo">279</span><a name="line.279"></a>
-<span class="sourceLineNo">280</span> // cluster region number is smaller than maxMoves=600<a name="line.280"></a>
-<span class="sourceLineNo">281</span> cluster.setNumRegions(200);<a name="line.281"></a>
-<span class="sourceLineNo">282</span> cluster.setNumMovedRegions(10);<a name="line.282"></a>
-<span class="sourceLineNo">283</span> cost = costFunction.cost();<a name="line.283"></a>
-<span class="sourceLineNo">284</span> assertEquals(0.05f, cost, 0.001);<a name="line.284"></a>
-<span class="sourceLineNo">285</span> cluster.setNumMovedRegions(100);<a name="line.285"></a>
-<span class="sourceLineNo">286</span> cost = costFunction.cost();<a name="line.286"></a>
-<span class="sourceLineNo">287</span> assertEquals(0.5f, cost, 0.001);<a name="line.287"></a>
-<span class="sourceLineNo">288</span> cluster.setNumMovedRegions(200);<a name="line.288"></a>
-<span class="sourceLineNo">289</span> cost = costFunction.cost();<a name="line.289"></a>
-<span class="sourceLineNo">290</span> assertEquals(1.0f, cost, 0.001);<a name="line.290"></a>
-<span class="sourceLineNo">291</span><a name="line.291"></a>
-<span class="sourceLineNo">292</span><a name="line.292"></a>
-<span class="sourceLineNo">293</span> // cluster region number is bigger than maxMoves=2500<a name="line.293"></a>
-<span class="sourceLineNo">294</span> cluster.setNumRegions(10000);<a name="line.294"></a>
-<span class="sourceLineNo">295</span> cluster.setNumMovedRegions(250);<a name="line.295"></a>
-<span class="sourceLineNo">296</span> cost = costFunction.cost();<a name="line.296"></a>
-<span class="sourceLineNo">297</span> assertEquals(0.1f, cost, 0.001);<a name="line.297"></a>
-<span class="sourceLineNo">298</span> cluster.setNumMovedRegions(1250);<a name="line.298"></a>
-<span class="sourceLineNo">299</span> cost = costFunction.cost();<a name="line.299"></a>
-<span class="sourceLineNo">300</span> assertEquals(0.5f, cost, 0.001);<a name="line.300"></a>
-<span class="sourceLineNo">301</span> cluster.setNumMovedRegions(2500);<a name="line.301"></a>
-<span class="sourceLineNo">302</span> cost = costFunction.cost();<a name="line.302"></a>
-<span class="sourceLineNo">303</span> assertEquals(1.0f, cost, 0.01);<a name="line.303"></a>
-<span class="sourceLineNo">304</span> }<a name="line.304"></a>
-<span class="sourceLineNo">305</span> }<a name="line.305"></a>
-<span class="sourceLineNo">306</span><a name="line.306"></a>
-<span class="sourceLineNo">307</span> @Test<a name="line.307"></a>
-<span class="sourceLineNo">308</span> public void testSkewCost() {<a name="line.308"></a>
-<span class="sourceLineNo">309</span> Configuration conf = HBaseConfiguration.create();<a name="line.309"></a>
-<span class="sourceLineNo">310</span> StochasticLoadBalancer.CostFunction<a name="line.310"></a>
-<span class="sourceLineNo">311</span> costFunction = new StochasticLoadBalancer.RegionCountSkewCostFunction(conf);<a name="line.311"></a>
-<span class="sourceLineNo">312</span> for (int[] mockCluster : clusterStateMocks) {<a name="line.312"></a>
-<span class="sourceLineNo">313</span> costFunction.init(mockCluster(mockCluster));<a name="line.313"></a>
-<span class="sourceLineNo">314</span> double cost = costFunction.cost();<a name="line.314"></a>
-<span class="sourceLineNo">315</span> assertTrue(cost >= 0);<a name="line.315"></a>
-<span class="sourceLineNo">316</span> assertTrue(cost <= 1.01);<a name="line.316"></a>
-<span class="sourceLineNo">317</span> }<a name="line.317"></a>
-<span class="sourceLineNo">318</span><a name="line.318"></a>
-<span class="sourceLineNo">319</span> costFunction.init(mockCluster(new int[]{0, 0, 0, 0, 1}));<a name="line.319"></a>
-<span class="sourceLineNo">320</span> assertEquals(0,costFunction.cost(), 0.01);<a name="line.320"></a>
-<span class="sourceLineNo">321</span> costFunction.init(mockCluster(new int[]{0, 0, 0, 1, 1}));<a name="line.321"></a>
-<span class="sourceLineNo">322</span> assertEquals(0, costFunction.cost(), 0.01);<a name="line.322"></a>
-<span class="sourceLineNo">323</span> costFunction.init(mockCluster(new int[]{0, 0, 1, 1, 1}));<a name="line.323"></a>
+<span class="sourceLineNo">225</span><a name="line.225"></a>
+<span class="sourceLineNo">226</span> String regionNameAsString = RegionInfo.getRegionNameAsString(Bytes.toBytes(REGION_KEY));<a name="line.226"></a>
+<span class="sourceLineNo">227</span> assertTrue(loadBalancer.loads.get(regionNameAsString) != null);<a name="line.227"></a>
+<span class="sourceLineNo">228</span> assertTrue(loadBalancer.loads.get(regionNameAsString).size() == 15);<a name="line.228"></a>
+<span class="sourceLineNo">229</span><a name="line.229"></a>
+<span class="sourceLineNo">230</span> Queue<BalancerRegionLoad> loads = loadBalancer.loads.get(regionNameAsString);<a name="line.230"></a>
+<span class="sourceLineNo">231</span> int i = 0;<a name="line.231"></a>
+<span class="sourceLineNo">232</span> while(loads.size() > 0) {<a name="line.232"></a>
+<span class="sourceLineNo">233</span> BalancerRegionLoad rl = loads.remove();<a name="line.233"></a>
+<span class="sourceLineNo">234</span> assertEquals(i + (numClusterStatusToAdd - 15), rl.getStorefileSizeMB());<a name="line.234"></a>
+<span class="sourceLineNo">235</span> i ++;<a name="line.235"></a>
+<span class="sourceLineNo">236</span> }<a name="line.236"></a>
+<span class="sourceLineNo">237</span> }<a name="line.237"></a>
+<span class="sourceLineNo">238</span><a name="line.238"></a>
+<span class="sourceLineNo">239</span> @Test<a name="line.239"></a>
+<span class="sourceLineNo">240</span> public void testNeedBalance() {<a name="line.240"></a>
+<span class="sourceLineNo">241</span> float minCost = conf.getFloat("hbase.master.balancer.stochastic.minCostNeedBalance", 0.05f);<a name="line.241"></a>
+<span class="sourceLineNo">242</span> conf.setFloat("hbase.master.balancer.stochastic.minCostNeedBalance", 1.0f);<a name="line.242"></a>
+<span class="sourceLineNo">243</span> loadBalancer.setConf(conf);<a name="line.243"></a>
+<span class="sourceLineNo">244</span> for (int[] mockCluster : clusterStateMocks) {<a name="line.244"></a>
+<span class="sourceLineNo">245</span> Map<ServerName, List<RegionInfo>> servers = mockClusterServers(mockCluster);<a name="line.245"></a>
+<span class="sourceLineNo">246</span> List<RegionPlan> plans = loadBalancer.balanceCluster(servers);<a name="line.246"></a>
+<span class="sourceLineNo">247</span> assertNull(plans);<a name="line.247"></a>
+<span class="sourceLineNo">248</span> }<a name="line.248"></a>
+<span class="sourceLineNo">249</span> // reset config<a name="line.249"></a>
+<span class="sourceLineNo">250</span> conf.setFloat("hbase.master.balancer.stochastic.minCostNeedBalance", minCost);<a name="line.250"></a>
+<span class="sourceLineNo">251</span> loadBalancer.setConf(conf);<a name="line.251"></a>
+<span class="sourceLineNo">252</span> }<a name="line.252"></a>
+<span class="sourceLineNo">253</span><a name="line.253"></a>
+<span class="sourceLineNo">254</span> @Test<a name="line.254"></a>
+<span class="sourceLineNo">255</span> public void testLocalityCost() throws Exception {<a name="line.255"></a>
+<span class="sourceLineNo">256</span> Configuration conf = HBaseConfiguration.create();<a name="line.256"></a>
+<span class="sourceLineNo">257</span> MockNoopMasterServices master = new MockNoopMasterServices();<a name="line.257"></a>
+<span class="sourceLineNo">258</span> StochasticLoadBalancer.CostFunction<a name="line.258"></a>
+<span class="sourceLineNo">259</span> costFunction = new ServerLocalityCostFunction(conf, master);<a name="line.259"></a>
+<span class="sourceLineNo">260</span><a name="line.260"></a>
+<span class="sourceLineNo">261</span> for (int test = 0; test < clusterRegionLocationMocks.length; test++) {<a name="line.261"></a>
+<span class="sourceLineNo">262</span> int[][] clusterRegionLocations = clusterRegionLocationMocks[test];<a name="line.262"></a>
+<span class="sourceLineNo">263</span> MockCluster cluster = new MockCluster(clusterRegionLocations);<a name="line.263"></a>
+<span class="sourceLineNo">264</span> costFunction.init(cluster);<a name="line.264"></a>
+<span class="sourceLineNo">265</span> double cost = costFunction.cost();<a name="line.265"></a>
+<span class="sourceLineNo">266</span> double expected = 1 - expectedLocalities[test];<a name="line.266"></a>
+<span class="sourceLineNo">267</span> assertEquals(expected, cost, 0.001);<a name="line.267"></a>
+<span class="sourceLineNo">268</span> }<a name="line.268"></a>
+<span class="sourceLineNo">269</span> }<a name="line.269"></a>
+<span class="sourceLineNo">270</span><a name="line.270"></a>
+<span class="sourceLineNo">271</span> @Test<a name="line.271"></a>
+<span class="sourceLineNo">272</span> public void testMoveCost() throws Exception {<a name="line.272"></a>
+<span class="sourceLineNo">273</span> Configuration conf = HBaseConfiguration.create();<a name="line.273"></a>
+<span class="sourceLineNo">274</span> StochasticLoadBalancer.CostFunction<a name="line.274"></a>
+<span class="sourceLineNo">275</span> costFunction = new StochasticLoadBalancer.MoveCostFunction(conf);<a name="line.275"></a>
+<span class="sourceLineNo">276</span> for (int[] mockCluster : clusterStateMocks) {<a name="line.276"></a>
+<span class="sourceLineNo">277</span> BaseLoadBalancer.Cluster cluster = mockCluster(mockCluster);<a name="line.277"></a>
+<span class="sourceLineNo">278</span> costFunction.init(cluster);<a name="line.278"></a>
+<span class="sourceLineNo">279</span> double cost = costFunction.cost();<a name="line.279"></a>
+<span class="sourceLineNo">280</span> assertEquals(0.0f, cost, 0.001);<a name="line.280"></a>
+<span class="sourceLineNo">281</span><a name="line.281"></a>
+<span class="sourceLineNo">282</span> // cluster region number is smaller than maxMoves=600<a name="line.282"></a>
+<span class="sourceLineNo">283</span> cluster.setNumRegions(200);<a name="line.283"></a>
+<span class="sourceLineNo">284</span> cluster.setNumMovedRegions(10);<a name="line.284"></a>
+<span class="sourceLineNo">285</span> cost = costFunction.cost();<a name="line.285"></a>
+<span class="sourceLineNo">286</span> assertEquals(0.05f, cost, 0.001);<a name="line.286"></a>
+<span class="sourceLineNo">287</span> cluster.setNumMovedRegions(100);<a name="line.287"></a>
+<span class="sourceLineNo">288</span> cost = costFunction.cost();<a name="line.288"></a>
+<span class="sourceLineNo">289</span> assertEquals(0.5f, cost, 0.001);<a name="line.289"></a>
+<span class="sourceLineNo">290</span> cluster.setNumMovedRegions(200);<a name="line.290"></a>
+<span class="sourceLineNo">291</span> cost = costFunction.cost();<a name="line.291"></a>
+<span class="sourceLineNo">292</span> assertEquals(1.0f, cost, 0.001);<a name="line.292"></a>
+<span class="sourceLineNo">293</span><a name="line.293"></a>
+<span class="sourceLineNo">294</span><a name="line.294"></a>
+<span class="sourceLineNo">295</span> // cluster region number is bigger than maxMoves=2500<a name="line.295"></a>
+<span class="sourceLineNo">296</span> cluster.setNumRegions(10000);<a name="line.296"></a>
+<span class="sourceLineNo">297</span> cluster.setNumMovedRegions(250);<a name="line.297"></a>
+<span class="sourceLineNo">298</span> cost = costFunction.cost();<a name="line.298"></a>
+<span class="sourceLineNo">299</span> assertEquals(0.1f, cost, 0.001);<a name="line.299"></a>
+<span class="sourceLineNo">300</span> cluster.setNumMovedRegions(1250);<a name="line.300"></a>
+<span class="sourceLineNo">301</span> cost = costFunction.cost();<a name="line.301"></a>
+<span class="sourceLineNo">302</span> assertEquals(0.5f, cost, 0.001);<a name="line.302"></a>
+<span class="sourceLineNo">303</span> cluster.setNumMovedRegions(2500);<a name="line.303"></a>
+<span class="sourceLineNo">304</span> cost = costFunction.cost();<a name="line.304"></a>
+<span class="sourceLineNo">305</span> assertEquals(1.0f, cost, 0.01);<a name="line.305"></a>
+<span class="sourceLineNo">306</span> }<a name="line.306"></a>
+<span class="sourceLineNo">307</span> }<a name="line.307"></a>
+<span class="sourceLineNo">308</span><a name="line.308"></a>
+<span class="sourceLineNo">309</span> @Test<a name="line.309"></a>
+<span class="sourceLineNo">310</span> public void testSkewCost() {<a name="line.310"></a>
+<span class="sourceLineNo">311</span> Configuration conf = HBaseConfiguration.create();<a name="line.311"></a>
+<span class="sourceLineNo">312</span> StochasticLoadBalancer.CostFunction<a name="line.312"></a>
+<span class="sourceLineNo">313</span> costFunction = new StochasticLoadBalancer.RegionCountSkewCostFunction(conf);<a name="line.313"></a>
+<span class="sourceLineNo">314</span> for (int[] mockCluster : clusterStateMocks) {<a name="line.314"></a>
+<span class="sourceLineNo">315</span> costFunction.init(mockCluster(mockCluster));<a name="line.315"></a>
+<span class="sourceLineNo">316</span> double cost = costFunction.cost();<a name="line.316"></a>
+<span class="sourceLineNo">317</span> assertTrue(cost >= 0);<a name="line.317"></a>
+<span class="sourceLineNo">318</span> assertTrue(cost <= 1.01);<a name="line.318"></a>
+<span class="sourceLineNo">319</span> }<a name="line.319"></a>
+<span class="sourceLineNo">320</span><a name="line.320"></a>
+<span class="sourceLineNo">321</span> costFunction.init(mockCluster(new int[]{0, 0, 0, 0, 1}));<a name="line.321"></a>
+<span class="sourceLineNo">322</span> assertEquals(0,costFunction.cost(), 0.01);<a name="line.322"></a>
+<span class="sourceLineNo">323</span> costFunction.init(mockCluster(new int[]{0, 0, 0, 1, 1}));<a name="line.323"></a>
<span class="sourceLineNo">324</span> assertEquals(0, costFunction.cost(), 0.01);<a name="line.324"></a>
-<span class="sourceLineNo">325</span> costFunction.init(mockCluster(new int[]{0, 1, 1, 1, 1}));<a name="line.325"></a>
+<span class="sourceLineNo">325</span> costFunction.init(mockCluster(new int[]{0, 0, 1, 1, 1}));<a name="line.325"></a>
<span class="sourceLineNo">326</span> assertEquals(0, costFunction.cost(), 0.01);<a name="line.326"></a>
-<span class="sourceLineNo">327</span> costFunction.init(mockCluster(new int[]{1, 1, 1, 1, 1}));<a name="line.327"></a>
+<span class="sourceLineNo">327</span> costFunction.init(mockCluster(new int[]{0, 1, 1, 1, 1}));<a name="line.327"></a>
<span class="sourceLineNo">328</span> assertEquals(0, costFunction.cost(), 0.01);<a name="line.328"></a>
-<span class="sourceLineNo">329</span> costFunction.init(mockCluster(new int[]{10000, 0, 0, 0, 0}));<a name="line.329"></a>
-<span class="sourceLineNo">330</span> assertEquals(1, costFunction.cost(), 0.01);<a name="line.330"></a>
-<span class="sourceLineNo">331</span> }<a name="line.331"></a>
-<span class="sourceLineNo">332</span><a name="line.332"></a>
-<span class="sourceLineNo">333</span> @Test<a name="line.333"></a>
-<span class="sourceLineNo">334</span> public void testCostAfterUndoAction() {<a name="line.334"></a>
-<span class="sourceLineNo">335</span> final int runs = 10;<a name="line.335"></a>
-<span class="sourceLineNo">336</span> loadBalancer.setConf(conf);<a name="line.336"></a>
-<span class="sourceLineNo">337</span> for (int[] mockCluster : clusterStateMocks) {<a name="line.337"></a>
-<span class="sourceLineNo">338</span> BaseLoadBalancer.Cluster cluster = mockCluster(mockCluster);<a name="line.338"></a>
-<span class="sourceLineNo">339</span> loadBalancer.initCosts(cluster);<a name="line.339"></a>
-<span class="sourceLineNo">340</span> for (int i = 0; i != runs; ++i) {<a name="line.340"></a>
-<span class="sourceLineNo">341</span> final double expectedCost = loadBalancer.computeCost(cluster, Double.MAX_VALUE);<a name="line.341"></a>
-<span class="sourceLineNo">342</span> Cluster.Action action = loadBalancer.nextAction(cluster);<a name="line.342"></a>
-<span class="sourceLineNo">343</span> cluster.doAction(action);<a name="line.343"></a>
-<span class="sourceLineNo">344</span> loadBalancer.updateCostsWithAction(cluster, action);<a name="line.344"></a>
-<span class="sourceLineNo">345</span> Cluster.Action undoAction = action.undoAction();<a name="line.345"></a>
-<span class="sourceLineNo">346</span> cluster.doAction(undoAction);<a name="line.346"></a>
-<span class="sourceLineNo">347</span> loadBalancer.updateCostsWithAction(cluster, undoAction);<a name="line.347"></a>
-<span class="sourceLineNo">348</span> final double actualCost = loadBalancer.computeCost(cluster, Double.MAX_VALUE);<a name="line.348"></a>
-<span class="sourceLineNo">349</span> assertEquals(expectedCost, actualCost, 0);<a name="line.349"></a>
-<span class="sourceLineNo">350</span> }<a name="line.350"></a>
-<span class="sourceLineNo">351</span> }<a name="line.351"></a>
-<span class="sourceLineNo">352</span> }<a name="line.352"></a>
-<span class="sourceLineNo">353</span><a name="line.353"></a>
-<span class="sourceLineNo">354</span> @Test<a name="line.354"></a>
-<span class="sourceLineNo">355</span> public void testTableSkewCost() {<a name="line.355"></a>
-<span class="sourceLineNo">356</span> Configuration conf = HBaseConfiguration.create();<a name="line.356"></a>
-<span class="sourceLineNo">357</span> StochasticLoadBalancer.CostFunction<a name="line.357"></a>
-<span class="sourceLineNo">358</span> costFunction = new StochasticLoadBalancer.TableSkewCostFunction(conf);<a name="line.358"></a>
-<span class="sourceLineNo">359</span> for (int[] mockCluster : clusterStateMocks) {<a name="line.359"></a>
-<span class="sourceLineNo">360</span> BaseLoadBalancer.Cluster cluster = mockCluster(mockCluster);<a name="line.360"></a>
-<span class="sourceLineNo">361</span> costFunction.init(cluster);<a name="line.361"></a>
-<span class="sourceLineNo">362</span> double cost = costFunction.cost();<a name="line.362"></a>
-<span class="sourceLineNo">363</span> assertTrue(cost >= 0);<a name="line.363"></a>
-<span class="sourceLineNo">364</span> assertTrue(cost <= 1.01);<a name="line.364"></a>
-<span class="sourceLineNo">365</span> }<a name="line.365"></a>
-<span class="sourceLineNo">366</span> }<a name="line.366"></a>
-<span class="sourceLineNo">367</span><a name="line.367"></a>
-<span class="sourceLineNo">368</span> @Test<a name="line.368"></a>
-<span class="sourceLineNo">369</span> public void testRegionLoadCost() {<a name="line.369"></a>
-<span class="sourceLineNo">370</span> List<BalancerRegionLoad> regionLoads = new ArrayList<>();<a name="line.370"></a>
-<span class="sourceLineNo">371</span> for (int i = 1; i < 5; i++) {<a name="line.371"></a>
-<span class="sourceLineNo">372</span> BalancerRegionLoad regionLoad = mock(BalancerRegionLoad.class);<a name="line.372"></a>
-<span class="sourceLineNo">373</span> when(regionLoad.getReadRequestsCount()).thenReturn(new Long(i));<a name="line.373"></a>
-<span class="sourceLineNo">374</span> when(regionLoad.getCpRequestsCount()).thenReturn(new Long(i));<a name="line.374"></a>
-<span class="sourceLineNo">375</span> when(regionLoad.getStorefileSizeMB()).thenReturn(i);<a name="line.375"></a>
-<span class="sourceLineNo">376</span> regionLoads.add(regionLoad);<a name="line.376"></a>
-<span class="sourceLineNo">377</span> }<a name="line.377"></a>
-<span class="sourceLineNo">378</span><a name="line.378"></a>
-<span class="sourceLineNo">379</span> Configuration conf = HBaseConfiguration.create();<a name="line.379"></a>
-<span class="sourceLineNo">380</span> StochasticLoadBalancer.ReadRequestCostFunction readCostFunction =<a name="line.380"></a>
-<span class="sourceLineNo">381</span> new StochasticLoadBalancer.ReadRequestCostFunction(conf);<a name="line.381"></a>
-<span class="sourceLineNo">382</span> double rateResult = readCostFunction.getRegionLoadCost(regionLoads);<a name="line.382"></a>
-<span class="sourceLineNo">383</span> // read requests are treated as a rate so the average rate here is simply 1<a name="line.383"></a>
-<span class="sourceLineNo">384</span> assertEquals(1, rateResult, 0.01);<a name="line.384"></a>
-<span class="sourceLineNo">385</span><a name="line.385"></a>
-<span class="sourceLineNo">386</span> StochasticLoadBalancer.CPRequestCostFunction cpCostFunction =<a name="line.386"></a>
-<span class="sourceLineNo">387</span> new StochasticLoadBalancer.CPRequestCostFunction(conf);<a name="line.387"></a>
-<span class="sourceLineNo">388</span> rateResult = cpCostFunction.getRegionLoadCost(regionLoads);<a name="line.388"></a>
-<span class="sourceLineNo">389</span> // coprocessor requests are treated as a rate so the average rate here is simply 1<a name="line.389"></a>
-<span class="sourceLineNo">390</span> assertEquals(1, rateResult, 0.01);<a name="line.390"></a>
-<span class="sourceLineNo">391</span><a name="line.391"></a>
-<span class="sourceLineNo">392</span> StochasticLoadBalancer.StoreFileCostFunction storeFileCostFunction =<a name="line.392"></a>
-<span class="sourceLineNo">393</span> new StochasticLoadBalancer.StoreFileCostFunction(conf);<a name="line.393"></a>
-<span class="sourceLineNo">394</span> double result = storeFileCostFunction.getRegionLoadCost(regionLoads);<a name="line.394"></a>
-<span class="sourceLineNo">395</span> // storefile size cost is simply an average of it's value over time<a name="line.395"></a>
-<span class="sourceLineNo">396</span> assertEquals(2.5, result, 0.01);<a name="line.396"></a>
-<span class="sourceLineNo">397</span> }<a name="line.397"></a>
-<span class="sourceLineNo">398</span><a name="line.398"></a>
-<span class="sourceLineNo">399</span> @Test<a name="line.399"></a>
-<span class="sourceLineNo">400</span> public void testCostFromArray() {<a name="line.400"></a>
-<span class="sourceLineNo">401</span> Configuration conf = HBaseConfiguration.create();<a name="line.401"></a>
-<span class="sourceLineNo">402</span> StochasticLoadBalancer.CostFromRegionLoadFunction<a name="line.402"></a>
-<span class="sourceLineNo">403</span> costFunction = new StochasticLoadBalancer.MemStoreSizeCostFunction(conf);<a name="line.403"></a>
-<span class="sourceLineNo">404</span> costFunction.init(mockCluster(new int[]{0, 0, 0, 0, 1}));<a name="line.404"></a>
-<span class="sourceLineNo">405</span><a name="line.405"></a>
-<span class="sourceLineNo">406</span> double[] statOne = new double[100];<a name="line.406"></a>
-<span class="sourceLineNo">407</span> for (int i =0; i < 100; i++) {<a name="line.407"></a>
-<span class="sourceLineNo">408</span> statOne[i] = 10;<a name="line.408"></a>
-<span class="sourceLineNo">409</span> }<a name="line.409"></a>
-<span class="sourceLineNo">410</span> assertEquals(0, costFunction.costFromArray(statOne), 0.01);<a name="line.410"></a>
-<span class="sourceLineNo">411</span><a name="line.411"></a>
-<span class="sourceLineNo">412</span> double[] statTwo= new double[101];<a name="line.412"></a>
-<span class="sourceLineNo">413</span> for (int i =0; i < 100; i++) {<a name="line.413"></a>
-<span class="sourceLineNo">414</span> statTwo[i] = 0;<a name="line.414"></a>
-<span class="sourceLineNo">415</span> }<a name="line.415"></a>
-<span class="sourceLineNo">416</span> statTwo[100] = 100;<a name="line.416"></a>
-<span class="sourceLineNo">417</span> assertEquals(1, costFunction.costFromArray(statTwo), 0.01);<a name="line.417"></a>
-<span class="sourceLineNo">418</span><a name="line.418"></a>
-<span class="sourceLineNo">419</span> double[] statThree = new double[200];<a name="line.419"></a>
-<span class="sourceLineNo">420</span> for (int i =0; i < 100; i++) {<a name="line.420"></a>
-<span class="sourceLineNo">421</span> statThree[i] = (0);<a name="line.421"></a>
-<span class="sourceLineNo">422</span> statThree[i+100] = 100;<a name="line.422"></a>
-<span class="sourceLineNo">423</span> }<a name="line.423"></a>
-<span class="sourceLineNo">424</span> assertEquals(0.5, costFunction.costFromArray(statThree), 0.01);<a name="line.424"></a>
-<span class="sourceLineNo">425</span> }<a name="line.425"></a>
-<span class="sourceLineNo">426</span><a name="line.426"></a>
-<span class="sourceLineNo">427</span> @Test<a name="line.427"></a>
-<span class="sourceLineNo">428</span> public void testLosingRs() throws Exception {<a name="line.428"></a>
-<span class="sourceLineNo">429</span> int numNodes = 3;<a name="line.429"></a>
-<span class="sourceLineNo">430</span> int numRegions = 20;<a name="line.430"></a>
-<span class="sourceLineNo">431</span> int numRegionsPerServer = 3; //all servers except one<a name="line.431"></a>
-<span class="sourceLineNo">432</span> int replication = 1;<a name="line.432"></a>
-<span class="sourceLineNo">433</span> int numTables = 2;<a name="line.433"></a>
-<span class="sourceLineNo">434</span><a name="line.434"></a>
-<span class="sourceLineNo">435</span> Map<ServerName, List<RegionInfo>> serverMap =<a name="line.435"></a>
-<span class="sourceLineNo">436</span> createServerMap(numNodes, numRegions, numRegionsPerServer, replication, numTables);<a name="line.436"></a>
-<span class="sourceLineNo">437</span> List<ServerAndLoad> list = convertToList(serverMap);<a name="line.437"></a>
-<span class="sourceLineNo">438</span><a name="line.438"></a>
-<span class="sourceLineNo">439</span><a name="line.439"></a>
-<span class="sourceLineNo">440</span> List<RegionPlan> plans = loadBalancer.balanceCluster(serverMap);<a name="line.440"></a>
-<span class="sourceLineNo">441</span> assertNotNull(plans);<a name="line.441"></a>
-<span class="sourceLineNo">442</span><a name="line.442"></a>
-<span class="sourceLineNo">443</span> // Apply the plan to the mock cluster.<a name="line.443"></a>
-<span class="sourceLineNo">444</span> List<ServerAndLoad> balancedCluster = reconcile(list, plans, serverMap);<a name="line.444"></a>
-<span class="sourceLineNo">445</span><a name="line.445"></a>
-<span class="sourceLineNo">446</span> assertClusterAsBalanced(balancedCluster);<a name="line.446"></a>
+<span class="sourceLineNo">329</span> costFunction.init(mockCluster(new int[]{1, 1, 1, 1, 1}));<a name="line.329"></a>
+<span class="sourceLineNo">330</span> assertEquals(0, costFunction.cost(), 0.01);<a name="line.330"></a>
+<span class="sourceLineNo">331</span> costFunction.init(mockCluster(new int[]{10000, 0, 0, 0, 0}));<a name="line.331"></a>
+<span class="sourceLineNo">332</span> assertEquals(1, costFunction.cost(), 0.01);<a name="line.332"></a>
+<span class="sourceLineNo">333</span> }<a name="line.333"></a>
+<span class="sourceLineNo">334</span><a name="line.334"></a>
+<span class="sourceLineNo">335</span> @Test<a name="line.335"></a>
+<span class="sourceLineNo">336</span> public void testCostAfterUndoAction() {<a name="line.336"></a>
+<span class="sourceLineNo">337</span> final int runs = 10;<a name="line.337"></a>
+<span class="sourceLineNo">338</span> loadBalancer.setConf(conf);<a name="line.338"></a>
+<span class="sourceLineNo">339</span> for (int[] mockCluster : clusterStateMocks) {<a name="line.339"></a>
+<span class="sourceLineNo">340</span> BaseLoadBalancer.Cluster cluster = mockCluster(mockCluster);<a name="line.340"></a>
+<span class="sourceLineNo">341</span> loadBalancer.initCosts(cluster);<a name="line.341"></a>
+<span class="sourceLineNo">342</span> for (int i = 0; i != runs; ++i) {<a name="line.342"></a>
+<span class="sourceLineNo">343</span> final double expectedCost = loadBalancer.computeCost(cluster, Double.MAX_VALUE);<a name="line.343"></a>
+<span class="sourceLineNo">344</span> Cluster.Action action = loadBalancer.nextAction(cluster);<a name="line.344"></a>
+<span class="sourceLineNo">345</span> cluster.doAction(action);<a name="line.345"></a>
+<span class="sourceLineNo">346</span> loadBalancer.updateCostsWithAction(cluster, action);<a name="line.346"></a>
+<span class="sourceLineNo">347</span> Cluster.Action undoAction = action.undoAction();<a name="line.347"></a>
+<span class="sourceLineNo">348</span> cluster.doAction(undoAction);<a name="line.348"></a>
+<span class="sourceLineNo">349</span> loadBalancer.updateCostsWithAction(cluster, undoAction);<a name="line.349"></a>
+<span class="sourceLineNo">350</span> final double actualCost = loadBalancer.computeCost(cluster, Double.MAX_VALUE);<a name="line.350"></a>
+<span class="sourceLineNo">351</span> assertEquals(expectedCost, actualCost, 0);<a name="line.351"></a>
+<span class="sourceLineNo">352</span> }<a name="line.352"></a>
+<span class="sourceLineNo">353</span> }<a name="line.353"></a>
+<span class="sourceLineNo">354</span> }<a name="line.354"></a>
+<span class="sourceLineNo">355</span><a name="line.355"></a>
+<span class="sourceLineNo">356</span> @Test<a name="line.356"></a>
+<span class="sourceLineNo">357</span> public void testTableSkewCost() {<a name="line.357"></a>
+<span class="sourceLineNo">358</span> Configuration conf = HBaseConfiguration.create();<a name="line.358"></a>
+<span class="sourceLineNo">359</span> StochasticLoadBalancer.CostFunction<a name="line.359"></a>
+<span class="sourceLineNo">360</span> costFunction = new StochasticLoadBalancer.TableSkewCostFunction(conf);<a name="line.360"></a>
+<span class="sourceLineNo">361</span> for (int[] mockCluster : clusterStateMocks) {<a name="line.361"></a>
+<span class="sourceLineNo">362</span> BaseLoadBalancer.Cluster cluster = mockCluster(mockCluster);<a name="line.362"></a>
+<span class="sourceLineNo">363</span> costFunction.init(cluster);<a name="line.363"></a>
+<span class="sourceLineNo">364</span> double cost = costFunction.cost();<a name="line.364"></a>
+<span class="sourceLineNo">365</span> assertTrue(cost >= 0);<a name="line.365"></a>
+<span class="sourceLineNo">366</span> assertTrue(cost <= 1.01);<a name="line.366"></a>
+<span class="sourceLineNo">367</span> }<a name="line.367"></a>
+<span class="sourceLineNo">368</span> }<a name="line.368"></a>
+<span class="sourceLineNo">369</span><a name="line.369"></a>
+<span class="sourceLineNo">370</span> @Test<a name="line.370"></a>
+<span class="sourceLineNo">371</span> public void testRegionLoadCost() {<a name="line.371"></a>
+<span class="sourceLineNo">372</span> List<BalancerRegionLoad> regionLoads = new ArrayList<>();<a name="line.372"></a>
+<span class="sourceLineNo">373</span> for (int i = 1; i < 5; i++) {<a name="line.373"></a>
+<span class="sourceLineNo">374</span> BalancerRegionLoad regionLoad = mock(BalancerRegionLoad.class);<a name="line.374"></a>
+<span class="sourceLineNo">375</span> when(regionLoad.getReadRequestsCount()).thenReturn(new Long(i));<a name="line.375"></a>
+<span class="sourceLineNo">376</span> when(regionLoad.getCpRequestsCount()).thenReturn(new Long(i));<a name="line.376"></a>
+<span class="sourceLineNo">377</span> when(regionLoad.getStorefileSizeMB()).thenReturn(i);<a name="line.377"></a>
+<span class="sourceLineNo">378</span> regionLoads.add(regionLoad);<a name="line.378"></a>
+<span class="sourceLineNo">379</span> }<a name="line.379"></a>
+<span class="sourceLineNo">380</span><a name="line.380"></a>
+<span class="sourceLineNo">381</span> Configuration conf = HBaseConfiguration.create();<a name="line.381"></a>
+<span class="sourceLineNo">382</span> StochasticLoadBalancer.ReadRequestCostFunction readCostFunction =<a name="line.382"></a>
+<span class="sourceLineNo">383</span> new StochasticLoadBalancer.ReadRequestCostFunction(conf);<a name="line.383"></a>
+<span class="sourceLineNo">384</span> double rateResult = readCostFunction.getRegionLoadCost(regionLoads);<a name="line.384"></a>
+<span class="sourceLineNo">385</span> // read requests are treated as a rate so the average rate here is simply 1<a name="line.385"></a>
+<span class="sourceLineNo">386</span> assertEquals(1, rateResult, 0.01);<a name="line.386"></a>
+<span class="sourceLineNo">387</span><a name="line.387"></a>
+<span class="sourceLineNo">388</span> StochasticLoadBalancer.CPRequestCostFunction cpCostFunction =<a name="line.388"></a>
+<span class="sourceLineNo">389</span> new StochasticLoadBalancer.CPRequestCostFunction(conf);<a name="line.389"></a>
+<span class="sourceLineNo">390</span> rateResult = cpCostFunction.getRegionLoadCost(regionLoads);<a name="line.390"></a>
+<span class="sourceLineNo">391</span> // coprocessor requests are treated as a rate so the average rate here is simply 1<a name="line.391"></a>
+<span class="sourceLineNo">392</span> assertEquals(1, rateResult, 0.01);<a name="line.392"></a>
+<span class="sourceLineNo">393</span><a name="line.393"></a>
+<span class="sourceLineNo">394</span> StochasticLoadBalancer.StoreFileCostFunction storeFileCostFunction =<a name="line.394"></a>
+<span class="sourceLineNo">395</span> new StochasticLoadBalancer.StoreFileCostFunction(conf);<a name="line.395"></a>
+<span class="sourceLineNo">396</span> double result = storeFileCostFunction.getRegionLoadCost(regionLoads);<a name="line.396"></a>
+<span class="sourceLineNo">397</span> // storefile size cost is simply an average of it's value over time<a name="line.397"></a>
+<span class="sourceLineNo">398</span> assertEquals(2.5, result, 0.01);<a name="line.398"></a>
+<span class="sourceLineNo">399</span> }<a name="line.399"></a>
+<span class="sourceLineNo">400</span><a name="line.400"></a>
+<span class="sourceLineNo">401</span> @Test<a name="line.401"></a>
+<span class="sourceLineNo">402</span> public void testCostFromArray() {<a name="line.402"></a>
+<span class="sourceLineNo">403</span> Configuration conf = HBaseConfiguration.create();<a name="line.403"></a>
+<span class="sourceLineNo">404</span> StochasticLoadBalancer.CostFromRegionLoadFunction<a name="line.404"></a>
+<span class="sourceLineNo">405</span> costFunction = new StochasticLoadBalancer.MemStoreSizeCostFunction(conf);<a name="line.405"></a>
+<span class="sourceLineNo">406</span> costFunction.init(mockCluster(new int[]{0, 0, 0, 0, 1}));<a name="line.406"></a>
+<span class="sourceLineNo">407</span><a name="line.407"></a>
+<span class="sourceLineNo">408</span> double[] statOne = new double[100];<a name="line.408"></a>
+<span class="sourceLineNo">409</span> for (int i =0; i < 100; i++) {<a name="line.409"></a>
+<span class="sourceLineNo">410</span> statOne[i] = 10;<a name="line.410"></a>
+<span class="sourceLineNo">411</span> }<a name="line.411"></a>
+<span class="sourceLineNo">412</span> assertEquals(0, costFunction.costFromArray(statOne), 0.01);<a name="line.412"></a>
+<span class="sourceLineNo">413</span><a name="line.413"></a>
+<span class="sourceLineNo">414</span> double[] statTwo= new double[101];<a name="line.414"></a>
+<span class="sourceLineNo">415</span> for (int i =0; i < 100; i++) {<a name="line.415"></a>
+<span class="sourceLineNo">416</span> statTwo[i] = 0;<a name="line.416"></a>
+<span class="sourceLineNo">417</span> }<a name="line.417"></a>
+<span class="sourceLineNo">418</span> statTwo[100] = 100;<a name="line.418"></a>
+<span class="sourceLineNo">419</span> assertEquals(1, costFunction.costFromArray(statTwo), 0.01);<a name="line.419"></a>
+<span class="sourceLineNo">420</span><a name="line.420"></a>
+<span class="sourceLineNo">421</span> double[] statThree = new double[200];<a name="line.421"></a>
+<span class="sourceLineNo">422</span> for (int i =0; i < 100; i++) {<a name="line.422"></a>
+<span class="sourceLineNo">423</span> statThree[i] = (0);<a name="line.423"></a>
+<span class="sourceLineNo">424</span> statThree[i+100] = 100;<a name="line.424"></a>
+<span class="sourceLineNo">425</span> }<a name="line.425"></a>
+<span class="sourceLineNo">426</span> assertEquals(0.5, costFunction.costFromArray(statThree), 0.01);<a name="line.426"></a>
+<span class="sourceLineNo">427</span> }<a name="line.427"></a>
+<span class="sourceLineNo">428</span><a name="line.428"></a>
+<span class="sourceLineNo">429</span> @Test<a name="line.429"></a>
+<span class="sourceLineNo">430</span> public void testLosingRs() throws Exception {<a name="line.430"></a>
+<span class="sourceLineNo">431</span> int numNodes = 3;<a name="line.431"></a>
+<span class="sourceLineNo">432</span> int numRegions = 20;<a name="line.432"></a>
+<span class="sourceLineNo">433</span> int numRegionsPerServer = 3; //all servers except one<a name="line.433"></a>
+<span class="sourceLineNo">434</span> int replication = 1;<a name="line.434"></a>
+<span class="sourceLineNo">435</span> int numTables = 2;<a name="line.435"></a>
+<span class="sourceLineNo">436</span><a name="line.436"></a>
+<span class="sourceLineNo">437</span> Map<ServerName, List<RegionInfo>> serverMap =<a name="line.437"></a>
+<span class="sourceLineNo">438</span> createServerMap(numNodes, numRegions, numRegionsPerServer, replication, numTables);<a name="line.438"></a>
+<span class="sourceLineNo">439</span> List<ServerAndLoad> list = convertToList(serverMap);<a name="line.439"></a>
+<span class="sourceLineNo">440</span><a name="line.440"></a>
+<span class="sourceLineNo">441</span><a name="line.441"></a>
+<span class="sourceLineNo">442</span> List<RegionPlan> plans = loadBalancer.balanceCluster(serverMap);<a name="line.442"></a>
+<span class="sourceLineNo">443</span> assertNotNull(plans);<a name="line.443"></a>
+<span class="sourceLineNo">444</span><a name="line.444"></a>
+<span class="sourceLineNo">445</span> // Apply the plan to the mock cluster.<a name="line.445"></a>
+<span class="sourceLineNo">446</span> List<ServerAndLoad> balancedCluster = reconcile(list, plans, serverMap);<a name="line.446"></a>
<span class="sourceLineNo">447</span><a name="line.447"></a>
-<span class="sourceLineNo">448</span> ServerName sn = serverMap.keySet().toArray(new ServerName[serverMap.size()])[0];<a name="line.448"></a>
+<span class="sourceLineNo">448</span> assertClusterAsBalanced(balancedCluster);<a name="line.448"></a>
<span class="sourceLineNo">449</span><a name="line.449"></a>
-<span class="sourceLineNo">450</span> ServerName deadSn = ServerName.valueOf(sn.getHostname(), sn.getPort(), sn.getStartcode() - 100);<a name="line.450"></a>
+<span class="sourceLineNo">450</span> ServerName sn = serverMap.keySet().toArray(new ServerName[serverMap.size()])[0];<a name="line.450"></a>
<span class="sourceLineNo">451</span><a name="line.451"></a>
-<span class="sourceLineNo">452</span> serverMap.put(deadSn, new ArrayList<>(0));<a name="line.452"></a>
+<span class="sourceLineNo">452</span> ServerName deadSn = ServerName.valueOf(sn.getHostname(), sn.getPort(), sn.getStartcode() - 100);<a name="line.452"></a>
<span class="sourceLineNo">453</span><a name="line.453"></a>
-<span class="sourceLineNo">454</span> plans = loadBalancer.balanceCluster(serverMap);<a name="line.454"></a>
-<span class="sourceLineNo">455</span> assertNull(plans);<a name="line.455"></a>
-<span class="sourceLineNo">456</span> }<a name="line.456"></a>
-<span class="sourceLineNo">457</span><a name="line.457"></a>
-<span class="sourceLineNo">458</span> // This mock allows us to test the LocalityCostFunction<a name="line.458"></a>
-<span class="sourceLineNo">459</span> private class MockCluster extends BaseLoadBalancer.Cluster {<a name="line.459"></a>
-<span class="sourceLineNo">460</span><a name="line.460"></a>
-<span class="sourceLineNo">461</span> private int[][] localities = null; // [region][server] = percent of blocks<a name="line.461"></a>
+<span class="sourceLineNo">454</span> serverMap.put(deadSn, new ArrayList<>(0));<a name="line.454"></a>
+<span class="sourceLineNo">455</span><a name="line.455"></a>
+<span class="sourceLineNo">456</span> plans = loadBalancer.balanceCluster(serverMap);<a name="line.456"></a>
+<span class="sourceLineNo">457</span> assertNull(plans);<a name="line.457"></a>
+<span class="sourceLineNo">458</span> }<a name="line.458"></a>
+<span class="sourceLineNo">459</span><a name="line.459"></a>
+<span class="sourceLineNo">460</span> // This mock allows us to test the LocalityCostFunction<a name="line.460"></a>
+<span class="sourceLineNo">461</span> private class MockCluster extends BaseLoadBalancer.Cluster {<a name="line.461"></a>
<span class="sourceLineNo">462</span><a name="line.462"></a>
-<span class="sourceLineNo">463</span> public MockCluster(int[][] regions) {<a name="line.463"></a>
+<span class="sourceLineNo">463</span> private int[][] localities = null; // [region][server] = percent of blocks<a name="line.463"></a>
<span class="sourceLineNo">464</span><a name="line.464"></a>
-<span class="sourceLineNo">465</span> // regions[0] is an array where index = serverIndex an value = number of regions<a name="line.465"></a>
-<span class="sourceLineNo">466</span> super(mockClusterServers(regions[0], 1), null, null, null);<a name="line.466"></a>
-<span class="sourceLineNo">467</span><a name="line.467"></a>
-<span class="sourceLineNo">468</span> localities = new int[regions.length - 1][];<a name="line.468"></a>
-<span class="sourceLineNo">469</span> for (int i = 1; i < regions.length; i++) {<a name="line.469"></a>
-<span class="sourceLineNo">470</span> int regionIndex = i - 1;<a name="line.470"></a>
-<span class="sourceLineNo">471</span> localities[regionIndex] = new int[regions[i].length - 1];<a name="line.471"></a>
-<span class="sourceLineNo">472</span> regionIndexToServerIndex[regionIndex] = regions[i][0];<a name="line.472"></a>
-<span class="sourceLineNo">473</span> for (int j = 1; j < regions[i].length; j++) {<a name="line.473"></a>
-<span class="sourceLineNo">474</span> int serverIndex = j - 1;<a name="line.474"></a>
-<span class="sourceLineNo">475</span> localities[regionIndex][serverIndex] = regions[i][j] > 100 ? regions[i][j] % 100 : regions[i][j];<a name="line.475"></a>
-<span class="sourceLineNo">476</span> }<a name="line.476"></a>
-<span class="sourceLineNo">477</span> }<a name="line.477"></a>
-<span class="sourceLineNo">478</span> }<a name="line.478"></a>
-<span class="sourceLineNo">479</span><a name="line.479"></a>
-<span class="sourceLineNo">480</span> @Override<a name="line.480"></a>
-<span class="sourceLineNo">481</span> float getLocalityOfRegion(int region, int server) {<a name="line.481"></a>
-<span class="sourceLineNo">482</span> // convert the locality percentage to a fraction<a name="line.482"></a>
-<span class="sourceLineNo">483</span> return localities[region][server] / 100.0f;<a name="line.483"></a>
-<span class="sourceLineNo">484</span> }<a name="line.484"></a>
-<span class="sourceLineNo">485</span><a name="line.485"></a>
-<span class="sourceLineNo">486</span> @Override<a name="line.486"></a>
-<span class="sourceLineNo">487</span> public int getRegionSizeMB(int region) {<a name="line.487"></a>
-<span class="sourceLineNo">488</span> return 1;<a name="line.488"></a>
-<span class="sourceLineNo">489</span> }<a name="line.489"></a>
-<span class="sourceLineNo">490</span> }<a name="line.490"></a>
-<span class="sourceLineNo">491</span>}<a name="line.491"></a>
+<span class="sourceLineNo">465</span> public MockCluster(int[][] regions) {<a name="line.465"></a>
+<span class="sourceLineNo">466</span><a name="line.466"></a>
+<span class="sourceLineNo">467</span> // regions[0] is an array where index = serverIndex an value = number of regions<a name="line.467"></a>
+<span class="sourceLineNo">468</span> super(mockClusterServers(regions[0], 1), null, null, null);<a name="line.468"></a>
+<span class="sourceLineNo">469</span><a name="line.469"></a>
+<span class="sourceLineNo">470</span> localities = new int[regions.length - 1][];<a name="line.470"></a>
+<span class="sourceLineNo">471</span> for (int i = 1; i < regions.length; i++) {<a name="line.471"></a>
+<span class="sourceLineNo">472</span> int regionIndex = i - 1;<a name="line.472"></a>
+<span class="sourceLineNo">473</span> localities[regionIndex] = new int[regions[i].length - 1];<a name="line.473"></a>
+<span class="sourceLineNo">474</span> regionIndexToServerIndex[regionIndex] = regions[i][0];<a name="line.474"></a>
+<span class="sourceLineNo">475</span> for (int j = 1; j < regions[i].length; j++) {<a name="line.475"></a>
+<span class="sourceLineNo">476</span> int serverIndex = j - 1;<a name="line.476"></a>
+<span class="sourceLineNo">477</span> localities[regionIndex][serverIndex] = regions[i][j] > 100 ? regions[i][j] % 100 : regions[i][j];<a name="line.477"></a>
+<span class="sourceLineNo">478</span> }<a name="line.478"></a>
+<span class="sourceLineNo">479</span> }<a name="line.479"></a>
+<span class="sourceLineNo">480</span> }<a name="line.480"></a>
+<span class="sourceLineNo">481</span><a name="line.481"></a>
+<span class="sourceLineNo">482</span> @Override<a name="line.482"></a>
+<span class="sourceLineNo">483</span> float getLocalityOfRegion(int region, int server) {<a name="line.483"></a>
+<span class="sourceLineNo">484</span> // convert the locality percentage to a fraction<a name="line.484"></a>
+<span class="sourceLineNo">485</span> return localities[region][server] / 100.0f;<a name="line.485"></a>
+<span class="sourceLineNo">486</span> }<a name="line.486"></a>
+<span class="sourceLineNo">487</span><a name="line.487"></a>
+<span class="sourceLineNo">488</span> @Override<a name="line.488"></a>
+<span class="sourceLineNo">489</span> public int getRegionSizeMB(int region) {<a name="line.489"></a>
+<span class="sourceLineNo">490</span> return 1;<a name="line.490"></a>
+<span class="sourceLineNo">491</span> }<a name="line.491"></a>
+<span class="sourceLineNo">492</span> }<a name="line.492"></a>
+<span class="sourceLineNo">493</span>}<a name="line.493"></a>