[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6583: Implement QueryOp class.

[GitBox <gi...@apache.org>]

mqliang commented on a change in pull request #6583:
URL: https://github.com/apache/incubator-pinot/pull/6583#discussion_r577853189



##########
File path: pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/CompatibilityOpsRunner.java
##########
@@ -52,6 +51,11 @@ private boolean runOps()
         System.out.println("Failure");
         break;
       }
+      /*
+       Brokers take time to update route table after a segment is created/uploaded/deleted, so sleep 1s between
+       two operations
+       */
+      TimeUnit.SECONDS.sleep(1);

Review comment:
       Both (1) and (2) need hardcode table name in code, which is not good in my opinion. Another idea is: in QueryOp.runOps() function, when test the first query, if the error message is "{errorCode: 410, message: "BrokerResourceMissingError"}", sleep and retry, until it succeeded or timeout.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org