You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Tomás Fernández Löbbe (Issue Comment Edited JIRA)" <ji...@apache.org> on 2012/04/04 20:55:19 UTC

[jira] [Issue Comment Edited] (SOLR-3033) "numberToKeep" on replication handler does not work with "backupAfter"

    [ https://issues.apache.org/jira/browse/SOLR-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246586#comment-13246586 ] 

Tomás Fernández Löbbe edited comment on SOLR-3033 at 4/4/12 6:54 PM:
---------------------------------------------------------------------

This fix is not working for me with this configuration:
{noformat}
  <requestHandler name="/replication" class="solr.ReplicationHandler">
    <lst name="master">
    	<str name="replicateAfter">commit</str>
        <str name="backupAfter">commit</str>
    </lst>
    <str name="maxNumberOfBackups">3</str>
  </requestHandler>
{noformat}

The backups are created as expected, but snapshots are never deleted. They do if I issue a request with "numberToKeep", but not automatically after a commit.
I'm attaching a test case.

My tests and the patch are for trunk.
                
      was (Author: tomasflobbe):
    This fix is not working for me with this configuration:
{noformat}
  <requestHandler name="/replication" class="solr.ReplicationHandler">
    <lst name="master">
    	<str name="replicateAfter">commit</str>
        <str name="backupAfter">commit</str>
    </lst>
    <str name="maxNumberOfBackups">3</str>
  </requestHandler>
{noformat}

The backups are created as expected, but snapshots are never deleted. They do if I issue a request with "numberToKeep", but not automatically after a commit.
I'm attaching a test case.
                  
> "numberToKeep" on replication handler does not work with "backupAfter"
> ----------------------------------------------------------------------
>
>                 Key: SOLR-3033
>                 URL: https://issues.apache.org/jira/browse/SOLR-3033
>             Project: Solr
>          Issue Type: Bug
>          Components: replication (java)
>    Affects Versions: 3.5
>         Environment: openjdk 1.6, linux 3.x
>            Reporter: Torsten Krah
>            Assignee: James Dyer
>             Fix For: 3.6
>
>         Attachments: SOLR-3033-failingtest.patch, SOLR-3033.patch, SOLR-3033.patch
>
>
> Configured my replication handler like this:
>    <requestHandler name="/replication" class="solr.ReplicationHandler" >
>        <lst name="master">
>        <str name="replicateAfter">startup</str>
>        <str name="replicateAfter">commit</str>
>        <str name="replicateAfter">optimize</str>
>        <str name="confFiles">elevate.xml,schema.xml,spellings.txt,stopwords.txt,stopwords_de.txt,stopwords_en.txt,synonyms_de.txt,synonyms.txt</str>
>        <str name="backupAfter">optimize</str>
>        <str name="numberToKeep">1</str>
>      </lst>
>    </requestHandler>
> So after optimize a snapshot should be taken, this works. But numberToKeep is ignored, snapshots are increasing with each call to optimize and are kept forever. Seems this settings have no effect.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org