You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/11/15 07:23:17 UTC
[GitHub] [iotdb] ericpai opened a new pull request #4384: [IOTDB-2008]Fix null result bug of peekNextNotNullValue
ericpai opened a new pull request #4384:
URL: https://github.com/apache/iotdb/pull/4384
See JIRA: https://issues.apache.org/jira/browse/IOTDB-2008
Because the `GroupByFillDataSet` has been refined totally, I don't know whether BUG1 described in JIRA has been fixed.
If so, I will open a new PR to fix it in rel/0.12 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 merged pull request #4384: [IOTDB-2008] Fix null result bug of GROUP BY FILL query
Posted by GitBox <gi...@apache.org>.
JackieTien97 merged pull request #4384:
URL: https://github.com/apache/iotdb/pull/4384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ericpai commented on pull request #4384: [IOTDB-2008] Fix null result bug of peekNextNotNullValue
Posted by GitBox <gi...@apache.org>.
ericpai commented on pull request #4384:
URL: https://github.com/apache/iotdb/pull/4384#issuecomment-968667592
This PR has fixed the following issues:
1. Add `ClusterGroupByFillNoVFilterDataSet` to handle GROUP BY FILL query in cluster mode. As the query with value filter is not supported yet, the implementation is left to furture developers. Please do not forget :)
2. Refining the constructor of `GroupByWithValueFilterDataSet` and its subclasses, by separating `initGroupBy` to an individual method which is needed to call explicitly. As in `initGroupBy`, we should init underlying readers of timeseries. In cluster mode, we must use a new parameter `MetaGroupMember` to init `readerFactory`, which passed in the constructor. However, the `ClusterGroupByFillNoVFilterDataSet` extends `GroupByWithValueFilterDataSet` and the `super()` call must be the first line in the constructor, and we have no opportunity to set `MetaGroupMember` as a class field.
3. Fix a null result issue which casing thrift execption thrown when calling peekNextNotNullValue().
@JackieTien97 @CRZbulabula Thanks for reviewing the codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org