You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by drigodwin <gi...@git.apache.org> on 2017/12/19 11:05:50 UTC
[GitHub] brooklyn-server pull request #919: Stop dynamiccluster.zone.enable inheritan...
GitHub user drigodwin opened a pull request:
https://github.com/apache/brooklyn-server/pull/919
Stop dynamiccluster.zone.enable inheritance
This is required so child clusters don't inherit this from their parent as it doesn't work.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/drigodwin/brooklyn-server dynamicclusterzoneenable-inheriance
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/919.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #919
----
commit c01dcaec894db583161a3482b094b195c0338e86
Author: Duncan Godwin <du...@cloudsoftcorp.com>
Date: 2017-12-19T11:03:44Z
Stop dynamiccluster.zone.enable inheritance
----
---
[GitHub] brooklyn-server issue #919: Stop dynamiccluster.zone.enable inheritance
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/919
I tested this with an app something like:
```
location:
multi:
targets:
- jclouds:aws-ec2:us-east-1a
- jclouds:aws-ec2:us-east-1b
services:
- type: org.apache.brooklyn.entity.group.DynamicCluster
brooklyn.config:
dynamiccluster.zone.enable: true
initialSize: 2
memberSpec:
$brooklyn:entitySpec:
type: org.apache.brooklyn.entity.group.DynamicCluster
brooklyn.config:
initialSize: 1
memberSpec:
$brooklyn:entitySpec:
type: server
```
It failed before this change, and works after this change.
---
[GitHub] brooklyn-server issue #919: Stop dynamiccluster.zone.enable inheritance
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/919
LGTM; would be nice to have a unit test as well, but change is trivial so happy to merge.
---
[GitHub] brooklyn-server pull request #919: Stop dynamiccluster.zone.enable inheritan...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/919
---