svn commit: r1481577 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

[da...@apache.org]

Author: danielsh
Date: Sun May 12 15:03:34 2013
New Revision: 1481577

URL: http://svn.apache.org/r1481577
Log:
Note a problem that svn.apache.org runs into occasionally.

* subversion/libsvn_fs_fs/fs_fs.c
  (svn_fs_fs__commit): Note a potential problem with the approach and suggest
    a general solution.

Modified:
    subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

Modified: subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c?rev=1481577&r1=1481576&r2=1481577&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c (original)
+++ subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c Sun May 12 15:03:34 2013
@@ -8658,6 +8658,9 @@ svn_fs_fs__commit(svn_revnum_t *new_rev_
        * We use an sqlite transaction to speed things up;
        * see <http://www.sqlite.org/faq.html#q19>.
        */
+      /* ### A commit that touches thousands of files will starve other
+             (reader/writer) commits for the duration of the below call.
+             Maybe write in batches? */
       SVN_SQLITE__WITH_TXN(
         write_reps_to_cache(fs, cb.reps_to_cache, pool),
         ffd->rep_cache_db);