You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Jonas <ba...@gmail.com> on 2013/05/06 11:10:44 UTC
Re: Warnings from RequestCycle.handleException(Exception)
I agree that this might be a useful default in some cases, but how about at
least using a
separate Logger instance for this, so we can get rid of
these warnings without silencing all of RequestCycle's logging?
Cheers,
Jonas
On Sat, Apr 27, 2013 at 11:12 PM, Igor Vaynberg <ig...@gmail.com>wrote:
> in many cases this exception will lead to the error page, so its not
> just debugging information. this is the case i would rather wicket be
> loud by default to help while developing and have interested parties
> silence the logger in production systems...
>
> -igor
>
> On Sat, Apr 27, 2013 at 11:43 AM, Martin Grigorov <mg...@apache.org>
> wrote:
> > ivaynberg: ping
> >
> >
> > On Fri, Apr 26, 2013 at 10:59 AM, Jonas <ba...@gmail.com> wrote:
> >
> >> Hi all,
> >>
> >> after having upgraded to wicket 6.7.0, we get a lot of warnings logged
> from
> >> RequestCycle.handleException(Exception). Can you please change the
> level of
> >> 'Handling the following exception' messages to debug, as those warnings
> get
> >> really annoying. Using level debug, an interested developer still has
> the
> >> option to see the messages if he's having trouble in that area (by
> >> configuring logging accordingly), while you don't nag all other
> developers.
> >> IMHO log level warn should only be used if it's known something rather
> bad
> >> is happening, which isn't the case here - this is really just debugging
> >> information.
> >>
> >> Thank you for considering this.
> >>
> >> Cheers,
> >> Jonas
> >>
> >
> >
> >
> > --
> > Martin Grigorov
> > Wicket Training & Consulting
> > http://jWeekend.com <http://jweekend.com/>
>
Re: Warnings from RequestCycle.handleException(Exception)
Posted by Martin Grigorov <mg...@apache.org>.
https://issues.apache.org/jira/browse/WICKET-5188
On Mon, May 13, 2013 at 9:10 AM, Martin Grigorov <mg...@apache.org>wrote:
> Hi,
>
> On Fri, May 10, 2013 at 10:57 AM, Jonas <ba...@gmail.com> wrote:
>
>> Do you want me to provide a patch?
>>
>
> Yes, please!
> Thank you!
>
>
>>
>> > I agree that this might be a useful default in some cases, but how about
>> > at
>> > > least using a
>> > > separate Logger instance for this, so we can get rid of
>> > > these warnings without silencing all of RequestCycle's logging?
>> > >
>> >
>> > I don't mind doing this change.
>> >
>> >
>>
>
>
>
> --
> Martin Grigorov
> Wicket Training & Consulting
> http://jWeekend.com <http://jweekend.com/>
>
--
Martin Grigorov
Wicket Training & Consulting
http://jWeekend.com <http://jweekend.com/>
Re: Warnings from RequestCycle.handleException(Exception)
Posted by Martin Grigorov <mg...@apache.org>.
Hi,
On Fri, May 10, 2013 at 10:57 AM, Jonas <ba...@gmail.com> wrote:
> Do you want me to provide a patch?
>
Yes, please!
Thank you!
>
> > I agree that this might be a useful default in some cases, but how about
> > at
> > > least using a
> > > separate Logger instance for this, so we can get rid of
> > > these warnings without silencing all of RequestCycle's logging?
> > >
> >
> > I don't mind doing this change.
> >
> >
>
--
Martin Grigorov
Wicket Training & Consulting
http://jWeekend.com <http://jweekend.com/>
Re: Warnings from RequestCycle.handleException(Exception)
Posted by Jonas <ba...@gmail.com>.
Do you want me to provide a patch?
> I agree that this might be a useful default in some cases, but how about
> at
> > least using a
> > separate Logger instance for this, so we can get rid of
> > these warnings without silencing all of RequestCycle's logging?
> >
>
> I don't mind doing this change.
>
>
Re: Warnings from RequestCycle.handleException(Exception)
Posted by Martin Grigorov <mg...@apache.org>.
On Mon, May 6, 2013 at 11:10 AM, Jonas <ba...@gmail.com> wrote:
> I agree that this might be a useful default in some cases, but how about at
> least using a
> separate Logger instance for this, so we can get rid of
> these warnings without silencing all of RequestCycle's logging?
>
I don't mind doing this change.
>
> Cheers,
> Jonas
>
>
> On Sat, Apr 27, 2013 at 11:12 PM, Igor Vaynberg <igor.vaynberg@gmail.com
> >wrote:
>
> > in many cases this exception will lead to the error page, so its not
> > just debugging information. this is the case i would rather wicket be
> > loud by default to help while developing and have interested parties
> > silence the logger in production systems...
>
The log is already wrapped in "if (Application.exists() &&
Application.get().usesDevelopmentConfig())" so it wont write anything in
production.
> >
> > -igor
> >
> > On Sat, Apr 27, 2013 at 11:43 AM, Martin Grigorov <mg...@apache.org>
> > wrote:
> > > ivaynberg: ping
> > >
> > >
> > > On Fri, Apr 26, 2013 at 10:59 AM, Jonas <ba...@gmail.com> wrote:
> > >
> > >> Hi all,
> > >>
> > >> after having upgraded to wicket 6.7.0, we get a lot of warnings logged
> > from
> > >> RequestCycle.handleException(Exception). Can you please change the
> > level of
> > >> 'Handling the following exception' messages to debug, as those
> warnings
> > get
> > >> really annoying. Using level debug, an interested developer still has
> > the
> > >> option to see the messages if he's having trouble in that area (by
> > >> configuring logging accordingly), while you don't nag all other
> > developers.
> > >> IMHO log level warn should only be used if it's known something rather
> > bad
> > >> is happening, which isn't the case here - this is really just
> debugging
> > >> information.
> > >>
> > >> Thank you for considering this.
> > >>
> > >> Cheers,
> > >> Jonas
> > >>
> > >
> > >
> > >
> > > --
> > > Martin Grigorov
> > > Wicket Training & Consulting
> > > http://jWeekend.com <http://jweekend.com/>
> >
>
--
Martin Grigorov
Wicket Training & Consulting
http://jWeekend.com <http://jweekend.com/>