You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "schoel-bis (via GitHub)" <gi...@apache.org> on 2025/07/10 09:38:52 UTC
[I] Superset package included twice in v5.0.0 lean image [superset]
schoel-bis opened a new issue, #34120:
URL: https://github.com/apache/superset/issues/34120
### Bug description
The superset package is included twice in the lean image, once at `/app/superset` and once at `/app/.venv/lib/python3.10/site-packages/superset`. They are almost identical, except that the former contains a lot of `__pycache__` entries that the latter does not have, and the latter does not contain any translation files at all:
```sh
docker run --rm --entrypoint=sh apache/superset:5.0.0 -c 'diff -r /app/.venv/lib/python3.10/site-packages/superset /app/superset'
```
I tried to run an image where the former directory is removed, and that seems to work fine:
```Dockerfile
FROM apache/superset:5.0.0
RUN rm -rf /app/superset
```
Note that the extra directory is ~75MB large, so I would say it is not exactly insignificant.
The cause appears to be in [lines 247ff. of the Dockerfile](https://github.com/apache/superset/blob/17c1a37afb3686f11414cdd7b98d9f238179e204/Dockerfile#L247), where the local superset module is instelled into the venv but then left where it is. Also note that in line 252 the python files inside `/app/superset` are all compiled, but that this happens after installation into the venv, so that should not have any practical effect on execution.
### Screenshots/recordings
_No response_
### Superset version
5.0.0
### Python version
3.10
### Node version
Not applicable
### Browser
Not applicable
### Additional context
_No response_
### Checklist
- [x] I have searched Superset docs and Slack and didn't find a solution to my problem.
- [x] I have searched the GitHub issue tracker and didn't find a similar bug report.
- [x] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Superset package included twice in v5.0.0 lean image [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #34120:
URL: https://github.com/apache/superset/issues/34120#issuecomment-4594663719
Closed by #34146.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Superset package included twice in v5.0.0 lean image [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on issue #34120:
URL: https://github.com/apache/superset/issues/34120#issuecomment-3066014251
Proposing a solution here -> https://github.com/apache/superset/pull/34146
Has tradeoffs, but overall addresses the issue, is simple, has few/minimal downsides and some good pros attached.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Superset package included twice in v5.0.0 lean image [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #34120: Superset package included twice in v5.0.0 lean image
URL: https://github.com/apache/superset/issues/34120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Superset package included twice in v5.0.0 lean image [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #34120:
URL: https://github.com/apache/superset/issues/34120#issuecomment-3056644338
I usually CC @mistercrunch on these docker image issues, so here I go again ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Superset package included twice in v5.0.0 lean image [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on issue #34120:
URL: https://github.com/apache/superset/issues/34120#issuecomment-3058902853
Good catch, we should definitely investigate and fix. Would love to get more people deep in there as it's hard to find cycles [and energy] to giving this the attention it deserves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org