[GitHub] [trafficcontrol] rob05c opened a new pull request #6618: Cleanup parent.config generation code

[GitBox <gi...@apache.org>]

rob05c opened a new pull request #6618:
URL: https://github.com/apache/trafficcontrol/pull/6618


   Various techdebt cleanup of parent.config generation, inherited from ancient transliterated Perl. 
   
   Generated config should be byte-for-byte identical with or without this PR.
   
   - combines "profileCache" and "originServers" into a single "serversWithParams" variable, since the params apply to and are only ever useful with their corresponding server
   - renames "profileCache" struct to "parentServerParams", which is what it is, profileCache is an incredibly unmeaningful name inherited from ancient Perl code
   - removes unused parentConfigDS symbols
   - removes cgServer struct and replaces usage with real Servers; also inherited from ancient Perl code
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Control Cache Config (T3C, formerly ORT)
   
   ## What is the best way to verify this PR?
   Run tests. Generate config, verify config is unchanged.
   
   ## If this is a bugfix, which Traffic Control versions contained the bug?
   Not a bug fix.
   
   
   ## PR submission checklist
   - ~[x] This PR has tests~ tests exist for all affected code <!-- If not, please delete this text and explain why this PR does not need tests. -->
   - ~[x] This PR has documentation~ no docs, no interface change <!-- If not, please delete this text and explain why this PR does not need documentation. -->
   - ~[x] This PR has a CHANGELOG.md entry~ no interface change, no behavioral change <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org