You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/12/22 20:37:26 UTC

[GitHub] [beam] KonradJanica commented on a change in pull request #16105: [BEAM-13328] [Playground] Add highlighting of the current example in the catalog

KonradJanica commented on a change in pull request #16105:
URL: https://github.com/apache/beam/pull/16105#discussion_r774164193



##########
File path: playground/frontend/lib/modules/examples/models/example_model.dart
##########
@@ -65,6 +65,13 @@ class ExampleModel with Comparable<ExampleModel> {
     this.outputs = outputs;
   }
 
+  @override
+  bool operator ==(Object other) =>
+      identical(this, other) || other is ExampleModel && path == other.path;

Review comment:
       Please add brackets around `other is ExampleModel && path == other.path`, otherwise the path check will always be done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org