You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/26 20:31:11 UTC

[GitHub] [apisix] tashiya-menuri opened a new pull request #2525: bugfux : fixes issue #2327

tashiya-menuri opened a new pull request #2525:
URL: https://github.com/apache/apisix/pull/2525


   ### What this PR does / why we need it:
   Fix for https://github.com/apache/apisix/issues/2327
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #2525: doc : fixes issue #2327

Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #2525:
URL: https://github.com/apache/apisix/pull/2525#discussion_r514645942



##########
File path: doc/grpc-proxy.md
##########
@@ -17,7 +17,7 @@
 #
 -->
 
-[中文](zh-cn/grpc-proxy.md)
+[Chinese](zh-cn/grpc-proxy.md)

Review comment:
       It would be better if you leave this unchanged.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] tashiya-menuri commented on pull request #2525: doc : fixes issue #2327

Posted by GitBox <gi...@apache.org>.
tashiya-menuri commented on pull request #2525:
URL: https://github.com/apache/apisix/pull/2525#issuecomment-718791077


   @moonming @spacewander @membphis Can you please check now?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on a change in pull request #2525: doc : fixes issue #2327

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2525:
URL: https://github.com/apache/apisix/pull/2525#discussion_r513187147



##########
File path: doc/README.md
##########
@@ -31,6 +31,7 @@ Reference Documentation
 * [Router radixtree](router-radixtree.md)
 * [Stand Alone Model](stand-alone.md): Supports to load route rules from local yaml file, it is more friendly such as under the kubernetes(k8s).
 * [Stream Proxy](stream-proxy.md)
+* [gRPC Proxy](grpc-proxy.md)

Review comment:
       Do we need to update the Chinese version?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] tashiya-menuri commented on a change in pull request #2525: doc : fixes issue #2327

Posted by GitBox <gi...@apache.org>.
tashiya-menuri commented on a change in pull request #2525:
URL: https://github.com/apache/apisix/pull/2525#discussion_r514302771



##########
File path: doc/README.md
##########
@@ -31,6 +31,7 @@ Reference Documentation
 * [Router radixtree](router-radixtree.md)
 * [Stand Alone Model](stand-alone.md): Supports to load route rules from local yaml file, it is more friendly such as under the kubernetes(k8s).
 * [Stream Proxy](stream-proxy.md)
+* [gRPC Proxy](grpc-proxy.md)

Review comment:
       Addressed this in latest commit.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org