You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/25 21:24:03 UTC
[GitHub] [incubator-superset] bkyryliuk commented on a change in pull
request #9370: Add visualization flow to the CTA queries
bkyryliuk commented on a change in pull request #9370: Add visualization flow to the CTA queries
URL: https://github.com/apache/incubator-superset/pull/9370#discussion_r398178814
##########
File path: superset/views/core.py
##########
@@ -1968,6 +1970,48 @@ def sync_druid_source(self):
return json_error_response(utils.error_msg_from_exception(e))
return Response(status=201)
+ @has_access
+ @expose("/sqllab_table_viz/", methods=["POST"])
Review comment:
RE: What happens if you try to create a table that already exists with a different schema?
- it return the found value.
Good suggestion with the name, renamed the endpoint.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org