[GitHub] [ignite-3] isapego commented on a change in pull request #524: IGNITE-15240 Thin client: Implement transactions

[GitBox <gi...@apache.org>]

isapego commented on a change in pull request #524:
URL: https://github.com/apache/ignite-3/pull/524#discussion_r774709902



##########
File path: modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/tx/ClientTransactionCommitRequest.java
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.client.handler.requests.tx;
+
+import java.util.concurrent.CompletableFuture;
+import org.apache.ignite.client.handler.ClientResourceRegistry;
+import org.apache.ignite.internal.client.proto.ClientMessageUnpacker;
+import org.apache.ignite.tx.Transaction;
+
+/**
+ * Client transaction commit request.
+ */
+public class ClientTransactionCommitRequest {
+    /**
+     * Processes the request.
+     *
+     * @param in        Unpacker.
+     * @param resources Resources.
+     * @return Future.
+     */
+    public static CompletableFuture<Void> process(ClientMessageUnpacker in, ClientResourceRegistry resources) {
+        long resourceId = in.unpackLong();
+
+        Transaction t = resources.remove(resourceId).get();

Review comment:
       Should we add null check here? We can get NPE if `resourceId` is not present if I understand it correctly.
   
   Also, what will be thrown id resource is not a transaction for some reason?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org