You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/06/14 12:15:39 UTC
[GitHub] [cloudstack] davidjumani opened a new pull request #5106: Fix test failures for Local storage and SG enabled zones
davidjumani opened a new pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106
### Description
This PR skips / fixes tests in Local storage and SG enabled zones
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-864823337
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-868261896
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-870572953
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-871092614
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-870572953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-869393686
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-871056877
<b>Trillian test result (tid-1157)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45119 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5106-t1157-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 86 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 332.11 | test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 308.89 | test_routers_network_ops.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-871902604
merging this based on approvals and smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-871085576
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-864823337
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-869420578
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-871095575
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-870573533
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti merged pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
sureshanaparti merged pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-869393944
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-871085770
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-868261732
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-868853097
<b>Trillian test result (tid-1097)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 53466 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5106-t1097-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Smoke tests completed. 82 look OK, 5 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_ping_in_cpvm_success | `Failure` | 14.41 | test_diagnostics.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 412.21 | test_internal_lb.py
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3612.30 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 28.81 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 3635.38 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 164.73 | test_kubernetes_clusters.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 322.20 | test_vpc_redundant.py
test_01_VPC_nics_after_destroy | `Failure` | 974.08 | test_vpc_router_nics.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-871642178
<b>Trillian test result (tid-1169)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47885 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5106-t1169-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 86 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 529.20 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 529.22 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 537.06 | test_vpc_redundant.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 301.62 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-867350701
@davidjumani is tests for basic run using advanced tags parameter while evoking nosetests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-864824326
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-870525540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-869412543
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-864844823
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-871095427
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#discussion_r654458125
##########
File path: test/integration/smoke/test_direct_download.py
##########
@@ -184,20 +184,28 @@ def setUpClass(cls):
cls.services["service_offerings"]["tiny"]
)
cls._cleanup.append(cls.service_offering)
- cls.network_offering = NetworkOffering.create(
- cls.apiclient,
- cls.services["l2-network_offering"],
- )
- cls.network_offering.update(cls.apiclient, state='Enabled')
- cls.services["network"]["networkoffering"] = cls.network_offering.id
- cls.l2_network = Network.create(
- cls.apiclient,
- cls.services["l2-network"],
- zoneid=cls.zone.id,
- networkofferingid=cls.network_offering.id
- )
- cls._cleanup.append(cls.l2_network)
- cls._cleanup.append(cls.network_offering)
+
+ if cls.zone.networktype == 'Basic' :
+ networks = Network.list(cls.apiclient)
+ if len(networks) == 0 :
+ self.skipTest("Skipping test since no network found in basic zone")
+ else :
+ cls.network = networks[0]
+ else :
+ cls.network_offering = NetworkOffering.create(
+ cls.apiclient,
+ cls.services["l2-network_offering"],
+ )
+ cls.network_offering.update(cls.apiclient, state='Enabled')
+ cls.services["network"]["networkoffering"] = cls.network_offering.id
+ cls.network = Network.create(
+ cls.apiclient,
+ cls.services["l2-network"],
+ zoneid=cls.zone.id,
+ networkofferingid=cls.network_offering.id
+ )
+ cls._cleanup.append(cls.network)
+ cls._cleanup.append(cls.network_offering)
Review comment:
these should be reversed and nearer to the respective creations
```suggestion
cls.network_offering = NetworkOffering.create(
cls.apiclient,
cls.services["l2-network_offering"],
)
cls._cleanup.append(cls.network_offering)
cls.network_offering.update(cls.apiclient, state='Enabled')
cls.services["network"]["networkoffering"] = cls.network_offering.id
cls.network = Network.create(
cls.apiclient,
cls.services["l2-network"],
zoneid=cls.zone.id,
networkofferingid=cls.network_offering.id
)
cls._cleanup.append(cls.network)
```
and also the tearDownClass should read:
```
@classmethod
def tearDownClass(cls):
super(TestDirectDownloadTemplates, cls).tearDownClass()
```
(could be a separate PR but I tend to touch no test files without these kind of changes)
##########
File path: test/integration/smoke/test_direct_download.py
##########
@@ -269,6 +277,21 @@ def createServiceOffering(self, name, type, tags):
tags=tags
)
+ def deployVM(self, offering) :
+ if self.zone.networktype == 'Basic' :
+ vm = VirtualMachine.create(
+ self.apiclient,
+ self.services["virtual_machine"],
+ serviceofferingid=offering.id
+ )
Review comment:
this should add
```suggestion
vm = VirtualMachine.create(
self.apiclient,
self.services["virtual_machine"],
serviceofferingid=offering.id
)
self.cleanup.append(vm)
```
and not outside the method.
Same for createServiceOffering
##########
File path: test/integration/smoke/test_direct_download.py
##########
@@ -269,6 +277,21 @@ def createServiceOffering(self, name, type, tags):
tags=tags
)
+ def deployVM(self, offering) :
+ if self.zone.networktype == 'Basic' :
+ vm = VirtualMachine.create(
+ self.apiclient,
+ self.services["virtual_machine"],
+ serviceofferingid=offering.id
+ )
+ else :
+ vm = VirtualMachine.create(
+ self.apiclient,
+ self.services["virtual_machine"],
+ serviceofferingid=offering.id,
+ networkids=self.network.id
+ )
Review comment:
```suggestion
)
self.cleanup.append(vm)
```
##########
File path: test/integration/smoke/test_direct_download.py
##########
@@ -184,20 +184,28 @@ def setUpClass(cls):
cls.services["service_offerings"]["tiny"]
)
cls._cleanup.append(cls.service_offering)
- cls.network_offering = NetworkOffering.create(
- cls.apiclient,
- cls.services["l2-network_offering"],
- )
- cls.network_offering.update(cls.apiclient, state='Enabled')
- cls.services["network"]["networkoffering"] = cls.network_offering.id
- cls.l2_network = Network.create(
- cls.apiclient,
- cls.services["l2-network"],
- zoneid=cls.zone.id,
- networkofferingid=cls.network_offering.id
- )
- cls._cleanup.append(cls.l2_network)
- cls._cleanup.append(cls.network_offering)
+
+ if cls.zone.networktype == 'Basic' :
+ networks = Network.list(cls.apiclient)
+ if len(networks) == 0 :
+ self.skipTest("Skipping test since no network found in basic zone")
+ else :
+ cls.network = networks[0]
+ else :
+ cls.network_offering = NetworkOffering.create(
+ cls.apiclient,
+ cls.services["l2-network_offering"],
+ )
+ cls.network_offering.update(cls.apiclient, state='Enabled')
+ cls.services["network"]["networkoffering"] = cls.network_offering.id
+ cls.network = Network.create(
+ cls.apiclient,
+ cls.services["l2-network"],
+ zoneid=cls.zone.id,
+ networkofferingid=cls.network_offering.id
+ )
+ cls._cleanup.append(cls.network)
+ cls._cleanup.append(cls.network_offering)
Review comment:
and btw
```
def tearDown(self):
super(TestDirectDownloadTemplates, swlf).tearDown()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-864824326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-870525540
<b>Trillian test result (tid-1129)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 101230 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5106-t1129-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_nic_adapter_type.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Smoke tests completed. 62 look OK, 25 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | test_accounts.py
test_DeleteDomain | `Error` | 0.78 | test_accounts.py
test_forceDeleteDomain | `Failure` | 0.79 | test_accounts.py
test_forceDeleteDomain | `Error` | 2.94 | test_accounts.py
ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 5.00 | test_accounts.py
ContextSuite context=TestDomainsServiceOfferings>:setup | `Error` | 1514.60 | test_domain_service_offerings.py
ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py
test_01_create_iso_with_checksum_sha1 | `Error` | 65.33 | test_iso.py
test_02_1_create_iso_with_checksum_sha256_negative | `Error` | 66.39 | test_iso.py
test_02_create_iso_with_checksum_sha256 | `Error` | 65.32 | test_iso.py
test_03_create_iso_with_checksum_md5 | `Error` | 65.31 | test_iso.py
test_04_create_iso_with_no_checksum | `Error` | 65.43 | test_iso.py
test_01_create_iso | `Failure` | 1510.62 | test_iso.py
ContextSuite context=TestISO>:setup | `Error` | 3022.42 | test_iso.py
ContextSuite context=TestAsyncJob>:setup | `Error` | 0.00 | test_async_job.py
ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py
test_list_clusters_metrics | `Error` | 1511.37 | test_metrics_api.py
test_list_vms_metrics | `Error` | 0.12 | test_metrics_api.py
ContextSuite context=TestDeployVMFromISO>:setup | `Error` | 0.00 | test_deploy_vm_iso.py
test_delete_account | `Error` | 1511.17 | test_network.py
test_delete_network_while_vm_on_it | `Error` | 0.07 | test_network.py
test_deploy_vm_l2network | `Error` | 0.04 | test_network.py
test_l2network_restart | `Error` | 1.11 | test_network.py
ContextSuite context=TestPortForwarding>:setup | `Error` | 3.31 | test_network.py
ContextSuite context=TestPublicIP>:setup | `Error` | 0.96 | test_network.py
test_reboot_router | `Error` | 0.04 | test_network.py
test_releaseIP | `Error` | 0.41 | test_network.py
ContextSuite context=TestRouterRules>:setup | `Error` | 0.45 | test_network.py
ContextSuite context=TestDeployVmWithVariedPlanners>:setup | `Error` | 0.00 | test_deploy_vms_with_varied_deploymentplanners.py
ContextSuite context=TestDeployVmWithUserData>:setup | `Error` | 0.00 | test_deploy_vm_with_userdata.py
ContextSuite context=TestAdapterTypeForNic>:setup | `Error` | 0.00 | test_nic_adapter_type.py
ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_06_deploy_invalid_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_version | `Error` | 60.87 | test_kubernetes_supported_versions.py
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
test_nic_secondaryip_add_remove | `Error` | 1511.27 | test_multipleips_per_nic.py
ContextSuite context=TestPortForwardingRules>:setup | `Error` | 0.00 | test_portforwardingrules.py
ContextSuite context=TestPrivateGwACL>:setup | `Error` | 0.00 | test_privategw_acl.py
ContextSuite context=TestProjectSuspendActivate>:setup | `Error` | 1517.97 | test_projects.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 304.32 | test_routers_network_ops.py
test_03_ssvm_internals | `Failure` | 3.18 | test_ssvm.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 440.40 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-867698130
@rhtyd No, basic zone tests are run using the basic tag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5106:
URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-869419927
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org