You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by ba...@apache.org on 2006/02/22 23:20:29 UTC

svn commit: r379943 - /james/server/trunk/src/java/org/apache/james/fetchmail/FetchMail.java

Author: bago
Date: Wed Feb 22 14:20:27 2006
New Revision: 379943

URL: http://svn.apache.org/viewcvs?rev=379943&view=rev
Log:
FetchMail was no longer working. It was throwing an NPE because of a missing "implements Serviceable" (JAMES-446).
The switch to ContainerUtils.service() created the problem (we were calling the specific method before, while ContainerUtils only call the service if the component implements the Serviceable interface)

Modified:
    james/server/trunk/src/java/org/apache/james/fetchmail/FetchMail.java

Modified: james/server/trunk/src/java/org/apache/james/fetchmail/FetchMail.java
URL: http://svn.apache.org/viewcvs/james/server/trunk/src/java/org/apache/james/fetchmail/FetchMail.java?rev=379943&r1=379942&r2=379943&view=diff
==============================================================================
--- james/server/trunk/src/java/org/apache/james/fetchmail/FetchMail.java (original)
+++ james/server/trunk/src/java/org/apache/james/fetchmail/FetchMail.java Wed Feb 22 14:20:27 2006
@@ -36,6 +36,7 @@
 import org.apache.avalon.framework.logger.AbstractLogEnabled;
 import org.apache.avalon.framework.service.ServiceException;
 import org.apache.avalon.framework.service.ServiceManager;
+import org.apache.avalon.framework.service.Serviceable;
 import org.apache.james.services.MailServer;
 import org.apache.james.services.UsersRepository;
 
@@ -68,7 +69,7 @@
  * <p>Creation Date: 24-May-03</p>
  * 
  */
-public class FetchMail extends AbstractLogEnabled implements Configurable, Target
+public class FetchMail extends AbstractLogEnabled implements Configurable, Target, Serviceable
 {
     /**
      * Key fields for DynamicAccounts.
@@ -465,7 +466,7 @@
                         accountsChild.getAttribute("recipient"),
                         accountsChild.getAttributeAsBoolean(
                             "ignorercpt-header"),
-                        accountsChild.getAttribute("customrcpt-header"),
+                        accountsChild.getAttribute("customrcpt-header",""),
                         getSession()));
                 continue;
             }



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org