You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/23 07:43:02 UTC

[GitHub] [pulsar] momo-jun opened a new pull request, #15709: [improve][doc] Add a limitation for key_shared subscription type

momo-jun opened a new pull request, #15709:
URL: https://github.com/apache/pulsar/pull/15709

   
   Fixes #15705 
   
   ### Modifications
   
   1. Add a limitation for the `key_shared` subscription type.
   2. Apply the new markdown syntax to more notes and tips.
   
   
   ### Documentation
   
   - [ ] `doc` 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #15709: [improve][doc] Add a limitation for key_shared subscription type

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on code in PR #15709:
URL: https://github.com/apache/pulsar/pull/15709#discussion_r981145806


##########
site2/docs/concepts-messaging.md:
##########
@@ -633,10 +641,14 @@ producer = client.create_producer(topic='my-topic', batching_type=pulsar.Batchin
 </Tabs>
 ````
 
-> **Limitations of Key_Shared type**  
-> When you use Key_Shared type, be aware that:
-> * You need to specify a key or orderingKey for messages.
-> * You cannot use cumulative acknowledgment with Key_Shared type.
+:::caution
+**Limitations of Key_Shared type** 
+
+When you use Key_Shared type, be aware that:
+  * You need to specify a key or orderingKey for messages.
+  * You cannot use cumulative acknowledgment with Key_Shared type.
+  * When the position of the newest message in a topic is `X`, a key-shared consumer that is newly attached to the same subscription and connected to the topic will **not** receive any messages until the position of the oldest unacknowledged message in this subscription is newer than or equal to `X`. 

Review Comment:
   ```suggestion
     * When the position of the newest message in a topic is `X`, a key-shared consumer that is newly attached to the same subscription and connected to the topic will **not** receive any messages until all the messages before `X` have been acknowledged. 
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #15709: [improve][doc] Add a limitation for key_shared subscription type

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15709:
URL: https://github.com/apache/pulsar/pull/15709#issuecomment-1134301588

   @momo-jun:Thanks for providing doc info!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #15709: [improve][doc] Add a limitation for key_shared subscription type

Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #15709:
URL: https://github.com/apache/pulsar/pull/15709


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15709: [improve][doc] Add a limitation for key_shared subscription type

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #15709:
URL: https://github.com/apache/pulsar/pull/15709#discussion_r880014617


##########
site2/docs/concepts-messaging.md:
##########
@@ -916,7 +937,9 @@ The other available approach to message deduplication is to ensure that each mes
 
 Message deduplication makes Pulsar an ideal messaging system to be used in conjunction with stream processing engines (SPEs) and other systems seeking to provide effectively-once processing semantics. Messaging systems that do not offer automatic message deduplication require the SPE or other system to guarantee deduplication, which means that strict message ordering comes at the cost of burdening the application with the responsibility of deduplication. With Pulsar, strict ordering guarantees come at no application-level cost.
 
-> You can find more in-depth information in [this post](https://www.splunk.com/en_us/blog/it/exactly-once-is-not-exactly-the-same.html).
+:::tip
+You can find more in-depth information in [this post](https://www.splunk.com/en_us/blog/it/exactly-once-is-not-exactly-the-same.html).

Review Comment:
   ```suggestion
   
   ```
   Suggest removing this. 
   To keep neutral and not to be challenged by ASF, we avoid adding blogs of commercial companies to the Pulsar documentation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #15709: [improve][doc] Add a limitation for key_shared subscription type

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #15709:
URL: https://github.com/apache/pulsar/pull/15709#discussion_r880115309


##########
site2/docs/concepts-messaging.md:
##########
@@ -916,7 +937,9 @@ The other available approach to message deduplication is to ensure that each mes
 
 Message deduplication makes Pulsar an ideal messaging system to be used in conjunction with stream processing engines (SPEs) and other systems seeking to provide effectively-once processing semantics. Messaging systems that do not offer automatic message deduplication require the SPE or other system to guarantee deduplication, which means that strict message ordering comes at the cost of burdening the application with the responsibility of deduplication. With Pulsar, strict ordering guarantees come at no application-level cost.
 
-> You can find more in-depth information in [this post](https://www.splunk.com/en_us/blog/it/exactly-once-is-not-exactly-the-same.html).
+:::tip
+You can find more in-depth information in [this post](https://www.splunk.com/en_us/blog/it/exactly-once-is-not-exactly-the-same.html).

Review Comment:
   OK. Removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on pull request #15709: [improve][doc] Add a limitation for key_shared subscription type

Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #15709:
URL: https://github.com/apache/pulsar/pull/15709#issuecomment-1260279350

   @codelipenghui thanks for your review.  I've incorporated your suggestion. Please take another look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on pull request #15709: [improve][doc] Add a limitation for key_shared subscription type

Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #15709:
URL: https://github.com/apache/pulsar/pull/15709#issuecomment-1149493308

   Hi @codelipenghui can you pls review this PR, and shall we apply this change to 2.10 or even more versions?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #15709: [improve][doc] Add a limitation for key_shared subscription type

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15709:
URL: https://github.com/apache/pulsar/pull/15709#issuecomment-1179460192

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on pull request #15709: [improve][doc] Add a limitation for key_shared subscription type

Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #15709:
URL: https://github.com/apache/pulsar/pull/15709#issuecomment-1134302905

   //cc @codelipenghui @Anonymitaet 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #15709: [improve][doc] Add a limitation for key_shared subscription type

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15709:
URL: https://github.com/apache/pulsar/pull/15709#issuecomment-1134301529

   @momo-jun:Thanks for your contribution. For this PR, do we need to update docs?
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org