You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2024/07/24 18:57:00 UTC
[jira] [Commented] (MGPG-130) Update sigstore extension to ".sigstore.json"
[ https://issues.apache.org/jira/browse/MGPG-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868456#comment-17868456 ]
ASF GitHub Bot commented on MGPG-130:
-------------------------------------
loosebazooka opened a new pull request, #109:
URL: https://github.com/apache/maven-gpg-plugin/pull/109
Sigstore uses ".sigstore.json" extension in all our plugins, ".sigstore" is no longer used
Following this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MGPG) filed for the change (usually
before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should
address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MGPG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MGPG-XXX`
with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the
first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull
request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the
developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file
an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
> Update sigstore extension to ".sigstore.json"
> ---------------------------------------------
>
> Key: MGPG-130
> URL: https://issues.apache.org/jira/browse/MGPG-130
> Project: Maven GPG Plugin
> Issue Type: Sub-task
> Affects Versions: 3.2.5
> Reporter: Appu Goundan
> Priority: Major
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Sigstore uses ".sigstore.json" extensions for all newer versions of the clients (maven, gradle, other languages).
> An update to [https://github.com/apache/maven-gpg-plugin/blob/master/src/main/java/org/apache/maven/plugins/gpg/FilesCollector.java#L44-L45] should be sufficient.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)