You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "starocean999 (via GitHub)" <gi...@apache.org> on 2025/10/11 06:51:15 UTC
[PR] [fix](nereids)ReorderJoin rule should not absorb mark join to multi join [doris]
starocean999 opened a new pull request, #56837:
URL: https://github.com/apache/doris/pull/56837
### What problem does this PR solve?
Issue Number: close (https://github.com/apache/doris/issues/56786)
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)ReorderJoin rule should not absorb mark join to multi join [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 merged PR #56837:
URL: https://github.com/apache/doris/pull/56837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)ReorderJoin rule should not absorb mark join to multi join [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56837:
URL: https://github.com/apache/doris/pull/56837#issuecomment-3393095603
# FE Regression Coverage Report
Increment line coverage ` 0.00% (0/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/56837_565ebc4912f5f3da3066a9c9f43108f8ff2b5a4b_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/56837_565ebc4912f5f3da3066a9c9f43108f8ff2b5a4b_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)ReorderJoin rule should not absorb mark join to multi join [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #56837:
URL: https://github.com/apache/doris/pull/56837#issuecomment-3392996031
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)ReorderJoin rule should not absorb mark join to multi join [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56837:
URL: https://github.com/apache/doris/pull/56837#issuecomment-3392995879
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)ReorderJoin rule should not absorb mark join to multi join [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56837:
URL: https://github.com/apache/doris/pull/56837#issuecomment-3393018236
<details>
<summary>TPC-DS: <b>Total hot run time: 190186 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 565ebc4912f5f3da3066a9c9f43108f8ff2b5a4b, data reload: false
query1 1074 454 409 409
query2 6589 1684 1713 1684
query3 6748 222 221 221
query4 26865 23822 23167 23167
query5 5270 646 467 467
query6 348 250 216 216
query7 4674 498 306 306
query8 308 266 264 264
query9 8673 2538 2516 2516
query10 525 348 283 283
query11 15686 15661 15664 15661
query12 199 129 123 123
query13 2432 578 430 430
query14 12414 9611 9657 9611
query15 228 218 190 190
query16 8100 718 569 569
query17 2717 822 626 626
query18 2130 442 362 362
query19 243 207 177 177
query20 148 136 135 135
query21 213 151 129 129
query22 4401 4467 4483 4467
query23 35011 33734 33182 33182
query24 8136 2437 2408 2408
query25 549 499 434 434
query26 1241 270 153 153
query27 2697 484 350 350
query28 4352 2170 2154 2154
query29 813 601 466 466
query30 295 219 196 196
query31 915 815 734 734
query32 79 67 68 67
query33 564 372 317 317
query34 805 845 525 525
query35 806 826 742 742
query36 965 1010 934 934
query37 119 107 83 83
query38 3579 3650 3510 3510
query39 1474 1427 1445 1427
query40 228 128 115 115
query41 60 65 58 58
query42 122 108 113 108
query43 491 505 472 472
query44 1335 829 827 827
query45 187 183 172 172
query46 830 995 636 636
query47 1733 1817 1733 1733
query48 414 431 311 311
query49 752 501 410 410
query50 628 698 405 405
query51 3859 3945 3804 3804
query52 110 110 102 102
query53 229 269 193 193
query54 594 585 515 515
query55 87 86 83 83
query56 312 327 293 293
query57 1180 1189 1121 1121
query58 282 273 285 273
query59 2513 2633 2550 2550
query60 345 357 320 320
query61 164 157 202 157
query62 806 733 669 669
query63 224 191 188 188
query64 4418 1170 812 812
query65 4066 3987 3945 3945
query66 1070 428 336 336
query67 15849 15282 15210 15210
query68 6810 932 598 598
query69 473 333 291 291
query70 1466 1293 1338 1293
query71 489 341 311 311
query72 5986 4945 5070 4945
query73 529 596 357 357
query74 9159 9156 8800 8800
query75 3716 3383 2910 2910
query76 3026 1145 738 738
query77 786 408 334 334
query78 9639 9521 8862 8862
query79 2015 872 596 596
query80 631 563 555 555
query81 490 262 231 231
query82 480 164 141 141
query83 280 273 246 246
query84 255 120 103 103
query85 898 459 419 419
query86 361 315 304 304
query87 3790 3830 3731 3731
query88 4038 2272 2233 2233
query89 403 321 295 295
query90 2045 222 214 214
query91 165 163 135 135
query92 87 69 66 66
query93 1832 978 644 644
query94 695 445 323 323
query95 402 318 315 315
query96 492 567 277 277
query97 2941 2978 2910 2910
query98 265 216 218 216
query99 1442 1445 1280 1280
Total cold run time: 281359 ms
Total hot run time: 190186 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)ReorderJoin rule should not absorb mark join to multi join [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56837:
URL: https://github.com/apache/doris/pull/56837#issuecomment-3393215452
# FE Regression Coverage Report
Increment line coverage ` 0.00% (0/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/56837_565ebc4912f5f3da3066a9c9f43108f8ff2b5a4b_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/56837_565ebc4912f5f3da3066a9c9f43108f8ff2b5a4b_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)ReorderJoin rule should not absorb mark join to multi join [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #56837:
URL: https://github.com/apache/doris/pull/56837#issuecomment-3395814571
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)ReorderJoin rule should not absorb mark join to multi join [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56837:
URL: https://github.com/apache/doris/pull/56837#issuecomment-3393021076
<details>
<summary>ClickBench: <b>Total hot run time: 31.04 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 565ebc4912f5f3da3066a9c9f43108f8ff2b5a4b, data reload: false
query1 0.06 0.05 0.05
query2 0.09 0.06 0.05
query3 0.26 0.09 0.08
query4 1.60 0.12 0.11
query5 0.30 0.27 0.28
query6 1.19 0.65 0.64
query7 0.03 0.03 0.03
query8 0.06 0.04 0.04
query9 0.63 0.52 0.52
query10 0.58 0.61 0.58
query11 0.17 0.11 0.11
query12 0.16 0.13 0.12
query13 0.64 0.61 0.62
query14 1.05 1.06 1.03
query15 0.86 0.86 0.87
query16 0.41 0.41 0.39
query17 1.05 1.05 1.03
query18 0.21 0.20 0.20
query19 1.92 1.91 1.85
query20 0.02 0.02 0.01
query21 15.42 0.96 0.57
query22 0.77 1.23 0.68
query23 14.91 1.41 0.61
query24 6.91 1.47 1.47
query25 0.47 0.18 0.11
query26 0.67 0.16 0.13
query27 0.07 0.05 0.05
query28 9.70 1.35 0.95
query29 12.55 3.95 3.27
query30 0.27 0.14 0.12
query31 2.83 0.59 0.38
query32 3.24 0.57 0.47
query33 3.18 3.05 3.07
query34 16.20 5.51 4.80
query35 4.92 4.96 4.92
query36 0.71 0.52 0.51
query37 0.10 0.08 0.08
query38 0.07 0.05 0.04
query39 0.04 0.03 0.02
query40 0.17 0.14 0.14
query41 0.09 0.03 0.04
query42 0.04 0.03 0.03
query43 0.04 0.03 0.04
Total cold run time: 104.66 s
Total hot run time: 31.04 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)ReorderJoin rule should not absorb mark join to multi join [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56837:
URL: https://github.com/apache/doris/pull/56837#issuecomment-3393212292
# FE Regression Coverage Report
Increment line coverage ` 0.00% (0/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/56837_565ebc4912f5f3da3066a9c9f43108f8ff2b5a4b_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/56837_565ebc4912f5f3da3066a9c9f43108f8ff2b5a4b_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)ReorderJoin rule should not absorb mark join to multi join [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #56837:
URL: https://github.com/apache/doris/pull/56837#issuecomment-3395814626
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org