You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by re...@apache.org on 2007/08/02 18:17:18 UTC

svn commit: r562165 - in /httpd/httpd/trunk/modules/ldap: util_ldap.c util_ldap_cache_mgr.c

Author: rederpj
Date: Thu Aug  2 09:17:17 2007
New Revision: 562165

URL: http://svn.apache.org/viewvc?view=rev&rev=562165
Log:
A couple of cleanups to the nested group code based on review comments.

Modified:
    httpd/httpd/trunk/modules/ldap/util_ldap.c
    httpd/httpd/trunk/modules/ldap/util_ldap_cache_mgr.c

Modified: httpd/httpd/trunk/modules/ldap/util_ldap.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ldap/util_ldap.c?view=diff&rev=562165&r1=562164&r2=562165
==============================================================================
--- httpd/httpd/trunk/modules/ldap/util_ldap.c (original)
+++ httpd/httpd/trunk/modules/ldap/util_ldap.c Thu Aug  2 09:17:17 2007
@@ -860,11 +860,7 @@
 }
 
 /*
- * Does a recursive lookup operation to try to find a user within (cached) nested
- * groups. It accepts a cache that it will use to lookup previous compare attempts.
- * We cache two kinds of compares (require group compares) and (require user
- * compares). Each compare has a different cache node: require group includes the DN;
- * require user does not because the require user cache is owned by the
+ * Does a recursive lookup operation to try to find a user within (cached) nested groups.
  *
  * DON'T CALL THIS UNLESS YOU CALLED uldap_cache_compare FIRST!!!!!
  */

Modified: httpd/httpd/trunk/modules/ldap/util_ldap_cache_mgr.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ldap/util_ldap_cache_mgr.c?view=diff&rev=562165&r1=562164&r2=562165
==============================================================================
--- httpd/httpd/trunk/modules/ldap/util_ldap_cache_mgr.c (original)
+++ httpd/httpd/trunk/modules/ldap/util_ldap_cache_mgr.c Thu Aug  2 09:17:17 2007
@@ -152,7 +152,6 @@
     sgl_out->len = sgl_in->len;
 
     for (i = 0; i < sgl_in->len; i++) {
-        fprintf(stderr, "sgl_dup: Adding %s to sgl\n", sgl_in->subgroupDNs[i]); fflush(stderr);
         sgl_out->subgroupDNs[i] = util_ald_strdup(cache, sgl_in->subgroupDNs[i]);
     }