[GitHub] [hudi] alexeykudinkin commented on a change in pull request #5165: [HUDI-3742] Enable parquet enableVectorizedReader for spark inc query to improve peformance

[GitBox <gi...@apache.org>]

alexeykudinkin commented on a change in pull request #5165:
URL: https://github.com/apache/hudi/pull/5165#discussion_r839794444



##########
File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/MergeOnReadIncrementalRelation.scala
##########
@@ -95,6 +108,9 @@ class MergeOnReadIncrementalRelation(sqlContext: SQLContext,
       hadoopConf = new Configuration(conf)
     )
 
+    // setUp tableRequiredSchema
+    tableRequiredSchema = requiredSchema.structTypeSchema

Review comment:
       Why do we need this one? Can we use `requiredSchema` directly?

##########
File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/MergeOnReadIncrementalRelation.scala
##########
@@ -59,6 +62,16 @@ class MergeOnReadIncrementalRelation(sqlContext: SQLContext,
     super.timeline.findInstantsInRange(startTimestamp, endTimestamp)
   }
 
+  override def buildScan(requiredColumns: Array[String], filters: Array[Filter]): RDD[Row] = {

Review comment:
       @xiarixiaoyao we don't need to override `buildScan` for that you can do the same thing w/in `composeRDD`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org