[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3118: ARTEMIS-2739 Artemis health check tool

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #3118:
URL: https://github.com/apache/activemq-artemis/pull/3118#discussion_r421553007



##########
File path: artemis-boot/src/main/java/org/apache/activemq/artemis/boot/Artemis.java
##########
@@ -46,7 +46,11 @@ public static void main(String[] args) throws Throwable {
 
       String instance = System.getProperty("artemis.instance");
       File fileInstance = instance != null ? new File(instance) : null;
-      execute(fileHome, fileInstance, args);
+
+      Object result = execute(fileHome, fileInstance, args);
+      if (result instanceof Exception) {

Review comment:
       this will silently fail the CLI. shouldn't you System.out about the exception here?
   
   In what situation this will return Exception? I coudln't see it 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org