You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mr-brobot (via GitHub)" <gi...@apache.org> on 2023/04/29 19:21:31 UTC
[GitHub] [arrow-datafusion] mr-brobot opened a new pull request, #6161: CLI: Add support for AWS named profiles
mr-brobot opened a new pull request, #6161:
URL: https://github.com/apache/arrow-datafusion/pull/6161
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #6157.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
See #6157.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
* Enabled `aws_profile` feature of object_store
* Upgrade to object_store 0.5.5 to include fix related to AWS profiles with static credentials
* Update CLI docs related to using `AWS_PROFILE` with S3 data sources
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
I didn't include any tests because this is a feature of a dependency that has it's own tests in the Arrow repo. Happy to add tests here if you think it necessary. :)
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
Yes, just another option for supplying AWS credentials. Docs updated.
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6161: CLI: Add support for AWS named profiles
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6161:
URL: https://github.com/apache/arrow-datafusion/pull/6161#issuecomment-1529894799
> I still would prefer aws_profile not be enabled by default, but if others feel strongly I'm not going to stand in the way of that
As I understood the issue is that AWS suggests to users to use that auth mode so it will be common for anyone trying to use datafusion-cli with AWS...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6161: CLI: Add support for AWS named profiles
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6161:
URL: https://github.com/apache/arrow-datafusion/pull/6161#issuecomment-1532104199
Thanks again for your help @mr-brobot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on pull request #6161: CLI: Add support for AWS named profiles
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #6161:
URL: https://github.com/apache/arrow-datafusion/pull/6161#issuecomment-1529079971
> However, the CLI already includes both GCP and AWS features from object_store by default,
Care has been taken upstream to ensure that the cloud provider features do not bring in any additional features beyond an HTTP client, see https://github.com/apache/arrow-rs/issues/2176. The aws_profile feature was added as an escape valve, but as [documented](https://docs.rs/object_store/latest/object_store/aws/struct.AmazonS3Builder.html#method.with_profile) it comes with some not insignificant drawbacks. Despite being the person to add this functionality to object_store, I would still encourage people to use a solution like [aws-vault](https://github.com/99designs/aws-vault), that doesn't store credentials in plain text on disk.
> I will add supporting Docker build args and related installation docs
That would be wonderful, although I am curious how profiles work with docker given they rely on a home directory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] mr-brobot commented on pull request #6161: CLI: Add support for AWS named profiles
Posted by "mr-brobot (via GitHub)" <gi...@apache.org>.
mr-brobot commented on PR #6161:
URL: https://github.com/apache/arrow-datafusion/pull/6161#issuecomment-1529174266
@tustvold Thank you for that explanation! `aws-vault` seems like the more secure approach, and I'll probably start using that personally. However, as you probably already know, as long as AWS docs/tools direct users to configure named profiles, AWS users (e.g., me) will bring their silly profile configs to the DataFusion CLI. 😓
> That would be wonderful, although I am curious how profiles work with docker given they rely on a home directory
We'll need to mount the host `.aws` directory and set the `AWS_PROFILE` env var in the `docker run` command. I'll implement the optional feature + Docker support later tonight/tomorrow. 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #6161: CLI: Add support for AWS named profiles
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6161:
URL: https://github.com/apache/arrow-datafusion/pull/6161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on pull request #6161: CLI: Add support for AWS named profiles
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #6161:
URL: https://github.com/apache/arrow-datafusion/pull/6161#issuecomment-1528895893
I wonder if we could make this a feature flag on datafusion-cli, disabled by default, it is a very heady feature (it brings in an entire AWS SDK) which I suspect not all users will want?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6161: CLI: Add support for AWS named profiles
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6161:
URL: https://github.com/apache/arrow-datafusion/pull/6161#issuecomment-1532104027
> Just want to make sure no one is waiting on me. At one point an optional cloud_object_store feature was proposed, but since then you both approved. If you'd like me to still implement that, just let me know!
I think we should just merge this one and I will do so over the next day or two if there are no other reviews
> Also, there are some failing checks but looks like a transient network error? 502 Gateway Error
Yeah, not sure what happened there - I restarted the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] mr-brobot commented on pull request #6161: CLI: Add support for AWS named profiles
Posted by "mr-brobot (via GitHub)" <gi...@apache.org>.
mr-brobot commented on PR #6161:
URL: https://github.com/apache/arrow-datafusion/pull/6161#issuecomment-1529074516
Thank you for the feedback, @tustvold and @alamb!
I agree that we should limit the CLI size, and this feature adds weight (+4 MB) that isn't always useful, especially for non-AWS users.
However, the CLI already includes both GCP and AWS features from object_store by default, and folks usually use one or the other (or neither for local files). If minimizing CLI size is a priority, it might make sense to add broader `aws` and `gcp` features allowing users to opt-in to cloud support, for only the cloud they need.
One implication is how users would opt-in to CLI features. No changes required for support in Cargo installation, and very simple to add Docker support via build args. However, I think package managers like Homebrew would only support the default features?
If we all decide on optional CLI features, I will add supporting Docker build args and related installation docs. 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] mr-brobot commented on pull request #6161: CLI: Add support for AWS named profiles
Posted by "mr-brobot (via GitHub)" <gi...@apache.org>.
mr-brobot commented on PR #6161:
URL: https://github.com/apache/arrow-datafusion/pull/6161#issuecomment-1531918801
@alamb @tustvold Thank you for the thoughtful review!
Just want to make sure no one is waiting on me. At one point an optional `cloud_object_store` feature was proposed, but since then you both approved. If you'd like me to still implement that, just let me know!
Also, there are some failing checks but looks like a transient network error? `502 Gateway Error`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on pull request #6161: CLI: Add support for AWS named profiles
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #6161:
URL: https://github.com/apache/arrow-datafusion/pull/6161#issuecomment-1529770528
I still would prefer aws_profile not be enabled by default, but if others feel strongly I'm not going to stand in the way of that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on pull request #6161: CLI: Add support for AWS named profiles
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #6161:
URL: https://github.com/apache/arrow-datafusion/pull/6161#issuecomment-1531458496
https://github.com/apache/arrow-rs/issues/4163 might longer-term be an alternative way to handle this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org