You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "YALI58 (via GitHub)" <gi...@apache.org> on 2026/08/13 22:35:54 UTC
Re: [PR] [ISSUE-39362] Fix from-x and to-y rejecting 0 as a valid position [shardingsphere]
YALI58 commented on PR #39389:
URL: https://github.com/apache/shardingsphere/pull/39389#issuecomment-5287170967
Hi @Terrymanu, I have added the requested regression tests:
1. `MaskAlgorithmPropertiesCheckerTest` — `checkNotNegativeInteger` tests for zero (accept), negative (reject), and non-integer (reject)
2. `MaskFromXToYMaskAlgorithmTest` — `assertMaskWithZeroFromX` with `from-x=0`, `to-y=2`
3. `KeepFromXToYMaskAlgorithmTest` — `assertMaskWithZeroFromX` with `from-x=0`, `to-y=2`
Please review again when you have time. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org