You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/05/20 06:12:52 UTC
[GitHub] jlahoda opened a new pull request #552: [NETBEANS-817] Preventing
exceptions when opening project:
jlahoda opened a new pull request #552: [NETBEANS-817] Preventing exceptions when opening project:
URL: https://github.com/apache/incubator-netbeans/pull/552
-accepting duplicate ClassPath entries with module-infos
-filtering out options that don't match the validated source level
Fixing two problems with the given project - with JDK 10 platform, the sources ClassPath in ModuleClassPaths.ModuleInfoClassPathImplementation has a duplicated entry, leading to having the module-info.java twice in the list of files to which the listener should be added, leading to the reported exception. Proposed fix is to use LinkedHashSet to avoid the duplication. Having duplicated entries in the CP may not be nice, but I suspect it is not reasonable to try to force a constraint that the entries must not be duplicated.
With platform <JDK 10/9, there are multiple problems, but the biggest one is that there are additional compiler options, like --add-reads (auto-injected to make tests work?), but the source level is downgraded below 9, where these options are not allowed and crash with an exception. The proposed (partial) fix is to filter the 9-specific options out when the validated source level < 9.
Any ideas/opinions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists