[GitHub] [pinot] snleee commented on a diff in pull request #10476: Remove "isSorted()" precondition check in the ForwardIndexHandler

["snleee (via GitHub)" <gi...@apache.org>]

snleee commented on code in PR #10476:
URL: https://github.com/apache/pinot/pull/10476#discussion_r1148194354


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java:
##########
@@ -302,8 +302,11 @@ Map<String, List<Operation>> computeOperations(SegmentDirectory.Reader segmentRe
         }
 
         // Note that RAW columns cannot be sorted.
+        // TODO: revisit the the possibility of converting noDictionary -> Dictionary when the column is sorted.
         ColumnMetadata existingColMetadata = _segmentDirectory.getSegmentMetadata().getColumnMetadataFor(column);
-        Preconditions.checkState(!existingColMetadata.isSorted(), "Raw column=" + column + " cannot be sorted.");
+        if (existingColMetadata.isSorted()) {

Review Comment:
   added!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org