You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Paul Lindner <pl...@linkedin.com> on 2010/04/14 03:45:59 UTC
caja 4052 patch
Here's my first crack at getting the latest caja working with shindig.
As noted on the caja list there's NPE in the CajaTreeBuilder that's causing
tests to fail.
Hope someone can take this and run with it, as I'm blocked...
Re: caja 4052 patch
Posted by John Hjelmstad <fa...@google.com>.
Thanks Paul --
I'll fold the diffs from your patch into mine and run with it, if that's all
right w/ you.
--j
2010/4/13 Paul Lindner <li...@inuus.com>
> uploaded at http://codereview.appspot.com/873046
>
> enjoy!
>
> 2010/4/13 John Hjelmstad <fa...@google.com>
>
> > Sounds pretty familiar. Did you attach the diff to your mail? I don't see
> > it
> > in my mail client is why I ask.
> >
> > 2010/4/13 Paul Lindner <li...@inuus.com>
> >
> > > I just sent out the diff, no codereview since It's not in any shape to
> > > submit. My changes amounted to:
> > >
> > > * Refactoring the UriCallback() in CajaContentRewriter to use
> > > PluginEnvironment
> > > * fixing some tests where the URL escaping was generating lowercase hex
> > > values
> > >
> > > Hope that helps..
> > >
> > >
> > > 2010/4/13 John Hjelmstad <fa...@google.com>
> > >
> > > > Hey Paul:
> > > >
> > > > I think I'm missing the patch -- is it on codereview.appspot.com?
> I've
> > > got
> > > > one as well:
> > > > http://codereview.appspot.com/846046/show
> > > >
> > > > I was working through details w/ Jasvir so hadn't yet sent it out to
> > the
> > > > list.
> > > >
> > > > It'd be interesting to see the difference between the two.
> > > >
> > > > --j
> > > >
> > > > 2010/4/13 Paul Lindner <pl...@linkedin.com>
> > > >
> > > > > Here's my first crack at getting the latest caja working with
> > shindig.
> > > > >
> > > > > As noted on the caja list there's NPE in the CajaTreeBuilder that's
> > > > causing
> > > > > tests to fail.
> > > > >
> > > > > Hope someone can take this and run with it, as I'm blocked...
> > > > >
> > > > >
> > > >
> > >
> >
>
Re: caja 4052 patch
Posted by Paul Lindner <li...@inuus.com>.
uploaded at http://codereview.appspot.com/873046
enjoy!
2010/4/13 John Hjelmstad <fa...@google.com>
> Sounds pretty familiar. Did you attach the diff to your mail? I don't see
> it
> in my mail client is why I ask.
>
> 2010/4/13 Paul Lindner <li...@inuus.com>
>
> > I just sent out the diff, no codereview since It's not in any shape to
> > submit. My changes amounted to:
> >
> > * Refactoring the UriCallback() in CajaContentRewriter to use
> > PluginEnvironment
> > * fixing some tests where the URL escaping was generating lowercase hex
> > values
> >
> > Hope that helps..
> >
> >
> > 2010/4/13 John Hjelmstad <fa...@google.com>
> >
> > > Hey Paul:
> > >
> > > I think I'm missing the patch -- is it on codereview.appspot.com? I've
> > got
> > > one as well:
> > > http://codereview.appspot.com/846046/show
> > >
> > > I was working through details w/ Jasvir so hadn't yet sent it out to
> the
> > > list.
> > >
> > > It'd be interesting to see the difference between the two.
> > >
> > > --j
> > >
> > > 2010/4/13 Paul Lindner <pl...@linkedin.com>
> > >
> > > > Here's my first crack at getting the latest caja working with
> shindig.
> > > >
> > > > As noted on the caja list there's NPE in the CajaTreeBuilder that's
> > > causing
> > > > tests to fail.
> > > >
> > > > Hope someone can take this and run with it, as I'm blocked...
> > > >
> > > >
> > >
> >
>
Re: caja 4052 patch
Posted by John Hjelmstad <fa...@google.com>.
Sounds pretty familiar. Did you attach the diff to your mail? I don't see it
in my mail client is why I ask.
2010/4/13 Paul Lindner <li...@inuus.com>
> I just sent out the diff, no codereview since It's not in any shape to
> submit. My changes amounted to:
>
> * Refactoring the UriCallback() in CajaContentRewriter to use
> PluginEnvironment
> * fixing some tests where the URL escaping was generating lowercase hex
> values
>
> Hope that helps..
>
>
> 2010/4/13 John Hjelmstad <fa...@google.com>
>
> > Hey Paul:
> >
> > I think I'm missing the patch -- is it on codereview.appspot.com? I've
> got
> > one as well:
> > http://codereview.appspot.com/846046/show
> >
> > I was working through details w/ Jasvir so hadn't yet sent it out to the
> > list.
> >
> > It'd be interesting to see the difference between the two.
> >
> > --j
> >
> > 2010/4/13 Paul Lindner <pl...@linkedin.com>
> >
> > > Here's my first crack at getting the latest caja working with shindig.
> > >
> > > As noted on the caja list there's NPE in the CajaTreeBuilder that's
> > causing
> > > tests to fail.
> > >
> > > Hope someone can take this and run with it, as I'm blocked...
> > >
> > >
> >
>
Re: caja 4052 patch
Posted by Paul Lindner <li...@inuus.com>.
I just sent out the diff, no codereview since It's not in any shape to
submit. My changes amounted to:
* Refactoring the UriCallback() in CajaContentRewriter to use
PluginEnvironment
* fixing some tests where the URL escaping was generating lowercase hex
values
Hope that helps..
2010/4/13 John Hjelmstad <fa...@google.com>
> Hey Paul:
>
> I think I'm missing the patch -- is it on codereview.appspot.com? I've got
> one as well:
> http://codereview.appspot.com/846046/show
>
> I was working through details w/ Jasvir so hadn't yet sent it out to the
> list.
>
> It'd be interesting to see the difference between the two.
>
> --j
>
> 2010/4/13 Paul Lindner <pl...@linkedin.com>
>
> > Here's my first crack at getting the latest caja working with shindig.
> >
> > As noted on the caja list there's NPE in the CajaTreeBuilder that's
> causing
> > tests to fail.
> >
> > Hope someone can take this and run with it, as I'm blocked...
> >
> >
>
Re: caja 4052 patch
Posted by John Hjelmstad <fa...@google.com>.
Hey Paul:
I think I'm missing the patch -- is it on codereview.appspot.com? I've got
one as well:
http://codereview.appspot.com/846046/show
I was working through details w/ Jasvir so hadn't yet sent it out to the
list.
It'd be interesting to see the difference between the two.
--j
2010/4/13 Paul Lindner <pl...@linkedin.com>
> Here's my first crack at getting the latest caja working with shindig.
>
> As noted on the caja list there's NPE in the CajaTreeBuilder that's causing
> tests to fail.
>
> Hope someone can take this and run with it, as I'm blocked...
>
>