You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "DamianPendrak (via GitHub)" <gi...@apache.org> on 2026/04/17 08:30:04 UTC

[PR] fix(deck.gl): scatterplot stops rendering points with empty value of categorical color [superset]

DamianPendrak opened a new pull request, #39430:
URL: https://github.com/apache/superset/pull/39430

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Include empty results for categorical color column in Scatterplot and Arc charts.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   Before
   <img width="1732" height="1038" alt="image" src="https://github.com/user-attachments/assets/c60c7d82-9014-4a6f-96cc-33a1c63c2d6f" />
   
   After
   <img width="2316" height="1361" alt="Screenshot 2026-04-17 at 09 14 00" src="https://github.com/user-attachments/assets/b5319d96-78e1-4a99-a606-37773f8098b8" />
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(deck.gl): scatterplot stops rendering points with empty value of categorical color [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39430:
URL: https://github.com/apache/superset/pull/39430#issuecomment-4266542578

   <!-- Bito Reply -->
   The flagged issue is correct. NULL_CATEGORY_KEY ('__NULL__') is mapped to 'N/A' only in the Legend component's formatCategoryLabel function, but Scatter and Arc tooltips display the raw cat_color value, showing '__NULL__' for null/undefined categories. This creates inconsistency.
   
   **superset-frontend/plugins/preset-chart-deckgl/src/utils.ts**
   ```
   export const NULL_CATEGORY_KEY = '__NULL__';
   
   export const formatCategoryLabel = (k: string) => {
     if (k === NULL_CATEGORY_KEY) {
       return t('N/A');
     }
     return k;
   };
   ```
   
   **superset-frontend/plugins/preset-chart-deckgl/src/components/Legend.tsx**
   ```
   import { NULL_CATEGORY_KEY, formatCategoryLabel } from '../utils';
   
   // Remove local formatCategoryLabel and use the imported one
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(deck.gl): scatterplot stops rendering points with empty value of categorical color [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #39430:
URL: https://github.com/apache/superset/pull/39430#discussion_r3098890659


##########
superset-frontend/plugins/preset-chart-deckgl/src/components/Legend.tsx:
##########
@@ -87,6 +89,10 @@ const Legend = ({
   };
 
   const formatCategoryLabel = (k: string) => {
+    if (k === NULL_CATEGORY_KEY) {
+      return t('N/A');
+    }

Review Comment:
   **🟠 Architect Review — HIGH**
   
   NULL_CATEGORY_KEY is mapped to the user-facing label "N/A" only when rendering the legend, while Scatter and Arc tooltips still display the raw cat_color value; for points with null/undefined category this results in "__NULL__" being shown on hover instead of "N/A", creating an inconsistent and implementation-leaking user experience.
   
   **Suggestion:** Centralize category label formatting (including NULL_CATEGORY_KEY → "N/A") and reuse it in the Scatter and Arc tooltip renderers (e.g., via tooltipUtils.CommonTooltipRows.category) so all user-facing category displays are consistent.
   
   
   [Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt=This%20is%20a%20comment%20left%20during%20a%20code%20review.%0A%0A%2A%2APath%3A%2A%2A%20superset-frontend%2Fplugins%2Fpreset-chart-deckgl%2Fsrc%2Fcomponents%2FLegend.tsx%0A%2A%2ALine%3A%2A%2A%2091%3A94%0A%2A%2AComment%3A%2A%2A%0A%09%2AHIGH%3A%20NULL_CATEGORY_KEY%20is%20mapped%20to%20the%20user-facing%20label%20%22N%2FA%22%20only%20when%20rendering%20the%20legend%2C%20while%20Scatter%20and%20Arc%20tooltips%20still%20display%20the%20raw%20cat_color%20value%3B%20for%20points%20with%20null%2Fundefined%20category%20this%20results%20in%20%22__NULL__%22%20being%20shown%20on%20hover%20instead%20of%20%22N%2FA%22%2C%20creating%20an%20inconsistent%20and%20implementation-leaking%20user%20experience.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0A) | [Fix in VSCode C
 laude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt=This%20is%20a%20comment%20left%20during%20a%20code%20review.%0A%0A%2A%2APath%3A%2A%2A%20superset-frontend%2Fplugins%2Fpreset-chart-deckgl%2Fsrc%2Fcomponents%2FLegend.tsx%0A%2A%2ALine%3A%2A%2A%2091%3A94%0A%2A%2AComment%3A%2A%2A%0A%09%2AHIGH%3A%20NULL_CATEGORY_KEY%20is%20mapped%20to%20the%20user-facing%20label%20%22N%2FA%22%20only%20when%20rendering%20the%20legend%2C%20while%20Scatter%20and%20Arc%20tooltips%20still%20display%20the%20raw%20cat_color%20value%3B%20for%20points%20with%20null%2Fundefined%20category%20this%20results%20in%20%22__NULL__%22%20being%20shown%20on%20hover%20instead%20of%20%22N%2FA%22%2C%20creating%20an%20inconsistent%20and%20implementation-leaking%20user%20experience.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0A)
   
   *(Use Cmd/Ctrl + Click for best experience)*
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset-frontend/plugins/preset-chart-deckgl/src/components/Legend.tsx
   **Line:** 91:94
   **Comment:**
   	*HIGH: NULL_CATEGORY_KEY is mapped to the user-facing label "N/A" only when rendering the legend, while Scatter and Arc tooltips still display the raw cat_color value; for points with null/undefined category this results in "__NULL__" being shown on hover instead of "N/A", creating an inconsistent and implementation-leaking user experience.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   ```
   </details>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(deck.gl): scatterplot stops rendering points with empty value of categorical color [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #39430: fix(deck.gl): scatterplot stops rendering points with empty value of categorical color
URL: https://github.com/apache/superset/pull/39430


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(deck.gl): scatterplot stops rendering points with empty value of categorical color [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39430:
URL: https://github.com/apache/superset/pull/39430#issuecomment-5044728420

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers a full AI review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(deck.gl): scatterplot stops rendering points with empty value of categorical color [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39430:
URL: https://github.com/apache/superset/pull/39430#issuecomment-4266508636

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(deck.gl): scatterplot stops rendering points with empty value of categorical color [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #39430:
URL: https://github.com/apache/superset/pull/39430#issuecomment-5040329752

   This looks like a good fix and the bug's confirmed. Mind rebasing it so we can get CI clean and move it along? Happy to help there if you'd like.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(deck.gl): scatterplot stops rendering points with empty value of categorical color [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #39430:
URL: https://github.com/apache/superset/pull/39430#issuecomment-4266598454

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/39430?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 64.53%. Comparing base ([`db7a2bd`](https://app.codecov.io/gh/apache/superset/commit/db7a2bd682255e390784218424b868f40bafd2b3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4098659`](https://app.codecov.io/gh/apache/superset/commit/4098659922009676ebb0eda75292c01a2c0f4e81?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #39430      +/-   ##
   ==========================================
   + Coverage   64.49%   64.53%   +0.03%     
   ==========================================
     Files        2557     2557              
     Lines      133097   133104       +7     
     Branches    30910    30915       +5     
   ==========================================
   + Hits        85846    85903      +57     
   + Misses      45761    45711      -50     
     Partials     1490     1490              
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/39430/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [javascript](https://app.codecov.io/gh/apache/superset/pull/39430/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.41% <100.00%> (+0.07%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/39430?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org