You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/07/26 15:58:52 UTC

[GitHub] [hudi] xushiyan commented on a diff in pull request #5250: [HUDI-3817] shade parquet dependency for hudi-hadoop-mr-bundle

xushiyan commented on code in PR #5250:
URL: https://github.com/apache/hudi/pull/5250#discussion_r930144788


##########
packaging/hudi-hadoop-mr-bundle/pom.xml:
##########
@@ -67,8 +67,9 @@
                 <includes>
                   <include>org.apache.hudi:hudi-common</include>
                   <include>org.apache.hudi:hudi-hadoop-mr</include>
-
+                  <!-- Parquet -->
                   <include>org.apache.parquet:parquet-avro</include>
+                  <include>org.apache.parquet:parquet-hadoop-bundle</include>

Review Comment:
   @RexXiong if we enforce parquet-avro version using a different variable say `hive.parquet.version` to always `1.10.x`, and shade it in hadoop-mr-bundle, this should be ok ?  Would parquet-avro 1.10.x work with parquet-hadoop 1.8.1 ? if so, we don't have to create hive profiles.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org