You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/03/12 16:11:23 UTC

[GitHub] [geode] jhutchison opened a new pull request #6127: GEODE-8864:finish implementation of Redis HScan Command (#5954)

jhutchison opened a new pull request #6127:
URL: https://github.com/apache/geode/pull/6127


    -add test for hscan not returning value removed from hash
    -refactor some tests to better reflect use cases
    -create HScan DunitTest
    -Fix Concurrency issue for Hscan
    -add UUID to client
    -make hscan on redisHash store/retrieve  snapshot of entryset for each client
    -add Unit tests for Redishash.HscanSnapshot
   
   Authored-by: john Hutchison <hu...@vmware.com>
   (cherry picked from commit b2b31cec3301d976ef8fd4d647e5cffd5d11f176)
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] sabbey37 merged pull request #6127: GEODE-8864:finish implementation of Redis HScan Command (#5954)

Posted by GitBox <gi...@apache.org>.
sabbey37 merged pull request #6127:
URL: https://github.com/apache/geode/pull/6127


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] sabbey37 commented on pull request #6127: GEODE-8864:finish implementation of Redis HScan Command (#5954)

Posted by GitBox <gi...@apache.org>.
sabbey37 commented on pull request #6127:
URL: https://github.com/apache/geode/pull/6127#issuecomment-797732651


   Failures in CI are unrelated to PR, merging backport.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] jhutchison commented on pull request #6127: GEODE-8864:finish implementation of Redis HScan Command (#5954)

Posted by GitBox <gi...@apache.org>.
jhutchison commented on pull request #6127:
URL: https://github.com/apache/geode/pull/6127#issuecomment-797594211


   this pr is a new version of https://github.com/apache/geode/pull/6120, which was just closed


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org