[jira] [Created] (HTTPCLIENT-1433) DefaultClientConnectionOperator instance check inconsistent with explicit cast

["jason mathews (JIRA)" <ji...@apache.org>]

jason mathews created HTTPCLIENT-1433:
-----------------------------------------

             Summary: DefaultClientConnectionOperator instance check inconsistent with explicit cast
                 Key: HTTPCLIENT-1433
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1433
             Project: HttpComponents HttpClient
          Issue Type: Bug
          Components: HttpClient
    Affects Versions: 4.3.1
         Environment: exists in all platforms.
            Reporter: jason mathews


Class checks for LayeredConnectionSocketFactory instance then casts to SchemeLayeredSocketFactory at line 214.

Assertion check needs to be for SchemeLayeredSocketFactory not  LayeredConnectionSocketFactory in DefaultClientConnectionOperator.updateSecureConnection().

package org.apache.http.impl.conn;
class DefaultClientConnectionOperator
  updateSecureConnection()  {
...
// line 214
        Asserts.check(schm.getSchemeSocketFactory() instanceof LayeredConnectionSocketFactory,
            "Socket factory must implement SchemeLayeredSocketFactory");
        final SchemeLayeredSocketFactory lsf = (SchemeLayeredSocketFactory) schm.getSchemeSocketFactory();
  }



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org