You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/08/17 12:03:57 UTC

[GitHub] [doris] dataroaring commented on a diff in pull request #11862: [enhancement](VSlotRef) enhance column_id check in execute function during runtime

dataroaring commented on code in PR #11862:
URL: https://github.com/apache/doris/pull/11862#discussion_r947845866


##########
be/src/vec/exprs/varray_literal.cpp:
##########
@@ -28,7 +28,10 @@ Status VArrayLiteral::prepare(RuntimeState* state, const RowDescriptor& row_desc
     Field array = is_null ? Field() : Array();
     for (const auto child : _children) {
         Field item;
-        child->get_const_col(context)->column_ptr->get(0, item);
+        auto col_ptr = child->get_const_col(context);
+        if (nullptr != col_ptr) {
+            col_ptr->column_ptr->get(0, item);
+        }
         array.get<Array>().push_back(item);

Review Comment:
   It seems that this change should be included in this pr?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org