You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/12/08 16:50:34 UTC
Review Request 64456: Increased wait time for specific task updates.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64456/
-----------------------------------------------------------
Review request for mesos and Benno Evers.
Bugs: MESOS-8316
https://issues.apache.org/jira/browse/MESOS-8316
Repository: mesos
Description
-------
If a test launches a task that requires internet access, for example,
to download docker images, an initial status update might take some
time to arrive. To avoid flaky tests, we compensate for this by
increasing the wait timeout via `AWAIT_READY_FOR`. However, with the
introduction of `TASK_STARTING`, the first received message is not
`TASK_RUNNING` any more, hence we should use `AWAIT_READY_FOR` for
`TASK_STARTING` updates as well.
Diffs
-----
src/tests/containerizer/cgroups_isolator_tests.cpp 54404ee2a8e99128f57a95e56c7f2cb5dd37dbad
src/tests/containerizer/cni_isolator_tests.cpp a6b660de63f767ff0ddc34791540de1427206e92
src/tests/containerizer/docker_containerizer_tests.cpp 1f6ff52daf9687621d42173b7bbf20b6b04e8ab9
src/tests/containerizer/memory_pressure_tests.cpp 9ada46d39f4cb4529298e0e9d2496ccd0522b3c6
src/tests/containerizer/nested_mesos_containerizer_tests.cpp bb2abbc09e8a560830fb9da5c5da8e0bd80c6bc5
src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 5e40a940770cb45c9ac181b953a4e57e4b053445
src/tests/containerizer/provisioner_appc_tests.cpp fc1335c0d432e83c1d13a408aca79bd61ac49701
src/tests/containerizer/provisioner_docker_tests.cpp 2fe8950ad41d0018045c9581d5eb1757f40dec20
src/tests/containerizer/runtime_isolator_tests.cpp 089605d9b0708cb35c171bad2c141c70336c07bd
src/tests/default_executor_tests.cpp d3e3ef770656a36f3469f2ec655102a05adcae8a
src/tests/health_check_tests.cpp c716ad9fa41fe9429de971bb2a1f2e790499572a
Diff: https://reviews.apache.org/r/64456/diff/1/
Testing
-------
make check on Mac OS 10.11.6 and various Linux distributions.
Thanks,
Alexander Rukletsov
Re: Review Request 64456: Increased wait time for specific task
updates.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64456/#review193263
-----------------------------------------------------------
Ship it!
Looks good, but please amend the commit message to explain why you opted to keep the long wait time for both status updates.
- Benno Evers
On Dec. 8, 2017, 4:50 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64456/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 4:50 p.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Bugs: MESOS-8316
> https://issues.apache.org/jira/browse/MESOS-8316
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If a test launches a task that requires internet access, for example,
> to download docker images, an initial status update might take some
> time to arrive. To avoid flaky tests, we compensate for this by
> increasing the wait timeout via `AWAIT_READY_FOR`. However, with the
> introduction of `TASK_STARTING`, the first received message is not
> `TASK_RUNNING` any more, hence we should use `AWAIT_READY_FOR` for
> `TASK_STARTING` updates as well.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_isolator_tests.cpp 54404ee2a8e99128f57a95e56c7f2cb5dd37dbad
> src/tests/containerizer/cni_isolator_tests.cpp a6b660de63f767ff0ddc34791540de1427206e92
> src/tests/containerizer/docker_containerizer_tests.cpp 1f6ff52daf9687621d42173b7bbf20b6b04e8ab9
> src/tests/containerizer/memory_pressure_tests.cpp 9ada46d39f4cb4529298e0e9d2496ccd0522b3c6
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp bb2abbc09e8a560830fb9da5c5da8e0bd80c6bc5
> src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 5e40a940770cb45c9ac181b953a4e57e4b053445
> src/tests/containerizer/provisioner_appc_tests.cpp fc1335c0d432e83c1d13a408aca79bd61ac49701
> src/tests/containerizer/provisioner_docker_tests.cpp 2fe8950ad41d0018045c9581d5eb1757f40dec20
> src/tests/containerizer/runtime_isolator_tests.cpp 089605d9b0708cb35c171bad2c141c70336c07bd
> src/tests/default_executor_tests.cpp d3e3ef770656a36f3469f2ec655102a05adcae8a
> src/tests/health_check_tests.cpp c716ad9fa41fe9429de971bb2a1f2e790499572a
>
>
> Diff: https://reviews.apache.org/r/64456/diff/1/
>
>
> Testing
> -------
>
> make check on Mac OS 10.11.6 and various Linux distributions.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 64456: Increased wait time for specific task
updates.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64456/#review193299
-----------------------------------------------------------
FAIL: Some Mesos libprocess-tests failed.
Failed command: `C:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\libprocess-tests.exe`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64456
Relevant logs:
- [libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64456/logs/libprocess-tests-stdout.log):
```
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp(440): error: Failed to wait 15secs for socket
[ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0, where GetParam() = "false" (16734 ms)
[ RUN ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp(440): error: Failed to wait 15secs for socket
[ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1, where GetParam() = "true" (16373 ms)
[----------] 4 tests from SSLVerifyIPAdd/SSLTest (34689 ms total)
[----------] Global test environment tear-down
[==========] 223 tests from 35 test cases ran. (263392 ms total)
[ PASSED ] 209 tests.
[ FAILED ] 14 tests, listed below:
[ FAILED ] SSLTest.SSLSocket
[ FAILED ] SSLTest.NonSSLSocket
[ FAILED ] SSLTest.NoVerifyBadCA
[ FAILED ] SSLTest.RequireBadCA
[ FAILED ] SSLTest.VerifyBadCA
[ FAILED ] SSLTest.VerifyCertificate
[ FAILED ] SSLTest.ProtocolMismatch
[ FAILED ] SSLTest.ECDHESupport
[ FAILED ] SSLTest.ValidDowngrade
[ FAILED ] SSLTest.NoValidDowngrade
[ FAILED ] SSLTest.ValidDowngradeEachProtocol
[ FAILED ] SSLTest.NoValidDowngradeEachProtocol
[ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0, where GetParam() = "false"
[ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1, where GetParam() = "true"
14 FAILED TESTS
YOU HAVE 19 DISABLED TESTS
```
- [libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64456/logs/libprocess-tests-stderr.log):
```
I1209 00:40:56.540791 3648 process.cpp:887] Failed to accept socket: future discarded
I1209 00:40:56.723402 9168 process.cpp:887] Failed to accept socket: future discarded
I1209 00:40:57.456493 1108 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1209 00:40:57.456493 1108 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1209 00:40:57.456493 1108 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\sbWZMp\cert.pem
I1209 00:40:57.457489 1108 openssl.cpp:566] Using CA dir: C:\Users\mesos\AppData\Local\Temp\sbWZMp
I1209 00:40:58.297538 1108 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1209 00:40:58.298539 1108 openssl.cpp:526] Will use IP address verification in subject alternative name certificate extension.
I1209 00:40:58.298539 1108 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1209 00:40:58.308539 1108 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\YTLhEL\cert.pem
I1209 00:40:58.308539 1108 openssl.cpp:566] Using CA dir: C:\Users\mesos\AppData\Local\Temp\YTLhEL
I1209 00:40:59.039995 1108 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I1209 00:40:59.040062 1108 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1209 00:40:59.040062 1108 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1209 00:40:59.040062 1108 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\QpBIkG\cert.pem
I1209 00:41:15.481557 1108 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I1209 00:41:15.481557 1108 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1209 00:41:15.481557 1108 openssl.cpp:526] Will use IP address verification in subject alternative name certificate extension.
I1209 00:41:15.481557 1108 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1209 00:41:15.482558 1108 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\cCdf7y\cert.pem
I1209 00:41:31.599421 9148 process.cpp:887] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Dec. 8, 2017, 5:40 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64456/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 5:40 p.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Bugs: MESOS-8316
> https://issues.apache.org/jira/browse/MESOS-8316
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If a test launches a task that requires internet access, for example,
> to download docker images, an initial status update might take some
> time to arrive. To avoid flaky tests, we compensate for this by
> increasing the wait timeout via `AWAIT_READY_FOR`. However, with the
> introduction of `TASK_STARTING`, the first received message is not
> `TASK_RUNNING` any more, hence we should use `AWAIT_READY_FOR` for
> `TASK_STARTING` updates as well. Since an image can be downloaded for
> either executor, or task, or both, we keep extended timeouts for both
> status updates.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_isolator_tests.cpp 54404ee2a8e99128f57a95e56c7f2cb5dd37dbad
> src/tests/containerizer/cni_isolator_tests.cpp a6b660de63f767ff0ddc34791540de1427206e92
> src/tests/containerizer/docker_containerizer_tests.cpp 1f6ff52daf9687621d42173b7bbf20b6b04e8ab9
> src/tests/containerizer/memory_pressure_tests.cpp 9ada46d39f4cb4529298e0e9d2496ccd0522b3c6
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp bb2abbc09e8a560830fb9da5c5da8e0bd80c6bc5
> src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 5e40a940770cb45c9ac181b953a4e57e4b053445
> src/tests/containerizer/provisioner_appc_tests.cpp fc1335c0d432e83c1d13a408aca79bd61ac49701
> src/tests/containerizer/provisioner_docker_tests.cpp 2fe8950ad41d0018045c9581d5eb1757f40dec20
> src/tests/containerizer/runtime_isolator_tests.cpp 089605d9b0708cb35c171bad2c141c70336c07bd
> src/tests/default_executor_tests.cpp d3e3ef770656a36f3469f2ec655102a05adcae8a
> src/tests/health_check_tests.cpp c716ad9fa41fe9429de971bb2a1f2e790499572a
>
>
> Diff: https://reviews.apache.org/r/64456/diff/1/
>
>
> Testing
> -------
>
> make check on Mac OS 10.11.6 and various Linux distributions.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 64456: Increased wait time for specific task
updates.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64456/
-----------------------------------------------------------
(Updated Dec. 8, 2017, 5:40 p.m.)
Review request for mesos and Benno Evers.
Bugs: MESOS-8316
https://issues.apache.org/jira/browse/MESOS-8316
Repository: mesos
Description (updated)
-------
If a test launches a task that requires internet access, for example,
to download docker images, an initial status update might take some
time to arrive. To avoid flaky tests, we compensate for this by
increasing the wait timeout via `AWAIT_READY_FOR`. However, with the
introduction of `TASK_STARTING`, the first received message is not
`TASK_RUNNING` any more, hence we should use `AWAIT_READY_FOR` for
`TASK_STARTING` updates as well. Since an image can be downloaded for
either executor, or task, or both, we keep extended timeouts for both
status updates.
Diffs
-----
src/tests/containerizer/cgroups_isolator_tests.cpp 54404ee2a8e99128f57a95e56c7f2cb5dd37dbad
src/tests/containerizer/cni_isolator_tests.cpp a6b660de63f767ff0ddc34791540de1427206e92
src/tests/containerizer/docker_containerizer_tests.cpp 1f6ff52daf9687621d42173b7bbf20b6b04e8ab9
src/tests/containerizer/memory_pressure_tests.cpp 9ada46d39f4cb4529298e0e9d2496ccd0522b3c6
src/tests/containerizer/nested_mesos_containerizer_tests.cpp bb2abbc09e8a560830fb9da5c5da8e0bd80c6bc5
src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 5e40a940770cb45c9ac181b953a4e57e4b053445
src/tests/containerizer/provisioner_appc_tests.cpp fc1335c0d432e83c1d13a408aca79bd61ac49701
src/tests/containerizer/provisioner_docker_tests.cpp 2fe8950ad41d0018045c9581d5eb1757f40dec20
src/tests/containerizer/runtime_isolator_tests.cpp 089605d9b0708cb35c171bad2c141c70336c07bd
src/tests/default_executor_tests.cpp d3e3ef770656a36f3469f2ec655102a05adcae8a
src/tests/health_check_tests.cpp c716ad9fa41fe9429de971bb2a1f2e790499572a
Diff: https://reviews.apache.org/r/64456/diff/1/
Testing
-------
make check on Mac OS 10.11.6 and various Linux distributions.
Thanks,
Alexander Rukletsov