You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/11/09 11:06:12 UTC

[GitHub] [zookeeper] ztzg commented on a change in pull request #1530: ZOOKEEPER-3989 GenerateLoad needs to use log for protecting sensitive…

ztzg commented on a change in pull request #1530:
URL: https://github.com/apache/zookeeper/pull/1530#discussion_r519725701



##########
File path: zookeeper-it/src/main/java/org/apache/zookeeper/test/system/GenerateLoad.java
##########
@@ -713,7 +711,7 @@ private static String getMode(String hostPort) throws NumberFormatException, Unk
     }
 
     private static void doUsage() {
-        System.err.println("USAGE: " + GenerateLoad.class.getName()
+        LOG.info("USAGE: " + GenerateLoad.class.getName()

Review comment:
       I would say that the usage synopsis should still go to `System.err`.  What do you think?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org