You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@gmail.com> on 2017/04/04 17:46:40 UTC
Re: Review Request 58097: Added a test to check framework filtering in
/roles endpoint.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58097/
-----------------------------------------------------------
(Updated April 5, 2017, 1:46 a.m.)
Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler.
Changes
-------
rebase
Bugs: MESOS-7260
https://issues.apache.org/jira/browse/MESOS-7260
Repository: mesos
Description
-------
Added a test to check framework filtering in /roles endpoint.
Diffs (updated)
-----
src/tests/master_authorization_tests.cpp 1a0285a3f345ef21a8256d4123d8bb684f538da4
Diff: https://reviews.apache.org/r/58097/diff/2/
Changes: https://reviews.apache.org/r/58097/diff/1-2/
Testing
-------
make check
Thanks,
Jay Guo
Re: Review Request 58097: Added a test to check framework filtering in
/roles endpoint.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58097/#review175218
-----------------------------------------------------------
Also need a test for the v1 API authz changes in https://reviews.apache.org/r/58099
src/tests/master_authorization_tests.cpp
Lines 2148 (patched)
<https://reviews.apache.org/r/58097/#comment248646>
s/frameworks under a roles is/frameworks under a role are/
src/tests/master_authorization_tests.cpp
Lines 2226 (patched)
<https://reviews.apache.org/r/58097/#comment248648>
Please validate the single role name is as expected.
- Adam B
On May 10, 2017, 6:47 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58097/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 6:47 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler.
>
>
> Bugs: MESOS-7260
> https://issues.apache.org/jira/browse/MESOS-7260
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test to check framework filtering in /roles endpoint.
>
>
> Diffs
> -----
>
> src/tests/master_authorization_tests.cpp e4233c19b1d9e3e2734259503d0daec4ce243667
>
>
> Diff: https://reviews.apache.org/r/58097/diff/6/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 58097: Added a test to check framework filtering in
/roles endpoint.
Posted by Jay Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58097/
-----------------------------------------------------------
(Updated June 22, 2017, 2:01 a.m.)
Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler.
Changes
-------
rebase and address comments
Bugs: MESOS-7260
https://issues.apache.org/jira/browse/MESOS-7260
Repository: mesos
Description
-------
Added a test to check framework filtering in /roles endpoint.
Diffs (updated)
-----
src/tests/master_authorization_tests.cpp 8d54472d8a31956e6e8bb5fe7ffbf47dc793c0bc
Diff: https://reviews.apache.org/r/58097/diff/7/
Changes: https://reviews.apache.org/r/58097/diff/6-7/
Testing
-------
make check
Thanks,
Jay Guo
Re: Review Request 58097: Added a test to check framework filtering in
/roles endpoint.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58097/#review174542
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On May 10, 2017, 3:47 p.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58097/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 3:47 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler.
>
>
> Bugs: MESOS-7260
> https://issues.apache.org/jira/browse/MESOS-7260
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test to check framework filtering in /roles endpoint.
>
>
> Diffs
> -----
>
> src/tests/master_authorization_tests.cpp e4233c19b1d9e3e2734259503d0daec4ce243667
>
>
> Diff: https://reviews.apache.org/r/58097/diff/6/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 58097: Added a test to check framework filtering in
/roles endpoint.
Posted by Jay Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58097/
-----------------------------------------------------------
(Updated May 10, 2017, 9:47 p.m.)
Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler.
Changes
-------
rebase
Bugs: MESOS-7260
https://issues.apache.org/jira/browse/MESOS-7260
Repository: mesos
Description
-------
Added a test to check framework filtering in /roles endpoint.
Diffs (updated)
-----
src/tests/master_authorization_tests.cpp e4233c19b1d9e3e2734259503d0daec4ce243667
Diff: https://reviews.apache.org/r/58097/diff/6/
Changes: https://reviews.apache.org/r/58097/diff/5-6/
Testing
-------
make check
Thanks,
Jay Guo
Re: Review Request 58097: Added a test to check framework filtering in
/roles endpoint.
Posted by Jay Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58097/
-----------------------------------------------------------
(Updated May 8, 2017, 3:56 p.m.)
Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler.
Changes
-------
rebase
Bugs: MESOS-7260
https://issues.apache.org/jira/browse/MESOS-7260
Repository: mesos
Description
-------
Added a test to check framework filtering in /roles endpoint.
Diffs (updated)
-----
src/tests/master_authorization_tests.cpp e4233c19b1d9e3e2734259503d0daec4ce243667
Diff: https://reviews.apache.org/r/58097/diff/5/
Changes: https://reviews.apache.org/r/58097/diff/4-5/
Testing
-------
make check
Thanks,
Jay Guo
Re: Review Request 58097: Added a test to check framework filtering in
/roles endpoint.
Posted by Jay Guo <gu...@gmail.com>.
> On April 27, 2017, 11:05 p.m., Alexander Rojas wrote:
> > src/tests/master_authorization_tests.cpp
> > Line 2063 (original), 2062 (patched)
> > <https://reviews.apache.org/r/58097/diff/4/?file=1694001#file1694001line2063>
> >
> > Not yours, but no test verifies that the serialzation of quotas/weights is done correctly. Since you are changing how it is performed, coul you test that too?
I feel `RoleTest` is sufficient, no?
- Jay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58097/#review173207
-----------------------------------------------------------
On May 8, 2017, 3:56 p.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58097/
> -----------------------------------------------------------
>
> (Updated May 8, 2017, 3:56 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler.
>
>
> Bugs: MESOS-7260
> https://issues.apache.org/jira/browse/MESOS-7260
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test to check framework filtering in /roles endpoint.
>
>
> Diffs
> -----
>
> src/tests/master_authorization_tests.cpp e4233c19b1d9e3e2734259503d0daec4ce243667
>
>
> Diff: https://reviews.apache.org/r/58097/diff/5/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 58097: Added a test to check framework filtering in
/roles endpoint.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58097/#review173207
-----------------------------------------------------------
src/tests/master_authorization_tests.cpp
Line 2063 (original), 2062 (patched)
<https://reviews.apache.org/r/58097/#comment246265>
Not yours, but no test verifies that the serialzation of quotas/weights is done correctly. Since you are changing how it is performed, coul you test that too?
- Alexander Rojas
On April 19, 2017, 5:38 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58097/
> -----------------------------------------------------------
>
> (Updated April 19, 2017, 5:38 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler.
>
>
> Bugs: MESOS-7260
> https://issues.apache.org/jira/browse/MESOS-7260
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test to check framework filtering in /roles endpoint.
>
>
> Diffs
> -----
>
> src/tests/master_authorization_tests.cpp 1a0285a3f345ef21a8256d4123d8bb684f538da4
>
>
> Diff: https://reviews.apache.org/r/58097/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 58097: Added a test to check framework filtering in
/roles endpoint.
Posted by Jay Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58097/
-----------------------------------------------------------
(Updated April 19, 2017, 11:38 a.m.)
Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler.
Changes
-------
rebase
Bugs: MESOS-7260
https://issues.apache.org/jira/browse/MESOS-7260
Repository: mesos
Description
-------
Added a test to check framework filtering in /roles endpoint.
Diffs (updated)
-----
src/tests/master_authorization_tests.cpp 1a0285a3f345ef21a8256d4123d8bb684f538da4
Diff: https://reviews.apache.org/r/58097/diff/4/
Changes: https://reviews.apache.org/r/58097/diff/3-4/
Testing
-------
make check
Thanks,
Jay Guo
Re: Review Request 58097: Added a test to check framework filtering in
/roles endpoint.
Posted by Jay Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58097/
-----------------------------------------------------------
(Updated April 12, 2017, 1:38 p.m.)
Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler.
Changes
-------
rebase
Bugs: MESOS-7260
https://issues.apache.org/jira/browse/MESOS-7260
Repository: mesos
Description
-------
Added a test to check framework filtering in /roles endpoint.
Diffs (updated)
-----
src/tests/master_authorization_tests.cpp 1a0285a3f345ef21a8256d4123d8bb684f538da4
Diff: https://reviews.apache.org/r/58097/diff/3/
Changes: https://reviews.apache.org/r/58097/diff/2-3/
Testing
-------
make check
Thanks,
Jay Guo