You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by "David Jencks (JIRA)" <pl...@jakarta.apache.org> on 2004/12/20 09:15:14 UTC

[jira] Created: (PLUTO-92) Deployer strips existing mime-mapping elements out of web.xml

Deployer strips existing mime-mapping elements out of web.xml
-------------------------------------------------------------

         Key: PLUTO-92
         URL: http://nagoya.apache.org/jira/browse/PLUTO-92
     Project: Pluto
        Type: Bug
  Components: deployer  
    Versions: 1.0.1-rc1    
    Reporter: David Jencks


The deployer will remove any mime-mapping elements from the input web.xml when preprocessing the portlet.xml file.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (PLUTO-92) Deployer strips existing mime-mapping elements out of web.xml

Posted by "Nick Lothian (JIRA)" <pl...@jakarta.apache.org>.
     [ http://nagoya.apache.org/jira/browse/PLUTO-92?page=comments#action_56958 ]
     
Nick Lothian commented on PLUTO-92:
-----------------------------------

The deployer also strips listeners.

I like the idea of adding all portlets to the entity registry, but I'd prefer to split it up so they can be called seperatly. (In my case I'd like to be able to inject the Pluto-specific information without actually deploying the portlet). Note that I haven't looked at the patch, yet, so this might be covered.

> Deployer strips existing mime-mapping elements out of web.xml
> -------------------------------------------------------------
>
>          Key: PLUTO-92
>          URL: http://nagoya.apache.org/jira/browse/PLUTO-92
>      Project: Pluto
>         Type: Bug
>   Components: deployer
>     Versions: 1.0.1-rc1
>     Reporter: David Jencks
>  Attachments: Deploy.java.patch
>
> The deployer will remove any mime-mapping elements from the input web.xml when preprocessing the portlet.xml file.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


Re: [jira] Updated: (PLUTO-92) Deployer strips existing mime-mapping elements out of web.xml

Posted by "David H. DeWolf" <dd...@apache.org>.
Dain,

Would you mind taking a look and seeing if your servletmapping.xml 
(required by the patch) is different than the 
servletdefinitionmapping.xml located in WEB-INF/data/xml.  I've applied 
your patch and have been able to get the Deploy tool to automatically 
update the registry, however, it is still stripping mime-mappings and 
other elements).

It seems to me like ensuring elements don't get stripped would require 
us to map every possible element within the web.xml in the 
servletmapping.xml.  If you've done this allready it would save me some 
time :) -- also, I'm interested to see if you figured out a way to do 
this without having to create new classes to represent each of the 
elements (I'm not much of a castor guru).

Also,

If anyone needs, I've attached a new version of the patch to the bug. 
I've done this because:

1) The original patch was against and old version of Deploy --- I've 
manually compensated for the differences.

2) The original patch had windows style line feeds which caused my patch 
utility to blow up.  If anyone else is having troubles with the patch, 
that's probably the reason why.

David


Dain Sundstrom (JIRA) wrote:
>      [ http://issues.apache.org/jira/browse/PLUTO-92?page=history ]
> 
> Dain Sundstrom updated PLUTO-92:
> --------------------------------
> 
>     Attachment: portletmapping.xml
> 
> 
>>Deployer strips existing mime-mapping elements out of web.xml
>>-------------------------------------------------------------
>>
>>         Key: PLUTO-92
>>         URL: http://issues.apache.org/jira/browse/PLUTO-92
>>     Project: Pluto
>>        Type: Bug
>>  Components: deployer
>>    Versions: 1.0.1-rc1
>>    Reporter: David Jencks
>> Attachments: Deploy.java.patch, portletmapping.xml
>>
>>The deployer will remove any mime-mapping elements from the input web.xml when preprocessing the portlet.xml file.
> 
> 

[jira] Updated: (PLUTO-92) Deployer strips existing mime-mapping elements out of web.xml

Posted by "Dain Sundstrom (JIRA)" <pl...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/PLUTO-92?page=history ]

Dain Sundstrom updated PLUTO-92:
--------------------------------

    Attachment: portletmapping.xml

> Deployer strips existing mime-mapping elements out of web.xml
> -------------------------------------------------------------
>
>          Key: PLUTO-92
>          URL: http://issues.apache.org/jira/browse/PLUTO-92
>      Project: Pluto
>         Type: Bug
>   Components: deployer
>     Versions: 1.0.1-rc1
>     Reporter: David Jencks
>  Attachments: Deploy.java.patch, portletmapping.xml
>
> The deployer will remove any mime-mapping elements from the input web.xml when preprocessing the portlet.xml file.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Updated: (PLUTO-92) Deployer strips existing mime-mapping elements out of web.xml

Posted by "Dain Sundstrom (JIRA)" <pl...@jakarta.apache.org>.
     [ http://nagoya.apache.org/jira/browse/PLUTO-92?page=history ]

Dain Sundstrom updated PLUTO-92:
--------------------------------

    Attachment: Deploy.java.patch

Fixes the mime type problem and other similar problems with dropping information from the web.xml.  This version also automatically adds all portlets to the entity registry xml file.

> Deployer strips existing mime-mapping elements out of web.xml
> -------------------------------------------------------------
>
>          Key: PLUTO-92
>          URL: http://nagoya.apache.org/jira/browse/PLUTO-92
>      Project: Pluto
>         Type: Bug
>   Components: deployer
>     Versions: 1.0.1-rc1
>     Reporter: David Jencks
>  Attachments: Deploy.java.patch
>
> The deployer will remove any mime-mapping elements from the input web.xml when preprocessing the portlet.xml file.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (PLUTO-92) Deployer strips existing mime-mapping elements out of web.xml

Posted by "David DeWolf (JIRA)" <pl...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/PLUTO-92?page=comments#action_57958 ]
     
David DeWolf commented on PLUTO-92:
-----------------------------------

I've applied the patch and am getting errors when I try to deploy the portlet.  I don't have a chance to look into the issues right now, so if there's anything else off the top of your head that I need to add, please let me know so that I can get this committed for the RC3 release.  Otherwise, I'll aim to take a look later on this week.

deployTestsuite:
    [java] Unpacking war 'testsuite' to 'C:\dev\portals-pluto\testsuite\..\tomcat\webapps\testsuite'
    [java] finished!
    [java] Processing war 'testsuite
    [java] java.io.FileNotFoundException: Web mapping file not found portletmapping.xml
    [java]      at org.apache.pluto.portalImpl.Deploy.loadPortletXml(Deploy.java:415)
    [java]      at org.apache.pluto.portalImpl.Deploy.prepareWebArchive(Deploy.java:148)
    [java]      at org.apache.pluto.portalImpl.Deploy.main(Deploy.java:537)

Looks like I'm missing an xml/portletmapping.xml file in my classpath.  What is this file?

URL portletMapping = Deploy.class.getResource("xml/portletmapping.xml");

> Deployer strips existing mime-mapping elements out of web.xml
> -------------------------------------------------------------
>
>          Key: PLUTO-92
>          URL: http://issues.apache.org/jira/browse/PLUTO-92
>      Project: Pluto
>         Type: Bug
>   Components: deployer
>     Versions: 1.0.1-rc1
>     Reporter: David Jencks
>  Attachments: Deploy.java.patch
>
> The deployer will remove any mime-mapping elements from the input web.xml when preprocessing the portlet.xml file.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Updated: (PLUTO-92) Deployer strips existing mime-mapping elements out of web.xml

Posted by "David DeWolf (JIRA)" <pl...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/PLUTO-92?page=history ]

David DeWolf updated PLUTO-92:
------------------------------

    Attachment: Deploy.java.patch2

New patch file which goes against the current head revision and also removes the windows style line breaks.

It also happens to patch nicely using svn patch so that you can patch it against the repo.

> Deployer strips existing mime-mapping elements out of web.xml
> -------------------------------------------------------------
>
>          Key: PLUTO-92
>          URL: http://issues.apache.org/jira/browse/PLUTO-92
>      Project: Pluto
>         Type: Bug
>   Components: deployer
>     Versions: 1.0.1-rc1
>     Reporter: David Jencks
>  Attachments: Deploy.java.patch, Deploy.java.patch2, portletmapping.xml
>
> The deployer will remove any mime-mapping elements from the input web.xml when preprocessing the portlet.xml file.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


Re: [jira] Resolved: (PLUTO-92) Deployer strips elements from web.xml

Posted by "David H. DeWolf" <dd...@apache.org>.
Craig Doremus wrote:
> Hi David,
> 
> Good job on refactoring the deployer! I will now work on refactoring the 
> admin portlets to use the new deployer classes.

Thanks! It was long over due but it's a first step in the right 
direction.  Possible enhancements I have in mind are refactoring out 
service interfaces to allow us to implement different implementations of 
the deployer components.

> 
> BTW, I got a message from Apache notifying me of an account created on 
> cvs.apache.org. What do I do now to get access to the SVN repository?

Great!  The PMC just got an email today indicating that all we should 
need to do now is grant you the appropriate karma.  I'm not sure what 
needs to be done there so if I don't see any movement on this tomorrow 
I'll ping the PMC and see if it's something I can take care of.

Once that's complete, take a look at:

http://apache.org/dev/version-control.html

Specifically, don't miss these sentences:

"Right now, you still need a shell account to use it, since you must set 
your password using that shell. To do so, SSH to svn.apache.org, and 
enter the command svnpasswd. This will prompt you to enter a svn 
password of your choice. Pick a safe password!"

Note that svn.apache.org is just an alias to cvs.apache.org so you DO 
already have access there if I'm not mistaken.

> 
> TIA
> /Craig
> 
> David DeWolf (JIRA) wrote:
> 
>>     [ http://issues.apache.org/jira/browse/PLUTO-92?page=history ]
>>     David DeWolf resolved PLUTO-92:
>> -------------------------------
>>
>>    Resolution: Fixed
>>
>> The old deployer has been deprecated and a new deployer which does not 
>> remove elements has been added.
>>
>>  
>>
>>> Deployer strips elements from web.xml
>>> -------------------------------------
>>>
>>>         Key: PLUTO-92
>>>         URL: http://issues.apache.org/jira/browse/PLUTO-92
>>>     Project: Pluto
>>>        Type: Bug
>>>  Components: deployer
>>>    Versions: 1.0.1-rc1
>>>    Reporter: David Jencks
>>> Attachments: Deploy.java.patch, Deploy.java.patch2, portletmapping.xml
>>>
>>> The deployer will remove any mime-mapping elements from the input 
>>> web.xml when preprocessing the portlet.xml file.
>>> ---
>>> In addition, the deployer strips many other elements, such as the 
>>> load-on-startup, and role-names.
>>>   
>>
>>
>>  
>>
> 
> 

Re: [jira] Resolved: (PLUTO-92) Deployer strips elements from web.xml

Posted by Craig Doremus <cr...@maine.com>.
Hi David,

Good job on refactoring the deployer! I will now work on refactoring the 
admin portlets to use the new deployer classes.

BTW, I got a message from Apache notifying me of an account created on 
cvs.apache.org. What do I do now to get access to the SVN repository?

TIA
/Craig

David DeWolf (JIRA) wrote:

>     [ http://issues.apache.org/jira/browse/PLUTO-92?page=history ]
>     
>David DeWolf resolved PLUTO-92:
>-------------------------------
>
>    Resolution: Fixed
>
>The old deployer has been deprecated and a new deployer which does not remove elements has been added.
>
>  
>
>>Deployer strips elements from web.xml
>>-------------------------------------
>>
>>         Key: PLUTO-92
>>         URL: http://issues.apache.org/jira/browse/PLUTO-92
>>     Project: Pluto
>>        Type: Bug
>>  Components: deployer
>>    Versions: 1.0.1-rc1
>>    Reporter: David Jencks
>> Attachments: Deploy.java.patch, Deploy.java.patch2, portletmapping.xml
>>
>>The deployer will remove any mime-mapping elements from the input web.xml when preprocessing the portlet.xml file.
>>---
>>In addition, the deployer strips many other elements, such as the load-on-startup, and role-names.
>>    
>>
>
>  
>


[jira] Resolved: (PLUTO-92) Deployer strips elements from web.xml

Posted by "David DeWolf (JIRA)" <pl...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/PLUTO-92?page=history ]
     
David DeWolf resolved PLUTO-92:
-------------------------------

    Resolution: Fixed

The old deployer has been deprecated and a new deployer which does not remove elements has been added.

> Deployer strips elements from web.xml
> -------------------------------------
>
>          Key: PLUTO-92
>          URL: http://issues.apache.org/jira/browse/PLUTO-92
>      Project: Pluto
>         Type: Bug
>   Components: deployer
>     Versions: 1.0.1-rc1
>     Reporter: David Jencks
>  Attachments: Deploy.java.patch, Deploy.java.patch2, portletmapping.xml
>
> The deployer will remove any mime-mapping elements from the input web.xml when preprocessing the portlet.xml file.
> ---
> In addition, the deployer strips many other elements, such as the load-on-startup, and role-names.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Updated: (PLUTO-92) Deployer strips elements from web.xml

Posted by "David DeWolf (JIRA)" <pl...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/PLUTO-92?page=history ]

David DeWolf updated PLUTO-92:
------------------------------

        Summary: Deployer strips elements from web.xml  (was: Deployer strips existing mime-mapping elements out of web.xml)
    Description: 
The deployer will remove any mime-mapping elements from the input web.xml when preprocessing the portlet.xml file.

---

In addition, the deployer strips many other elements, such as the load-on-startup, and role-names.

  was:The deployer will remove any mime-mapping elements from the input web.xml when preprocessing the portlet.xml file.


> Deployer strips elements from web.xml
> -------------------------------------
>
>          Key: PLUTO-92
>          URL: http://issues.apache.org/jira/browse/PLUTO-92
>      Project: Pluto
>         Type: Bug
>   Components: deployer
>     Versions: 1.0.1-rc1
>     Reporter: David Jencks
>  Attachments: Deploy.java.patch, Deploy.java.patch2, portletmapping.xml
>
> The deployer will remove any mime-mapping elements from the input web.xml when preprocessing the portlet.xml file.
> ---
> In addition, the deployer strips many other elements, such as the load-on-startup, and role-names.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (PLUTO-92) Deployer strips existing mime-mapping elements out of web.xml

Posted by "Dain Sundstrom (JIRA)" <pl...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/PLUTO-92?page=comments#action_58741 ]
     
Dain Sundstrom commented on PLUTO-92:
-------------------------------------

I have no idea where I got this file.  I searched all though svn, but could not find it.  The file is a castor mapping for the portlet.xml file to the portlet classes.  I didn't write is as I don't know much about castor.  I would assume that it is in the same location as the rest of the castor mapping files.  Anyway, I'll attach the file to the jira issue.

> Deployer strips existing mime-mapping elements out of web.xml
> -------------------------------------------------------------
>
>          Key: PLUTO-92
>          URL: http://issues.apache.org/jira/browse/PLUTO-92
>      Project: Pluto
>         Type: Bug
>   Components: deployer
>     Versions: 1.0.1-rc1
>     Reporter: David Jencks
>  Attachments: Deploy.java.patch, portletmapping.xml
>
> The deployer will remove any mime-mapping elements from the input web.xml when preprocessing the portlet.xml file.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira