You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/05/19 04:06:36 UTC

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7692: Fix case insensitive ParserUtils.findDuplicates

clintropolis commented on a change in pull request #7692: Fix case insensitive ParserUtils.findDuplicates
URL: https://github.com/apache/incubator-druid/pull/7692#discussion_r285362878
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/data/input/impl/DimensionsSpec.java
 ##########
 @@ -199,9 +199,6 @@ private void verify(List<SpatialDimensionSchema> spatialDimensions)
         "dimensions and dimensions exclusions cannot overlap"
     );
 
-    ParserUtils.validateFields(dimNames);
 
 Review comment:
   it seems like this should still be there to check for true duplicates?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org