You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2019/01/16 06:24:28 UTC
[GitHub] bwsw commented on a change in pull request #3036: CLOUDSTACK-3035:
Implemented capabilities for snapshots and vm snapshots.
bwsw commented on a change in pull request #3036: CLOUDSTACK-3035: Implemented capabilities for snapshots and vm snapshots.
URL: https://github.com/apache/cloudstack/pull/3036#discussion_r248162931
##########
File path: server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
##########
@@ -1045,16 +1037,13 @@ protected VMSnapshot retrieve() {
long vmId;
public VmJobVirtualMachineOutcome(final AsyncJob job, final long vmId) {
- super(VirtualMachine.class, job, VmJobCheckInterval.value(), new Predicate() {
- @Override
- public boolean checkCondition() {
- AsyncJobVO jobVo = _entityMgr.findById(AsyncJobVO.class, job.getId());
- assert (jobVo != null);
- if (jobVo == null || jobVo.getStatus() != JobInfo.Status.IN_PROGRESS)
- return true;
+ super(VirtualMachine.class, job, VirtualMachineManager.VmJobCheckInterval.value(), () -> {
+ AsyncJobVO jobVo = _entityMgr.findById(AsyncJobVO.class, job.getId());
+ assert (jobVo != null);
+ if (jobVo == null || jobVo.getStatus() != JobInfo.Status.IN_PROGRESS)
Review comment:
@rafaelweingartner Little bit busy last days. Try to find the time next week to go thru all the comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services