You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "mosermw (via GitHub)" <gi...@apache.org> on 2025/05/21 21:27:48 UTC

[PR] NIFI-14442 Show bundle version changes in versioned flow differences [nifi]

mosermw opened a new pull request, #9967:
URL: https://github.com/apache/nifi/pull/9967

   # Summary
   
   [NIFI-14442](https://issues.apache.org/jira/browse/NIFI-14442)
   
   This PR collects bundle version differences between a local Versioned Process Group and its FlowRegistry version.
   These differences will only appear after another local change has been made.  Bundle version differences still do not
   count when determining a Versioned Process Group's state.
   
   This does not handle the case when a Versioned Process Group is imported from a FlowRegistry and then local changes
   are immediately made.  In this scenario, there will be no bundle version differences.  This is because that Process Group's
   versioned snapshot is modified from what is in the FlowRegistry, to update bundle versions and references to controller services
   and parameter providers.  However, if you restart NiFi, the PG's versioned snapshot is pulled from the FlowRegisry on
   startup, and then bundle version differences will be shown.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [x] Pull Request based on current revision of the `main` branch
   - [x] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
     - [ ] JDK 21
   
   ### Licensing
   
   - [n/a] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [n/a] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [x] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14442 Show bundle version changes in versioned flow differences [nifi]

Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory merged PR #9967:
URL: https://github.com/apache/nifi/pull/9967


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14442 Show bundle version changes in versioned flow differences [nifi]

Posted by "mosermw (via GitHub)" <gi...@apache.org>.
mosermw commented on PR #9967:
URL: https://github.com/apache/nifi/pull/9967#issuecomment-3005502421

   Thanks for having a look at this PR @NissimShiman
   
   > I've noticed that the list of local changes has a "Go To" option next to the "Component Bundle Changed" which doesn't lead anywhere. Would it be a big deal to remove that option for this?
   
   I was able to get something to work, then I noticed there is an [open PR for NIFI-14637](https://github.com/apache/nifi/pull/10028) that does almost exactly what I was going to do.  So I think we can wait for that PR to merge, then I can modify this PR to rebase and take advantage of that code.
   
   > Also noticed that if a versioned PG is in flow, NiFi is restarted, PG is updated (and new version pushed to registry) and then is rolled back and then a new change is made (but not committed yet) , the component bundle update does not show up as a local change, but if NiFi is again restarted it will. Is this expected?
   
   Yes it's expected.  This is because the ProcessGroup stores a copy of its versioned snapshot, which typically has already been modified from what's in the FlowRegistry.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14442 Show bundle version changes in versioned flow differences [nifi]

Posted by "joewitt (via GitHub)" <gi...@apache.org>.
joewitt commented on PR #9967:
URL: https://github.com/apache/nifi/pull/9967#issuecomment-2988379228

   @bbende Can you take a look from a review perspective?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14442 Show bundle version changes in versioned flow differences [nifi]

Posted by "NissimShiman (via GitHub)" <gi...@apache.org>.
NissimShiman commented on PR #9967:
URL: https://github.com/apache/nifi/pull/9967#issuecomment-3433242969

   Thank you @exceptionfactory for the review.
   I did a quick recompile and test and it performs as described.
   I am +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14442 Show bundle version changes in versioned flow differences [nifi]

Posted by "mosermw (via GitHub)" <gi...@apache.org>.
mosermw commented on code in PR #9967:
URL: https://github.com/apache/nifi/pull/9967#discussion_r2429949881


##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/util/FlowDifferenceFilters.java:
##########
@@ -73,6 +73,10 @@ public static boolean isEnvironmentalChange(final FlowDifference difference, fin
             || isLogFileSuffixChange(difference);
     }
 
+    public static boolean isBundleChange(final FlowDifference difference) {

Review Comment:
   I added a commit for this.  Also rebased onto main because of conflicts and because this PR didn't build anymore due to the npm package.lock changes that were needed from a month ago.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14442 Show bundle version changes in versioned flow differences [nifi]

Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on code in PR #9967:
URL: https://github.com/apache/nifi/pull/9967#discussion_r2328430871


##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/dto/DtoFactory.java:
##########
@@ -2802,6 +2819,24 @@ public Set<ComponentDifferenceDTO> createComponentDifferenceDtosForLocalModifica
        return differencesByComponent.keySet();
    }
 
+   private static final Pattern DIFFERENCE_DESCRIPTION_PATTERN = Pattern.compile(".*artifact='(.*)'.*version='(.*)'].*version='(.*)']'$");

Review Comment:
   Introducing this pattern to reformat the description seems potentially brittle. It would be better to either change it elsewhere, or build the description using values available from the `FlowDifference`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14442 Show bundle version changes in versioned flow differences [nifi]

Posted by "NissimShiman (via GitHub)" <gi...@apache.org>.
NissimShiman commented on PR #9967:
URL: https://github.com/apache/nifi/pull/9967#issuecomment-2988327079

   Reviewing...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14442 Show bundle version changes in versioned flow differences [nifi]

Posted by "mosermw (via GitHub)" <gi...@apache.org>.
mosermw commented on code in PR #9967:
URL: https://github.com/apache/nifi/pull/9967#discussion_r2426874797


##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/dto/DtoFactory.java:
##########
@@ -2821,6 +2846,18 @@ private void flattenProcessGroups(final VersionedProcessGroup group, final Map<S
        }
    }
 
+   private ComponentDifferenceDTO createBundleDifference(final FlowDifference difference) {
+       VersionedComponent component = difference.getComponentB();
+
+       final ComponentDifferenceDTO dto = new ComponentDifferenceDTO();
+       dto.setComponentType(component.getComponentType().toString());
+       // bundle difference could apply to many components, but use the Process Group identifier as
+       // the Component Identifier here so that many similar component differences can be easily deduped
+       dto.setComponentId(component.getGroupIdentifier());

Review Comment:
   This quite nicely dedupes only similar component differences.  As an example, if your Versioned Process Group contains 20 processors from nifi-standard-nar and 1 processor from nifi-jolt-nar, then once you make any non-environmental change, you would see 1 difference in the nifi-jolt-nar version and only 1 difference in the nifi-standard-nar version.  I didn't think showing 21 differences with 20 being the same would be desirable.



##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/util/FlowDifferenceFilters.java:
##########
@@ -73,6 +73,10 @@ public static boolean isEnvironmentalChange(final FlowDifference difference, fin
             || isLogFileSuffixChange(difference);
     }
 
+    public static boolean isBundleChange(final FlowDifference difference) {

Review Comment:
   Ah, I meant to call the new isBundleChange method from the isEnvironmentalChange method above.  This would follow the pattern of the other methods called by isEnvironmentalChange.



##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/dto/DtoFactory.java:
##########
@@ -2792,12 +2800,19 @@ public Set<ComponentDifferenceDTO> createComponentDifferenceDtosForLocalModifica
 
            final ComponentDifferenceDTO componentDiff = createComponentDifference(difference);
            final List<DifferenceDTO> differences = differencesByComponent.computeIfAbsent(componentDiff, key -> new ArrayList<>());
-
-           final DifferenceDTO dto = new DifferenceDTO();
-           dto.setDifferenceType(difference.getDifferenceType().getDescription());
-           dto.setDifference(difference.getDescription());
-
-           differences.add(dto);
+           differences.add(createDifferenceDto(difference));
+       }
+
+       if (!differencesByComponent.isEmpty()) {
+           // differences were found, so now let's add back in any BUNDLE_CHANGED differences
+           // since they were initially filtered out as an environment-specific change

Review Comment:
   Bundle changes are still considered to be an environmental change, **_unless_** another local change has been made.  I didn't want bundle differences to be the only reason a Versioned Process Group would appear as locally changed, because a NiFi upgrade could potentially cause all Versioned PGs to appear locally changed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14442 Show bundle version changes in versioned flow differences [nifi]

Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on code in PR #9967:
URL: https://github.com/apache/nifi/pull/9967#discussion_r2423134156


##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/dto/DtoFactory.java:
##########
@@ -2792,12 +2800,19 @@ public Set<ComponentDifferenceDTO> createComponentDifferenceDtosForLocalModifica
 
            final ComponentDifferenceDTO componentDiff = createComponentDifference(difference);
            final List<DifferenceDTO> differences = differencesByComponent.computeIfAbsent(componentDiff, key -> new ArrayList<>());
-
-           final DifferenceDTO dto = new DifferenceDTO();
-           dto.setDifferenceType(difference.getDifferenceType().getDescription());
-           dto.setDifference(difference.getDescription());
-
-           differences.add(dto);
+           differences.add(createDifferenceDto(difference));
+       }
+
+       if (!differencesByComponent.isEmpty()) {
+           // differences were found, so now let's add back in any BUNDLE_CHANGED differences
+           // since they were initially filtered out as an environment-specific change

Review Comment:
   Does this mean that bundle changes are no longer considered environment-specific changes?



##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/dto/DtoFactory.java:
##########
@@ -2821,6 +2846,18 @@ private void flattenProcessGroups(final VersionedProcessGroup group, final Map<S
        }
    }
 
+   private ComponentDifferenceDTO createBundleDifference(final FlowDifference difference) {
+       VersionedComponent component = difference.getComponentB();
+
+       final ComponentDifferenceDTO dto = new ComponentDifferenceDTO();
+       dto.setComponentType(component.getComponentType().toString());
+       // bundle difference could apply to many components, but use the Process Group identifier as
+       // the Component Identifier here so that many similar component differences can be easily deduped
+       dto.setComponentId(component.getGroupIdentifier());

Review Comment:
   This seems questionable, would it hide multiple component version differences in a given Process Group?



##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/util/FlowDifferenceFilters.java:
##########
@@ -73,6 +73,10 @@ public static boolean isEnvironmentalChange(final FlowDifference difference, fin
             || isLogFileSuffixChange(difference);
     }
 
+    public static boolean isBundleChange(final FlowDifference difference) {

Review Comment:
   This only seems to be used once, is it necessary?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14442 Show bundle version changes in versioned flow differences [nifi]

Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on code in PR #9967:
URL: https://github.com/apache/nifi/pull/9967#discussion_r2330796964


##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/dto/DtoFactory.java:
##########
@@ -2802,6 +2819,24 @@ public Set<ComponentDifferenceDTO> createComponentDifferenceDtosForLocalModifica
        return differencesByComponent.keySet();
    }
 
+   private static final Pattern DIFFERENCE_DESCRIPTION_PATTERN = Pattern.compile(".*artifact='(.*)'.*version='(.*)'].*version='(.*)']'$");

Review Comment:
   Thanks for looking into alternative approaches, sounds good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14442 Show bundle version changes in versioned flow differences [nifi]

Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on code in PR #9967:
URL: https://github.com/apache/nifi/pull/9967#discussion_r2337782823


##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/dto/DtoFactory.java:
##########
@@ -2802,6 +2819,24 @@ public Set<ComponentDifferenceDTO> createComponentDifferenceDtosForLocalModifica
        return differencesByComponent.keySet();
    }
 
+   private static final Pattern DIFFERENCE_DESCRIPTION_PATTERN = Pattern.compile(".*artifact='(.*)'.*version='(.*)'].*version='(.*)']'$");

Review Comment:
   Thanks, rebasing would be a good next step.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14442 Show bundle version changes in versioned flow differences [nifi]

Posted by "mosermw (via GitHub)" <gi...@apache.org>.
mosermw commented on PR #9967:
URL: https://github.com/apache/nifi/pull/9967#issuecomment-3005992911

   > > I've noticed that the list of local changes has a "Go To" option next to the "Component Bundle Changed" which doesn't lead anywhere. Would it be a big deal to remove that option for this?
   > 
   > I was able to get something to work, then I noticed there is an [open PR for NIFI-14637](https://github.com/apache/nifi/pull/10028) that does almost exactly what I was going to do. So I think we can wait for that PR to merge, then I can modify this PR to rebase and take advantage of that code.
   
   The PR 10028 got merged, so I rebased this PR and added the condition to prevent showing the "Go To" action for bundle version differences.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14442 Show bundle version changes in versioned flow differences [nifi]

Posted by "NissimShiman (via GitHub)" <gi...@apache.org>.
NissimShiman commented on code in PR #9967:
URL: https://github.com/apache/nifi/pull/9967#discussion_r2157626826


##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/dto/DtoFactory.java:
##########
@@ -2802,6 +2819,24 @@ public Set<ComponentDifferenceDTO> createComponentDifferenceDtosForLocalModifica
        return differencesByComponent.keySet();
    }
 
+   private static final Pattern DIFFERENCE_DESCRIPTION_PATTERN = Pattern.compile(".*artifact='(.*)'.*version='(.*)'].*version='(.*)']'$");
+
+   /*
+    * Create a custom difference with a simpler difference description, only for matching descriptions.
+    */
+   DifferenceDTO createDifferenceDto(final FlowDifference difference) {
+       final DifferenceDTO dto = new DifferenceDTO();
+       dto.setDifferenceType(difference.getDifferenceType().getDescription());
+
+       String description = difference.getDescription();
+       final Matcher matcher = DIFFERENCE_DESCRIPTION_PATTERN.matcher(description);
+       if (matcher.matches()) {
+           description = matcher.group(1) + " version " + matcher.group(2) + " to " + matcher.group(3);

Review Comment:
   I think this is a good idea as well.  The default is unwieldy.



##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java:
##########
@@ -5531,12 +5531,7 @@ public FlowComparisonEntity getLocalModifications(final String processGroupId) {
                 + " but cannot find a Flow Registry with that identifier");
         }
 

Review Comment:
   Nice catch, based on the above code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14442 Show bundle version changes in versioned flow differences [nifi]

Posted by "NissimShiman (via GitHub)" <gi...@apache.org>.
NissimShiman commented on PR #9967:
URL: https://github.com/apache/nifi/pull/9967#issuecomment-3025225119

   I have tested the "Go To" option will not appear for these changes (and looked over the code as well).
   Thank you @mosermw for resolving that.
   
   This now performs as described in the jira (with the known edge case in the comment still present).
   
   This lets the user know in many cases that a bundle version change is about to be persisted to registry, but maybe the edge case could be worked out as well.
   
   More work would be needed so a process group's versioned snapshot should not be modified from what is in the FlowRegistry to make this edge case work as well, but that is a lot of work.
   
   @bbende Is this something that would make sense to be done as part of this PR? or this something that should be left alone?
   (and, if it should be left alone, is the PR good as is?)   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14442 Show bundle version changes in versioned flow differences [nifi]

Posted by "NissimShiman (via GitHub)" <gi...@apache.org>.
NissimShiman commented on PR #9967:
URL: https://github.com/apache/nifi/pull/9967#issuecomment-2988614906

   I think letting users know that a component bundle update is occurring is a nice addition.  Especially the way it is being done conditionally.
   I've noticed that the list of local changes has a "Go To" option next to the "Component Bundle Changed" which doesn't lead anywhere.  Would it be a big deal to remove that option for this?
   
   Also noticed that if a versioned PG is in flow, NiFi is restarted, PG is updated (and new version pushed to registry) and then is rolled back and then a new change is made (but not committed yet) , the component bundle update does not show up as a local change, but if NiFi is again restarted it will.  Is this expected?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14442 Show bundle version changes in versioned flow differences [nifi]

Posted by "mosermw (via GitHub)" <gi...@apache.org>.
mosermw commented on code in PR #9967:
URL: https://github.com/apache/nifi/pull/9967#discussion_r2330758069


##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/dto/DtoFactory.java:
##########
@@ -2802,6 +2819,24 @@ public Set<ComponentDifferenceDTO> createComponentDifferenceDtosForLocalModifica
        return differencesByComponent.keySet();
    }
 
+   private static final Pattern DIFFERENCE_DESCRIPTION_PATTERN = Pattern.compile(".*artifact='(.*)'.*version='(.*)'].*version='(.*)']'$");

Review Comment:
   I appreciate your eyes on this PR @exceptionfactory.  This was the least intrusive approach I could think of at the time, but I agree it is potentially brittle.  I will see what I can do to make improvements.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14442 Show bundle version changes in versioned flow differences [nifi]

Posted by "mosermw (via GitHub)" <gi...@apache.org>.
mosermw commented on code in PR #9967:
URL: https://github.com/apache/nifi/pull/9967#discussion_r2337779526


##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/dto/DtoFactory.java:
##########
@@ -2802,6 +2819,24 @@ public Set<ComponentDifferenceDTO> createComponentDifferenceDtosForLocalModifica
        return differencesByComponent.keySet();
    }
 
+   private static final Pattern DIFFERENCE_DESCRIPTION_PATTERN = Pattern.compile(".*artifact='(.*)'.*version='(.*)'].*version='(.*)']'$");

Review Comment:
   I moved this code to the ConciseEvolvingDifferenceDescriptor class where some other difference descriptions are generated, and I do think this made the code cleaner.
   
   Should I rebase this PR onto main, to try to resolve the macos build/test issues in the CI checks?  Or can those checks be ignored for now?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14442 Show bundle version changes in versioned flow differences [nifi]

Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #9967:
URL: https://github.com/apache/nifi/pull/9967#issuecomment-3433999812

   Thanks for the confirmation @NissimShiman, and thanks again @mosermw! +1 merging


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org