Re: [PR] feat: up to date docs screenshots with playwright [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #36297:
URL: https://github.com/apache/superset/pull/36297#issuecomment-3604436627

   Looks like pre-commit needs to be run, and we have some licensing header failures on:
   * superset-frontend/playwright/tests/auth.setup.ts
   * superset-frontend/playwright/tests/docs/docs-screenshots.spec.ts
   
   For the headers, you can copy/paste them from the top of other ts files. For the pre-commit stuff:
   Superset uses Git pre-commit hooks courtesy of [pre-commit](https://pre-commit.com/). To install run the following:
   ```
   pip3 install -r requirements/development.txt
   pre-commit install
   ```
   A series of checks will now run when you make a git commit.
   
   Alternatively it is possible to run pre-commit by running pre-commit manually:
   ```
   pre-commit run --all-files
   ``` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org