You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/08/12 15:37:00 UTC

[jira] [Commented] (AIRFLOW-5172) Add ability to have DAGs execute at the start of their scheduled interval

    [ https://issues.apache.org/jira/browse/AIRFLOW-5172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905313#comment-16905313 ] 

ASF GitHub Bot commented on AIRFLOW-5172:
-----------------------------------------

iroddis commented on pull request #5787: [AIRFLOW-5172] Add choice of interval edge scheduling
URL: https://github.com/apache/airflow/pull/5787
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5172
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI changes:
   
   This change introduces the attribute `schedule_interval_edge`, a string containing either 'start' or 'end', to DAGs. The scheduler uses the value to determining if a DAG should be scheduled at the start or the end of the schedule interval.
   
   A parameter with the same name was also added to the default_airflow.cfg in the [scheduler] section. 
   
   ### Tests
   
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   tests.jobs.test_scheduler_job:SchedulerJobTest.test_schedule_interval_edge
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [X] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add ability to have DAGs execute at the start of their scheduled interval
> -------------------------------------------------------------------------
>
>                 Key: AIRFLOW-5172
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5172
>             Project: Apache Airflow
>          Issue Type: Wish
>          Components: DAG, scheduler
>    Affects Versions: 1.10.4
>            Reporter: Ian Roddis
>            Priority: Minor
>
> Airflow's scheduling of tasks at the end of their interval can be confusing, and difficult to choreograph in cases where tasks must execute at a specific time (e.g. collecting ephemeral data).
> I'm sure this feature has been requested before, but my Jira search skills aren't good enough to find much on it.
> This issue to add an option to schedule DAGs at the beginning of the scheduled interval.
> I'll be submitting a PR to add this feature will be arriving shortly.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)