You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "github-actions[bot] (via GitHub)" <gi...@apache.org> on 2023/02/03 04:15:16 UTC

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16089: [enhance](cooldown)accelerate cooldown task produce efficiency

github-actions[bot] commented on code in PR #16089:
URL: https://github.com/apache/doris/pull/16089#discussion_r1095337698


##########
be/test/olap/tablet_test.cpp:
##########
@@ -322,6 +320,7 @@ TEST_F(TestTablet, cooldown_policy) {
     _tablet->_rs_version_map[ptr5->version()] = rowset5;

Review Comment:
   warning: '_rs_version_map' is a private member of 'doris::Tablet' [clang-diagnostic-error]
   ```cpp
       _tablet->_rs_version_map[ptr5->version()] = rowset5;
                ^
   ```
   **be/src/olap/tablet.h:437:** declared private here
   ```cpp
       std::unordered_map<Version, RowsetSharedPtr, HashOfVersion> _rs_version_map;
                                                                   ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org