You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uima.apache.org by de...@apache.org on 2013/02/08 16:13:40 UTC

svn commit: r1444055 - /uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/

Author: degenaro
Date: Fri Feb  8 15:13:40 2013
New Revision: 1444055

URL: http://svn.apache.org/r1444055
Log:
UIMA-2650 DUCC webserver (WS) should not normally record "java.io.IOException: Broken pipe" exceptions to its log file

Modified:
    uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccAbstractHandler.java
    uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandler.java
    uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandlerJsonFormat.java
    uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandlerLegacy.java
    uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandlerProxy.java
    uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandlerUserAuthentication.java

Modified: uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccAbstractHandler.java
URL: http://svn.apache.org/viewvc/uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccAbstractHandler.java?rev=1444055&r1=1444054&r2=1444055&view=diff
==============================================================================
--- uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccAbstractHandler.java (original)
+++ uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccAbstractHandler.java Fri Feb  8 15:13:40 2013
@@ -28,6 +28,7 @@ import java.util.concurrent.TimeUnit;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
 
+import org.apache.commons.lang.exception.ExceptionUtils;
 import org.apache.uima.ducc.common.NodeIdentity;
 import org.apache.uima.ducc.common.boot.DuccDaemonRuntimeProperties.DaemonName;
 import org.apache.uima.ducc.common.internationalization.Messages;
@@ -94,6 +95,19 @@ public abstract class DuccAbstractHandle
 	
 	public static final RequestStateType requestStateTypeDefault = RequestStateType.All;
 	
+	public boolean isIgnorable(Throwable t) {
+		boolean retVal = false;
+		try {
+			String rcm = ExceptionUtils.getMessage(t);
+			if(rcm.endsWith("java.io.IOException: Broken pipe")) {
+				retVal = true;
+			}
+		}
+		catch(Throwable throwable) {
+		}
+		return retVal;
+	}
+	
 	public String quote(String string) {
 		return "\""+string+"\"";
 	}

Modified: uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandler.java
URL: http://svn.apache.org/viewvc/uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandler.java?rev=1444055&r1=1444054&r2=1444055&view=diff
==============================================================================
--- uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandler.java (original)
+++ uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandler.java Fri Feb  8 15:13:40 2013
@@ -2658,9 +2658,13 @@ public class DuccHandler extends DuccAbs
 			handleDuccRequest(target, baseRequest, request, response);
 		}
 		catch(Throwable t) {
-			DuccId jobid = null;
-			duccLogger.info(methodName, jobid, "", t.getMessage(), t);
-			duccLogger.error(methodName, null, t);
+			if(isIgnorable(t)) {
+				duccLogger.debug(methodName, jobid, t);
+			}
+			else {
+				duccLogger.info(methodName, jobid, "", t.getMessage(), t);
+				duccLogger.error(methodName, jobid, t);
+			}
 		}
 	}
 	

Modified: uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandlerJsonFormat.java
URL: http://svn.apache.org/viewvc/uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandlerJsonFormat.java?rev=1444055&r1=1444054&r2=1444055&view=diff
==============================================================================
--- uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandlerJsonFormat.java (original)
+++ uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandlerJsonFormat.java Fri Feb  8 15:13:40 2013
@@ -1319,8 +1319,13 @@ public class DuccHandlerJsonFormat exten
 			}
 		}
 		catch(Throwable t) {
-			duccLogger.info(methodName, jobid, "", t.getMessage(), t);
-			duccLogger.error(methodName, jobid, t);
+			if(isIgnorable(t)) {
+				duccLogger.debug(methodName, jobid, t);
+			}
+			else {
+				duccLogger.info(methodName, jobid, "", t.getMessage(), t);
+				duccLogger.error(methodName, jobid, t);
+			}
 		}
 	}
 

Modified: uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandlerLegacy.java
URL: http://svn.apache.org/viewvc/uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandlerLegacy.java?rev=1444055&r1=1444054&r2=1444055&view=diff
==============================================================================
--- uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandlerLegacy.java (original)
+++ uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandlerLegacy.java Fri Feb  8 15:13:40 2013
@@ -1575,8 +1575,13 @@ public class DuccHandlerLegacy extends D
 			}
 		}
 		catch(Throwable t) {
-			duccLogger.info(methodName, jobid, "", t.getMessage(), t);
-			duccLogger.error(methodName, jobid, t);
+			if(isIgnorable(t)) {
+				duccLogger.debug(methodName, jobid, t);
+			}
+			else {
+				duccLogger.info(methodName, jobid, "", t.getMessage(), t);
+				duccLogger.error(methodName, jobid, t);
+			}
 		}
 	}
 

Modified: uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandlerProxy.java
URL: http://svn.apache.org/viewvc/uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandlerProxy.java?rev=1444055&r1=1444054&r2=1444055&view=diff
==============================================================================
--- uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandlerProxy.java (original)
+++ uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandlerProxy.java Fri Feb  8 15:13:40 2013
@@ -166,8 +166,13 @@ public class DuccHandlerProxy extends Du
 			}
 		}
 		catch(Throwable t) {
-			duccLogger.info(location, jobid, "", t.getMessage(), t);
-			duccLogger.error(location, jobid, t);
+			if(isIgnorable(t)) {
+				duccLogger.debug(location, jobid, t);
+			}
+			else {
+				duccLogger.info(location, jobid, "", t.getMessage(), t);
+				duccLogger.error(location, jobid, t);
+			}
 		}
 	}
 

Modified: uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandlerUserAuthentication.java
URL: http://svn.apache.org/viewvc/uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandlerUserAuthentication.java?rev=1444055&r1=1444054&r2=1444055&view=diff
==============================================================================
--- uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandlerUserAuthentication.java (original)
+++ uima/sandbox/uima-ducc/trunk/uima-ducc-web/src/main/java/org/apache/uima/ducc/ws/server/DuccHandlerUserAuthentication.java Fri Feb  8 15:13:40 2013
@@ -205,8 +205,13 @@ public class DuccHandlerUserAuthenticati
 			}
 		}
 		catch(Throwable t) {
-			duccLogger.info(methodName, jobid, "", t.getMessage(), t);
-			duccLogger.error(methodName, jobid, t);
+			if(isIgnorable(t)) {
+				duccLogger.debug(methodName, jobid, t);
+			}
+			else {
+				duccLogger.info(methodName, jobid, "", t.getMessage(), t);
+				duccLogger.error(methodName, jobid, t);
+			}
 		}
 		
 	}