[GitHub] [shardingsphere] terrymanu commented on a change in pull request #16314: Global schema lock basically usable completed

[GitBox <gi...@apache.org>]

terrymanu commented on a change in pull request #16314:
URL: https://github.com/apache/shardingsphere/pull/16314#discussion_r833499644



##########
File path: shardingsphere-jdbc/shardingsphere-jdbc-spring/shardingsphere-jdbc-core-spring/shardingsphere-jdbc-core-spring-namespace/src/test/java/org/apache/shardingsphere/spring/namespace/fixture/FixtureClusterPersistRepository.java
##########
@@ -54,8 +54,9 @@ public void persist(final String key, final String value) {
     }
     
     @Override
-    public void persistEphemeral(final String key, final String value) {
+    public boolean persistEphemeral(final String key, final String value) {

Review comment:
       It is better to return `void` value here, and catch exception in `tryLock` to return boolean value.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org