[jira] [Commented] (TEZ-1319) Remove methods annotated as @Private from TezClient

["Bikas Saha (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076779#comment-14076779 ] 

Bikas Saha commented on TEZ-1319:
---------------------------------

{code}-  private static String getDefaultTezDAGID(ApplicationId appId) {
+  @Private // Used only for MapReduce compatibility code
+  static String getDefaultTezDAGID(ApplicationId appId) {{code}

Can MRDAGClient just invoke super.getDAGClient() and then we dont need to make this method non-private.

Rest looks fine.

> Remove methods annotated as @Private from TezClient
> ---------------------------------------------------
>
>                 Key: TEZ-1319
>                 URL: https://issues.apache.org/jira/browse/TEZ-1319
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>            Priority: Blocker
>         Attachments: TEZ-1319.1.txt
>
>
> Both contain methods which are annotated as Private for YARNrunner usage. On important client facing APIs like TezClient and DAGClient, these should ideally not exist. Should be possible to create a custom client for YARNRunner.



--
This message was sent by Atlassian JIRA
(v6.2#6252)