[GitHub] [systemds] Baunsgaard commented on a change in pull request #1303: [SYSTEMDS-2994+2991] CLA Workload Analyzer and Workload Representation

[GitBox <gi...@apache.org>]

Baunsgaard commented on a change in pull request #1303:
URL: https://github.com/apache/systemds/pull/1303#discussion_r648590327



##########
File path: src/main/java/org/apache/sysds/runtime/compress/CompressedMatrixBlockFactory.java
##########
@@ -88,6 +89,10 @@ private CompressedMatrixBlockFactory(MatrixBlock mb, int k, CompressionSettings
 		return compress(mb, k, new CompressionSettingsBuilder().create());
 	}
 
+	public static Pair<MatrixBlock, CompressionStatistics> compress(MatrixBlock mb, int k, WTreeRoot root){
+		return compress(mb, k, new CompressionSettingsBuilder().create());
+	}

Review comment:
       yup, this PR simply wire up the tree to allow the compression instruction to use it, my WIP PR is the actual implementation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org