[GitHub] [superset] eschutho commented on a diff in pull request #21573: feat: add databricks form

[GitBox <gi...@apache.org>]

eschutho commented on code in PR #21573:
URL: https://github.com/apache/superset/pull/21573#discussion_r999775570


##########
superset/db_engine_specs/databricks.py:
##########
@@ -15,18 +15,85 @@
 # specific language governing permissions and limitations
 # under the License.
 
+import json
 from datetime import datetime
 from typing import Any, Dict, List, Optional, TYPE_CHECKING
 
+from apispec import APISpec
+from apispec.ext.marshmallow import MarshmallowPlugin
+from flask_babel import gettext as __
+from marshmallow import fields, Schema
+from marshmallow.validate import Range
 from sqlalchemy.engine.reflection import Inspector
+from sqlalchemy.engine.url import URL
+from typing_extensions import TypedDict
 
 from superset.constants import USER_AGENT
-from superset.db_engine_specs.base import BaseEngineSpec
+from superset.databases.utils import make_url_safe
+from superset.db_engine_specs.base import BaseEngineSpec, BasicParametersMixin
 from superset.db_engine_specs.hive import HiveEngineSpec
+from superset.errors import ErrorLevel, SupersetError, SupersetErrorType
+from superset.utils.network import is_hostname_valid, is_port_open
 
 if TYPE_CHECKING:
     from superset.models.core import Database
 
+ma_plugin = MarshmallowPlugin()

Review Comment:
   I need to remove this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org